Comments (5)
I discussed this in the cannons community and it is believed that the Movecraft-Cannons Addon doesn't include subcrafts. It works on normal crafts but subcrafts are ignored.
That shouldn't be the case, since Movecraft-Cannons should work on all crafts, but I didn't ever test it against subcrafts.
on the RotationListener it does not include
import net.countercraft.movecraft.craft.SubCraft;
and importnet.countercraft.movecraft.craft.SubcraftRotateCraft;
in the import list, so perhaps this is the reason?
This would not be the issue, the various *Craft
classes all implement Craft
, and as such there shouldn't need to be any special handling internally for a subcraft rotating vs a full craft rotating.
Can you include what Minecraft (e.g. paper-1.18.2-370), Movecraft, Movecraft-Cannons, and Cannons versions you are running?
Can you also elaborate on what you mean by this?
this is also seen on the cannon signs as their name changes when the subcraft is turned
I'm not aware of how to have cannon signs with names on them, but I also don't use the Cannons plugin often.
from movecraft-cannons.
I'm on spigot-1.18.2 using Movecraft 8.0.0-a.7, Movecraft-Cannons 1.0.0-a.8 and Cannons 2.5.12
In regards to the cannon sign, When you put a sign on a cannon so it can work on ships it provides info on that sign. It's always been recommended to put a sign physically onto a cannon in order to function on moving ships such as movecraft..
The first line is the name of the cannon (as cannons are created automatically it'll have a name like "classic 2" for example) under that is the owners name (or the one who made it) and then 3rd and 4th lines are some random info that I'm not too sure of.
When you turn the ship normally the sign stays the same. "Classic 2" is still "Classic 2" But if you turn the subcraft then look at the sign you'll notice the cannon name is changed. it'll be like "Classic 3" or something. Although the sign makes it obvious that the system consideres it a new cannon, it's made more obvious by the fact that right clicking the cannon flat out tells you that you made a cannon.
I have also tried the cannons without the sign incase it was two systems conflicting but the problem is the same regardless.
from movecraft-cannons.
In regards to the cannon sign, When you put a sign on a cannon so it can work on ships it provides info on that sign. It's always been recommended to put a sign physically onto a cannon in order to function on moving ships such as movecraft..
I was not aware of this, nor have I been using signs in my testing of cannons, I just used the default cannons from the tutorial video on some airships that I flew around.
from movecraft-cannons.
The sign feature was introduced before movecraft cannons. It was primarily used as a means of allowing cannons to maintain it's data while being moved either through movecraft or isails.
Upon recent tests I can confirm that with movecraft cannons the cannon sign is no longer needed on ships.
However the problem I have seems unique to subcrafts.
Here is a vid documenting the issue.
In the vid the subcraft is on it's own however the bug is present on subcrafts that are built on ships in the way you'd expect them to (such as a turret)
This is using the default turret craft file
from movecraft-cannons.
from movecraft-cannons.
Related Issues (18)
- [Feature Request] Per-craft cannon limits HOT 5
- Cannon rotation reports HOT 2
- Working cannon reports HOT 3
- cannons reset when craft is repiloted HOT 11
- Aiming mode cannons bug HOT 4
- StackOverflowError - Could not pass event EntityDamageByEntityEvent to Cannons HOT 4
- Cannons being unbought when a craft moves in any way
- Download? HOT 1
- Not functioning HOT 4
- Director aiming HOT 11
- Error on ship movement HOT 2
- Disabling cannons if not on a piloted craft HOT 2
- 1.16.5 Support HOT 4
- Cannons have to be rebought when movecraft moves HOT 5
- Cannons and Server software incompatibilities? HOT 4
- Cannons being unregistered on craft movement HOT 1
- Cannon translation reports HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from movecraft-cannons.