Git Product home page Git Product logo

Comments (8)

moritzraho avatar moritzraho commented on July 27, 2024 1

Hi @honstar, thanks, I will open a repository in git.corp and go through the open sourcing process to get it as part of the adobe org.

from aio-lib-ims.

moritzraho avatar moritzraho commented on July 27, 2024

The src/ims.js already provides async getAccessToken (authCode, clientId, clientSecret, scopes) { the idea is that the plugin would wrap this function to additionally provide context and caching mechanisms

from aio-lib-ims.

honstar avatar honstar commented on July 27, 2024

@moritzraho @shazron : I started working on a separate plugin and have a working version running on my local machine. Can you guys let me know how to proceed in terms of logistics? Shall I raise a PR from my personal space?

from aio-lib-ims.

honstar avatar honstar commented on July 27, 2024

Here's a PR for review: https://github.com/honstar/aio-lib-ims-s2s/pull/1. cc: @moritzraho @shazron @meryllblanchet

from aio-lib-ims.

moritzraho avatar moritzraho commented on July 27, 2024

In the meantime we will look at your PR 🙂 , thank you so much !

from aio-lib-ims.

moritzraho avatar moritzraho commented on July 27, 2024

Also, you can open a PR against this repository to integrate your plugin into: https://github.com/adobe/aio-lib-ims/blob/master/src/token-helper.js in the same way the jwt plugin is handled there. (we will publish the npm package later, but we will be able to test through local linking)

from aio-lib-ims.

honstar avatar honstar commented on July 27, 2024

@moritzraho : I can do that, sure. Shall I use @adobe/aio-lib-ims-s2s already and you start testing via local linking?

from aio-lib-ims.

moritzraho avatar moritzraho commented on July 27, 2024

@moritzraho : I can do that, sure. Shall I use @adobe/aio-lib-ims-s2s already and you start testing via local linking?

Sure I think @adobe/aio-lib-ims-s2s is a good name maybe let's ask @meryllblanchet too for the naming?

from aio-lib-ims.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.