Comments (8)
Hi @honstar, thanks, I will open a repository in git.corp and go through the open sourcing process to get it as part of the adobe org.
from aio-lib-ims.
The src/ims.js
already provides async getAccessToken (authCode, clientId, clientSecret, scopes) {
the idea is that the plugin would wrap this function to additionally provide context and caching mechanisms
from aio-lib-ims.
@moritzraho @shazron : I started working on a separate plugin and have a working version running on my local machine. Can you guys let me know how to proceed in terms of logistics? Shall I raise a PR from my personal space?
from aio-lib-ims.
Here's a PR for review: https://github.com/honstar/aio-lib-ims-s2s/pull/1. cc: @moritzraho @shazron @meryllblanchet
from aio-lib-ims.
In the meantime we will look at your PR 🙂 , thank you so much !
from aio-lib-ims.
Also, you can open a PR against this repository to integrate your plugin into: https://github.com/adobe/aio-lib-ims/blob/master/src/token-helper.js in the same way the jwt plugin is handled there. (we will publish the npm package later, but we will be able to test through local linking)
from aio-lib-ims.
@moritzraho : I can do that, sure. Shall I use @adobe/aio-lib-ims-s2s
already and you start testing via local linking?
from aio-lib-ims.
@moritzraho : I can do that, sure. Shall I use @adobe/aio-lib-ims-s2s already and you start testing via local linking?
Sure I think @adobe/aio-lib-ims-s2s is a good name maybe let's ask @meryllblanchet too for the naming?
from aio-lib-ims.
Related Issues (20)
- getSusiUrl should allow defaults HOT 1
- Support OAuth Server-to-Server credentials HOT 2
- aio logger debug logging is logging client_secret and tokens HOT 1
- OAuth Server-to-Server incorrect parameter documentation HOT 1
- OAuth Server-to-Server App Builder Error HOT 5
- Consolidate `token-helper` test files into one HOT 1
- Token generation in Adobe I/O Runtime action: unclear local option for the initial context.set call HOT 1
- Provide an unsetCurrentContext method ?
- Remove field "technical_account_email" HOT 8
- access_token is stored in global conf not local .aio HOT 5
- Link to missing documentation for forced IMS Login HOT 2
- better error message for context token generation HOT 1
- Add back configurable access token creation plugin support HOT 1
- improve e2e tests with retry and exponential fallback HOT 1
- Use @adobe/aio-lib-core-errors HOT 3
- add proxy support HOT 1
- support no-caching option
- Support passing additional options to plugin imsLogin function
- README.md -Link leads to "branch not found - ERROR 404" HOT 1
- CLI login: Cannot logout and login again into another Org. Need to clean cookies. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aio-lib-ims.