Git Product home page Git Product logo

Comments (5)

purplecabbage avatar purplecabbage commented on July 27, 2024 1

Thanks @arobsco! This is now fixed and will be released soon.
Had you sent a pr we would have happily accepted it. We ended up not doing it exactly as you did, but your workaround helped isolate the issue.

from aio-lib-ims.

arobsco avatar arobsco commented on July 27, 2024

Seems to be related to the WEBPACK_ACTION_BUILD condition. When removing the conditional include of the oauth package the code above works as expected

aio-lib-ims/src/token-helper.js

Line 32 in d45606d

const ACTION_BUILD = (typeof WEBPACK_ACTION_BUILD === 'undefined') ? false : WEBPACK_ACTION_BUILD

from aio-lib-ims.

arobsco avatar arobsco commented on July 27, 2024

@shazron can you confirm if moving the oauthSTS KVP to

aio-lib-ims/src/token-helper.js

Line 25 in d45606d

let DEFAULT_CREATE_TOKEN_PLUGINS = {
and the conditional require on

aio-lib-ims/src/token-helper.js

Line 36 in d45606d

const imsOAuthSTSPlugin = require('@adobe/aio-lib-ims-oauth/src/ims-oauth_server_to_server')
to the head is the fox, this is what I've done in a private patch and appears to resolve the issue.

from aio-lib-ims.

aiojbot avatar aiojbot commented on July 27, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2417

from aio-lib-ims.

arobsco avatar arobsco commented on July 27, 2024

Great stuff, thanks @purplecabbage. I know you guys have internal repos and what not so wasn't sure if it was worth PRing or not! Know for the future!

from aio-lib-ims.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.