adfinis / ember-uikit Goto Github PK
View Code? Open in Web Editor NEWThe ember implementation of UIkit
Home Page: https://adfinis.github.io/ember-uikit/
License: MIT License
The ember implementation of UIkit
Home Page: https://adfinis.github.io/ember-uikit/
License: MIT License
ember-truth-helpers
and ember-composable-helpers
seem to be required for the addon to work, e.g. UkButton
throws exceptions when they are not installed. We should add them to the blueprint to make sure they're installed.
Is anyone working on adding a uk-modal component? I have one I've been using that is more-or-less ready for review.
I don't know if y'all are interested in this, but I'm going to make a PR.
Currently, running ember-uikit in fastboot throws an error due to document
not being defined in fastboot.
Thanks for getting this wrapper started. I'm looking forward to contributing more.
I made a component today for UIkit's sortable component. I still need to add some more tests and finish the template for the demo site. Before I go too far with the demo site, I'd like some feedback on my approach to adding the component specific events and attributes. I noticed the evented mixin, it didn't seem right to add component specific events there. I'm sure I didn't follow some of your style conventions.
Anyway, I'll make whatever style/design adjustments and work on the demo page if y'all are interested in a PR.
Here's the commit to my fork: jayvarner@c428513
Could probably be based on the uk-subnav component.
The reason behind needing a component for the navigation is that we need to set the uk-active
class on the container (i.e. LI
) instead of the link which is what link-to
does.
We currently yield inside uk-modal-body
which prohibits the developer from adding a heading and/or footer.
When using a modal and having a scroll, under some circumstances when clicking anywhere the page will scroll to the top again.
The issue seems to come from focus-trap, this is a issue with a similar problem
focus-trap/focus-trap#104
Currently there is no released version of focus-trap with the fix, which could be used in ember-focus-trap, to potentially fix the scrolling problem.
In the _filterComponents
method of index.js
file whitelist
entries are ignored if blacklist
is not empty.
But the script automatically add uk-icon
to blacklist if option useIcons
is true. This behavior cause the whitelist to be ignored.
It would be nice if we had acceptance tests which tests the whole documentation.
ember-uikit/addon/components/uk-modal.js
Lines 31 to 33 in 6491c58
Probably needs to have a testing condition. Which returns #ember-testing
as the selector in tests, as that is the correct container.
This is a more complicated one.. It has to work with the flex and width mixins also child-width
must be setable
We should allow users to use ember-uikit without icons, since they increase the payload a lot.
Consider switching to ember-qunit
with qunit-dom
for testing since it seems that ember-mocha
is not moving forward like qunit does..
Currently the <UkButton />
Component does not support the color "danger" . This could be useful for e.g. a cancel button in a form.
DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from: Class._getNodeModulesPath (/*********/node_modules/ember-uikit/index.js:215:58)
1.14.2
to 1.14.3
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
prettier is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
π Changelog
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
We need to add the emberobserver badge as soon as we are rated!
ember-uikit\components\heading.scss:125:26
Error: expected selector.
β·
125 β .uk-heading-primary when ($deprecated = true){
is it possible to add the following code to the item sub-component of uk-switcher:
setEvents() {
let events = {
beforeshow: this.getWithDefault("on-beforeshow", noop),
show: this.getWithDefault("on-show", noop),
shown: this.getWithDefault("on-shown", noop),
beforehide: this.getWithDefault("on-beforehide", noop),
hide: this.getWithDefault("on-hide", noop),
hidden: this.getWithDefault("on-hidden", noop)
};
for (let event in events) {
UIkit.util.on(this.element, event, events[event]);
}
},
didInsertElement() {
this._super(...arguments);
this.setEvents();
}
to enable the event handling. Thanks
2.3.0
to 2.3.1
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-code-snippet is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 3 commits.
ad44087
releasing
96060d9
Merge pull request #54 from AndreJoaquim/update-glob-to-remove-deprecation-warn
82681f6
Update glob to remove minimatch deprecation warn
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
The documentation listed in the readme (https://docs.adfinis.com/ember-uikit) is currently 404-ing.
Mixin is already there, we just need to expose it as component
Mixin is already there, we just need to expose it as component
Hello,
I tried to install this package but transitive dependencies downloading like "ember-uikit/variable-themes" failed.
I use broccoli-sass to compile scss file which content :
@import "node_modules/ember-uikit/app/styles/ember-uikit.scss"
I would not use "ember-cli-sass" because I have already several transformations of css files in my Ember App.
Thanks for your help.
After testing if the updates from Renovate broke anything I found this error. As it also exists on the GitHub Pages this will (most likely) not be related to these updates.
The route and component do exist. I don't really know what else to check.
You attempted to generate a link for the "components.subnav" route, but did not pass the models required for generating its dynamic segments. There is no route named components.subnav
3.0.0
to 3.0.1
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-cli-htmlbars is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 4 commits.
48a5b69
release v3.0.1 π
fcf265a
fix memory leak (adapted from @arthirmβs ember-cli/ember-cli-htmlbars-inline-precompile#112)
28d825f
Merge pull request #124 from ember-cli/upgrades
c54e610
Bump deps
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
Hey folks!
Running ember install ember-uikit
fails the first time. Running the command again finishes fine.
β― ember install ember-uikit
π§ Installing packages... This might take a couple of minutes.
Yarn: Installed ember-uikit
Install failed. Could not find addon with name: ember-uikit
3.0.0-rc.9-dev.bd39d353
to 3.0.0-rc.16
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
uikit is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 75 commits.
0cdd172
Merge tag 'v3.0.0-rc.16' into develop
b2e1ef1
Merge branch 'release/v3.0.0-rc.16'
53b3fb2
v3.0.0-rc.16
6fac5bb
Fix regression in Overflow Auto component
d004bda
Merge tag 'v3.0.0-rc.15' into develop
dfdb5b9
Merge branch 'release/v3.0.0-rc.15'
c95395e
v3.0.0-rc.15
4dd8f60
typo
8160f31
Rename selModal to selContainer adn selPanel to selContent in Overflow Auto component
b8709a5
add overflow auto test to utility component
a0d0320
cleanup video test text
de76a09
improve isNode check
de71b8d
fix: isInView
function for elements with zero width and height
60d0a08
Merge branch 'release/v3.0.0-rc.14'
a7f7466
Merge tag 'v3.0.0-rc.14' into develop
There are 75 commits in total.
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.
Error type: Cannot find preset's package (github>projectcaluma/renovate-config)
We should find a better way for solving those problems than mixins, since mixins are an antipattern for the new class syntax.
As the title says, change the Beta scenario test to allow fails.
Canary and Beta are unstable Branches, that's why it should also be allowed to fail.
This addon forces a sass recompilation for any changes that happen while in ember server modus, even though no sass files changed.
ember install ember-uikit
.js
file for instance controller/application.js
Since our app has quite lot to compile it adds 3-4 seconds of rebuild time everytime we change something not sass related. Which slows down productivity.
Is there something I can do to change it that it only recompiles when a scss file did change?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.