Comments (3)
First of all, thank you for contributing! Since we can only work on this infrequently, we are really glad someone other than us is interested in a progress on this.
You were right not to use the evented mixin. Those are simply all ember events converted to our naming convention. I looked at your commit and added some comments - mostly just nitpicking about our conventions (https://github.com/adfinis-sygroup/ember-uikit/blob/master/CONTRIBUTING.md). If you don't understand something I wrote, feel free to ask.
We are really interested in a PR for this feature, so feel free to open it!
from ember-uikit.
OK, I mostly have this wrapped up but I have questions about how y'all want to move forward.
-
I set up the import for UIkit (instead of using
/* global UIkit */
) by basically using the method described here and here using avendor/shims/uikit.js
shim and importing it along with thenode_modules/uikit/js/dist/uikit.js
file. It works, but I'm not 100% this is still the correct method. If it is, it seems I should open a separate issue/PR for that. -
I haven't finished the demo page because I'm running into some issues with updating the options. The sortable component has to be reinitialized for the new options to take effect. I first tried to update the component using UIkit's
component.$update()
method, but that didn't work:
didInsertElement() {
set(this, 'ukSortable', UIkit.sortable(this.element);
},
didUpdate() {
get(this, 'ukSortable').$update();
}
I tried various other ways of calling update()
with no success. However, this works:
didInsertElement() {
set(this, 'ukSortable', UIkit.sortable(this.element);
},
willUpdate() {
get(this, 'ukSortable').$destroy();
},
didUpdate() {
set(this, 'ukSortable', UIkit.sortable(this.element));
}
I don't feel good about that. Maybe y'all have better ideas.
from ember-uikit.
I set up the import for UIkit (instead of using /* global UIkit */) by basically using the method described here and here using a vendor/shims/uikit.js shim and importing it along with the node_modules/uikit/js/dist/uikit.js file. It works, but I'm not 100% this is still the correct method. If it is, it seems I should open a separate issue/PR for that.
I think this method you used is still best practice unless you have a named or an anonymous AMD export in your external lib (https://ember-cli.com/user-guide/#standard-anonymous-amd-asset). As far as I remember, I tried using this but failed because UIkit does some other export before the AMD. So this is OK!
I haven't finished the demo page because I'm running into some issues with updating the options. The sortable component has to be reinitialized for the new options to take effect. I first tried to update the component using UIkit's component.$update() method, but that didn't work:
I had the same problem with the uk-tab
component. I couldn't find a fast and clean solution, so I just disabled interaction out of laziness.. 😉 However, this is something we need to find a good solution which applies for all components.
I don't feel good about that. Maybe y'all have better ideas.
Me neither, sadly I don't have a better idea.. UIkit says they can handle DOM manipulations but obviously they can't handle updating properties (https://getuikit.com/docs/javascript#uikit-and-reactive-javascript-frameworks).
I may be able to invest some time in this too later this week.
from ember-uikit.
Related Issues (20)
- Add color "danger" to UkButton HOT 2
- Modal is flaky in testing
- Add uk-nav component
- Modal: Find a way to allow for heading, body, and footer HOT 4
- Action Required: Fix Renovate Configuration
- There is no route named components.subnav HOT 1
- add Event handling for uk-switcher component HOT 4
- Move away from mixins HOT 1
- @import dependencies failed HOT 5
- Page scrolls up on click anywhere HOT 4
- whitelist does not work when `useIcons` is true HOT 1
- An in-range update of ember-cli-htmlbars is breaking the build 🚨 HOT 2
- Recompile without sass changes HOT 1
- Use renovate instead of greenkeeper HOT 1
- Change beta test to allow to fail HOT 1
- can't build success in ember 3.9.0 HOT 4
- Uikit 3.1 breaking build HOT 1
- Interactive documentation listed in the readme 404s HOT 2
- ember install ember-uikit fails the first time HOT 1
- Addon dependencies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-uikit.