adfinis / ember-uikit Goto Github PK

Probably needs to have a testing condition. Which returns #ember-testing as the selector in tests, as that is the correct container.

We should allow users to use ember-uikit without icons, since they increase the payload a lot.

Mixin is already there, we just need to expose it as component

After testing if the updates from Renovate broke anything I found this error. As it also exists on the GitHub Pages this will (most likely) not be related to these updates.

The route and component do exist. I don't really know what else to check.

You attempted to generate a link for the "components.subnav" route, but did not pass the models required for generating its dynamic segments. There is no route named components.subnav

Consider switching to ember-qunit with qunit-dom for testing since it seems that ember-mocha is not moving forward like qunit does..

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>projectcaluma/renovate-config)

We need to add the emberobserver badge as soon as we are rated!

I made a component today for UIkit's sortable component. I still need to add some more tests and finish the template for the demo site. Before I go too far with the demo site, I'd like some feedback on my approach to adding the component specific events and attributes. I noticed the evented mixin, it didn't seem right to add component specific events there. I'm sure I didn't follow some of your style conventions.

Anyway, I'll make whatever style/design adjustments and work on the demo page if y'all are interested in a PR.

Here's the commit to my fork: jayvarner@c428513

We should find a better way for solving those problems than mixins, since mixins are an antipattern for the new class syntax.

We currently yield inside uk-modal-body which prohibits the developer from adding a heading and/or footer.

Hey folks!

Running ember install ember-uikit fails the first time. Running the command again finishes fine.

❯ ember install ember-uikit

🚧  Installing packages... This might take a couple of minutes.
Yarn: Installed ember-uikit
Install failed. Could not find addon with name: ember-uikit

This is a more complicated one.. It has to work with the flex and width mixins also child-width must be setable

The dependency ember-cli-htmlbars was updated from 3.0.0 to 3.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-htmlbars is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

PR #89 pinned UiKit to version 3.0.3 since 3.1 causes build errors.

cc @fkm

This addon forces a sass recompilation for any changes that happen while in ember server modus, even though no sass files changed.

How to reproduce

1. create a new ember app
2. install ember-uikit ember install ember-uikit
3. start ember server
4. change something inside a .js file for instance controller/application.js
5. observe server logs and see that a SassCompiler did run:

Since our app has quite lot to compile it adds 3-4 seconds of rebuild time everytime we change something not sass related. Which slows down productivity.
Is there something I can do to change it that it only recompiles when a scss file did change?

Could probably be based on the uk-subnav component.

The reason behind needing a component for the navigation is that we need to set the uk-active class on the container (i.e. LI) instead of the link which is what link-to does.

It would be nice if we had acceptance tests which tests the whole documentation.

Is anyone working on adding a uk-modal component? I have one I've been using that is more-or-less ready for review.

As the title says, change the Beta scenario test to allow fails.

Canary and Beta are unstable Branches, that's why it should also be allowed to fail.

is it possible to add the following code to the item sub-component of uk-switcher:
setEvents() {
let events = {
beforeshow: this.getWithDefault("on-beforeshow", noop),
show: this.getWithDefault("on-show", noop),
shown: this.getWithDefault("on-shown", noop),
beforehide: this.getWithDefault("on-beforehide", noop),
hide: this.getWithDefault("on-hide", noop),
hidden: this.getWithDefault("on-hidden", noop)
};

for (let event in events) {
  UIkit.util.on(this.element, event, events[event]);
}

},
didInsertElement() {
this._super(...arguments);
this.setEvents();
}
to enable the event handling. Thanks

Currently the <UkButton /> Component does not support the color "danger" . This could be useful for e.g. a cancel button in a form.

ember-uikit\components\heading.scss:125:26

Error: expected selector.
╷
125 │ .uk-heading-primary when ($deprecated = true){

The documentation listed in the readme (https://docs.adfinis.com/ember-uikit) is currently 404-ing.

When using a modal and having a scroll, under some circumstances when clicking anywhere the page will scroll to the top again.

The issue seems to come from focus-trap, this is a issue with a similar problem
focus-trap/focus-trap#104

Currently there is no released version of focus-trap with the fix, which could be used in ember-focus-trap, to potentially fix the scrolling problem.

The devDependency ember-code-snippet was updated from 2.3.0 to 2.3.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-code-snippet is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

In the _filterComponents method of index.js file whitelist entries are ignored if blacklist is not empty.

But the script automatically add uk-icon to blacklist if option useIcons is true. This behavior cause the whitelist to be ignored.

Mixin is already there, we just need to expose it as component

I don't know if y'all are interested in this, but I'm going to make a PR.

Currently, running ember-uikit in fastboot throws an error due to document not being defined in fastboot.

Thanks for getting this wrapper started. I'm looking forward to contributing more.

The devDependency prettier was updated from 1.14.2 to 1.14.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

prettier is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

ember-truth-helpers and ember-composable-helpers seem to be required for the addon to work, e.g. UkButton throws exceptions when they are not installed. We should add them to the blueprint to make sure they're installed.

The dependency uikit was updated from 3.0.0-rc.9-dev.bd39d353 to 3.0.0-rc.16.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

uikit is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Hello,

I tried to install this package but transitive dependencies downloading like "ember-uikit/variable-themes" failed.

I use broccoli-sass to compile scss file which content :
@import "node_modules/ember-uikit/app/styles/ember-uikit.scss"

I would not use "ember-cli-sass" because I have already several transformations of css files in my Ember App.

Thanks for your help.