zafarali / emdp Goto Github PK

The correct solution would be to move version into a new file version.py and then import that in setup.py

• Add plotting tools used in https://arxiv.org/abs/1807.04106 contributed by @Philip-Bachman

• Visualize the grid world
• Visualize trajectories

Error encountered while running the example code for gridworld - "build_SB_example35" function.
This is because calling the GridWorldMDP __init__() function calls the __init__() for MDP class, which in turn runs the reset() function. The overloaded reset() function for the GridWorldMDP class is then called instead of the MDP.reset().
A potential solution is to define self.size, self.human_state and self.has_absorbing_states prior to calling super.__init__(). However, a more object-oriented solution is probably possible.

The builder introduced in #7 doesn't have any tests. Even though it seems like everything is happening correctly, unit testing is necessary to ensure that there are no hidden bugs in corner cases.

Something like

creator = MDPCreator()
creator.add_block_at()
creator.add_wall_at()
...