'GridWorldMDP' object has no attribute 'size' about emdp HOT 5 CLOSED

zafarali commented on June 18, 2024

'GridWorldMDP' object has no attribute 'size'

from emdp.

Comments (5)

zafarali commented on June 18, 2024 1

Thanks for fixing this! It is now in the master branch with the reset() function from GridWorldMDP passing tests.

from emdp.

zafarali commented on June 18, 2024

Hi thanks for reporting! I think this might have been caused by 246086d If you want to send a possible solution or a PR with that reverted I’ll be happy to accept it.

…

On Fri, Jan 31, 2020 at 12:02 AM Arna Ghosh ***@***.***> wrote: Error encountered while running the example code for gridworld - "build_SB_example35" function. This is because calling the GridWorldMDP *init*() function calls the *init*() for MDP class, which in turn runs the reset() function. The overloaded reset() function for the GridWorldMDP class is then called instead of the MDP.reset(). A potential solution is to define self.size, self.human_state and self.has_absorbing_states prior to calling super.*init*(). However, a more object-oriented solution is probably possible. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=ABQA57GOR6HJ5BN3QAT5BNLRAOWHVA5CNFSM4KOBOLZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKBDWPQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQA57BGCO3DIQHRYU244GDRAOWHVANCNFSM4KOBOLZQ> .

from emdp.

zafarali commented on June 18, 2024

I fixed the issue in a recent commit. Sorry for the trouble. If you want to suggest a better fix I am happy to consider and accept. I will leave this issue open.

from emdp.

arnaghosh commented on June 18, 2024

Hey thanks for your prompt reply. I feel removing the GridWorldMDP class reset function doesn't set the self.human_state at the initialization. This may affect other functions that use this variable to render the env graphically.
I feel assigning the extra variables (like size) that are not required by the MDP init prior to calling super.__init__ is a better workaround. This is what it would look like:

        if not convert_terminal_states_to_ints:
            terminal_states = list(map(lambda tupl: int(size * tupl[0] + tupl[1]), terminal_states))
        self.size =  size
        self.human_state = (None, None)
        self.has_absorbing_state = len(terminal_states) > 0
        super().__init__(P, R, gamma, p0, terminal_states, seed=seed, skip_check=skip_check)
        # self.reset()

    def reset(self):
        super().reset()
        self.human_state = self.unflatten_state(self.current_state)

from emdp.

arnaghosh commented on June 18, 2024

Created a PR (#19) with this change.

from emdp.

'GridWorldMDP' object has no attribute 'size' about emdp HOT 5 CLOSED

Comments (5)

Related Issues (8)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent