Git Product home page Git Product logo

Comments (2)

cliffordwolf avatar cliffordwolf commented on July 19, 2024

I've now fixed the performance problem in git commit 9a34486.

Note that the code you posted is not valid synthesizable code! You create BITS+1 conflicting drivers for out here. In cases like this with N conflicting drivers and latched logic (logic loops), the opt_mux pass had a complexity of O(N!). There was no performance problem in valid synthesizable code.

I think you intended to write something like the following instead:

/* Count leading zeroes by independent prefix comparison: works for non-power-of-two sizes: */
module count_leading_zeroes (in, out);
    parameter BITS = 4; /* no problem */
/* set parameter BITS = 32 or some BIG_NUMBER and watch the optimizer spinning.... */
    localparam OUT_BITS = $clog2(BITS) + 1;
    input [BITS-1:0] in;
    output reg [OUT_BITS-1:0] out;
    integer i;
    always @(*) begin
        for (i=0; i<BITS; i=i+1) begin
            if (in[BITS-1:BITS-1-i] == { { i { 1'b0 } }, 1'b1 }) begin
                out = i;
            end
        end
        if (in == 0) begin
            out = { 1'b1 , { OUT_BITS - 1 { 1'b0 } } };
        end
    end
endmodule

This of course still models a latched logic block (logic loop), which is generally considered bad design style. So this version of your code only fixes the issue with the conflicting drivers.

from yosys.

Siesh1oo avatar Siesh1oo commented on July 19, 2024

That's indeed correct, thank you for the quick response! Is it possible to issue a warning in this case?

from yosys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.