yhwong20 / pe Goto Github PK

Sections are ordered in an illogical manner, and feel out of place.

Autosave section is inserted between generate and records section.

These two sections feel out of place as well (given their position in the UG).

A C symbol should not be present in the class diagram.

#-+ symbols to denote access modifiers are not present in the diagram.

If 0 is passed as an argument to -n, the problem sets all have ID of 1. This ID is duplicated. Should IDs be uniquely generated?

Shortform commands like gen are supported in the application, but are not listed down in the UG.

No details provided by bug reporter.

Too many arrows.

Class associations are not represented correctly. The correct way:

Assuming the user has a JAR file of the application, the provided method of launching the application is incorrect.

How will the user download your mathGenius.java file?

The program does not recognize that an extra -n parameter was provided. If the argument for the extra parameter is invalid then the program completely ignores the prior argument value (which may have been valid).
e.g., gen -t + -n 1 -d 1 -l 2 -n -1 makes the program assume that no valid -n argument has been provided.

If any inputs passed in to generate are invalid, the program automatically creates problems for the user.

This may be pointless, as the user now has a new problem set which is created using default parameters that they may not have wanted/specified.

No class diagram or sequence diagram present.

Absence of self-invoke activation bars:

Return arrows are missing:

Footer box should not be present:

UG states that the arguments provided can be any positive integer, but the help command outputs are more specific than that.

If 0 is provided as an argument to -n, no problems are generated.

If 0 is provided as an argument to -d, then all the operands in the problems are 0. This is not very meaningful.

Input validation for these arguments do not match the UG/help commands.

Missing sequence diagrams and class diagrams.

Code snippet is too long.

Missing sequence diagram and class diagram.

Explanation is way too long and can be simplified with the help of diagrams.

No class diagrams or sequence diagrams.

Everything is crammed into an overall diagram, and this makes the overall diagrams hard to understand and read.