The ahbottomnavigation from wix-playground

ahbottomnavigation's People

Contributors

Stargazers

Watchers

ahbottomnavigation's Issues

jCenter issue

Hi,

I was using the default com.aurelhubert:ahbottomnavigation:2.3.4 but development just stopped for not reason.

I notice that this fork was updated but since I updated Android Studio I had to replace jCenter to mavenCentral causing this Failed to resolve: com.aurelhubert:ahbottomnavigation:2.3.4

Can someone please advise the new way to declare this? And if this is forked from the original one why it's 2.1.0 and not 2.3.4?

Thank you

Putting TestIDs in Content Description for Appium

Hello! My team uses Appium for e2e tests, which does accessibility label lookups to find elements. On Android, this translates to looking up elements by their content description.

We've been unable to grab react-native-navigation tabs by their testID, because the content description contains other accessibility text:

ahbottomnavigation/ahbottomnavigation/src/main/java/com/aurelhubert/ahbottomnavigation/AHBottomNavigation.java

Lines 660 to 670 in b0db704

 private void setTabAccessibilityLabel(int itemIndex, int currentItem) { 

 AHBottomNavigationItem item = items.get(itemIndex); 

 String contentDescription = currentItem == itemIndex ? "selected, " : ""; 

 if (item.getTitle(context) != null) contentDescription += (item.getTitle(context) + ", "); 

 if (AHHelper.isInteger(notifications.get(itemIndex).getReadableText())) { 

 int num = Integer.parseInt(notifications.get(itemIndex).getReadableText()); 

 contentDescription += (num + " new item" + (num == 1 ? "" : "s") + ", "); 

 } 

 contentDescription += "tab, " + (itemIndex + 1) + " out of " + getItemsCount(); 

 views.get(itemIndex).setContentDescription(contentDescription); 

 }

Would you accept a PR setting the content description of the tabs to their testID instead of what they are now?

Recommend Projects

wix-playground / ahbottomnavigation Goto Github PK

ahbottomnavigation's People

Contributors

Stargazers

Watchers

Forkers

ahbottomnavigation's Issues

jCenter issue

Putting TestIDs in Content Description for Appium

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	private void setTabAccessibilityLabel(int itemIndex, int currentItem) {
	AHBottomNavigationItem item = items.get(itemIndex);
	String contentDescription = currentItem == itemIndex ? "selected, " : "";
	if (item.getTitle(context) != null) contentDescription += (item.getTitle(context) + ", ");
	if (AHHelper.isInteger(notifications.get(itemIndex).getReadableText())) {
	int num = Integer.parseInt(notifications.get(itemIndex).getReadableText());
	contentDescription += (num + " new item" + (num == 1 ? "" : "s") + ", ");
	}
	contentDescription += "tab, " + (itemIndex + 1) + " out of " + getItemsCount();
	views.get(itemIndex).setContentDescription(contentDescription);
	}