Putting TestIDs in Content Description for Appium about ahbottomnavigation HOT 3 OPEN

Hello! My team uses Appium for e2e tests, which does accessibility label lookups to find elements. On Android, this translates to looking up elements by their content description.

We've been unable to grab react-native-navigation tabs by their testID, because the content description contains other accessibility text:

ahbottomnavigation/ahbottomnavigation/src/main/java/com/aurelhubert/ahbottomnavigation/AHBottomNavigation.java

Lines 660 to 670 in b0db704

	private void setTabAccessibilityLabel(int itemIndex, int currentItem) {
	AHBottomNavigationItem item = items.get(itemIndex);
	String contentDescription = currentItem == itemIndex ? "selected, " : "";
	if (item.getTitle(context) != null) contentDescription += (item.getTitle(context) + ", ");
	if (AHHelper.isInteger(notifications.get(itemIndex).getReadableText())) {
	int num = Integer.parseInt(notifications.get(itemIndex).getReadableText());
	contentDescription += (num + " new item" + (num == 1 ? "" : "s") + ", ");
	}
	contentDescription += "tab, " + (itemIndex + 1) + " out of " + getItemsCount();
	views.get(itemIndex).setContentDescription(contentDescription);
	}

Would you accept a PR setting the content description of the tabs to their testID instead of what they are now?

Hey @talenfisher,

Today we are using tags for test ids, Appuim can use tags when using Espresso only, but, in order to use contentDescription you may consider apps that use contentDescription for its intended usage, and prevent clash with values of such attribute.

My suggestion is to plan a way to switch contentDescription based on the environment, test or production, which can be even generic for each view. wdyt?

from ahbottomnavigation.

My suggestion is to plan a way to switch contentDescription based on the environment, test or production

I like that - good call.

which can be even generic for each view. wdyt?

By this, do you mean relying on a property passed down through react-native-navigation to determine whether contentDescription or viewtag should be used for the testID? I'm not sure I'd want to do this for each individual tab. However, if it's just a single property that decides this for every tab in the bottom navigation, I think that is definitely preferable.

from ahbottomnavigation.

yup, on android for each view you can call setContentDescription and that simulates the accessibility id, but, I found it troublesome, see this old discussion, it might give you a basic idea of what issues you may face, especially using TextViews, EditTexts and other non-image views.

from ahbottomnavigation.