Git Product home page Git Product logo

Comments (9)

gregpalaci avatar gregpalaci commented on August 19, 2024 2

To confirm does this action at least cache the node version it downloads as per the README
When it says optionanlly is that the default behavior and if not how do we toggle this option to yes (I don't see in the API docs).

image

Would really appreciate feature parity with setup-node and cache yarn/npm etc packages if possible.

cheers and thanks for the action so far!

from action.

just-Bri avatar just-Bri commented on August 19, 2024 1

Was wondering if this request includes caching of yarn packages.
That's something I was doing with the setup-node action but it seems to be missing here.

Not a huge problem but would be nice to see yarn/npm/pnpm package caching as well.

from action.

gregpalaci avatar gregpalaci commented on August 19, 2024 1

you can use the pinned volta version from package.json with setup-node action

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
  with:
    node-version-file: 'package.json'
    cache: 'yarn'

Or you can role your own with volta action and the cache action

from action.

avarun42 avatar avarun42 commented on August 19, 2024

When using this action without manually specifying node-version or yarn-version. We should be able to cache based on the volta key in package.json, and avoid having to download node/volta/etc if nothing has changed.

Would be great to have this feature implemented

from action.

rwjblue avatar rwjblue commented on August 19, 2024

@just-Bri - Yes, I was thinking that would be included when we do this work...

from action.

just-Bri avatar just-Bri commented on August 19, 2024

@just-Bri - Yes, I was thinking that would be included when we do this work...

I figured as much but wanted to call it out directly to make sure. The issue doesn't specify caching of installed node packages, I was afraid it was referring to just Volta/node/npm/yarn/pnpm and not the packages installed installed via an npm i

from action.

jasikpark avatar jasikpark commented on August 19, 2024

Anyone mind mentoring me on implementing this feature? I use setup-node everywhere, but I wish it would consume my volta config.. would be nice to enable similar caching setup in this action && get my node and npm versions synced perfectly 😁

from action.

cgrabmann avatar cgrabmann commented on August 19, 2024

Would really be nice if the action would just cache and restore the downloaded tools, since I ran into a situation multiple times now, where the Node Download timed out. It would not need to be downloaded again if it would be cached since the version does not change most of the time anyway.

from action.

gregpalaci avatar gregpalaci commented on August 19, 2024

Would really be nice if the action would just cache and restore the downloaded tools, since I ran into a situation multiple times now, where the Node Download timed out. It would not need to be downloaded again if it would be cached since the version does not change most of the time anyway.

you might just want a GH / NPM token to prevent timeouts @cgrabmann

  - name: Setup node
    uses: actions/setup-node@v3
    with:
      cache: 'yarn'
      token: '${{ secrets.YOUR_GH_TOKEN }}'
      node-version-file: 'package.json'

from action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.