Comments (9)
To confirm does this action at least cache the node version it downloads as per the README
When it says optionanlly is that the default behavior and if not how do we toggle this option to yes (I don't see in the API docs).
![image](https://private-user-images.githubusercontent.com/1177690/244702887-87d19400-4ab5-48de-862a-7d1747da2243.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk2MzU1MDgsIm5iZiI6MTcwOTYzNTIwOCwicGF0aCI6Ii8xMTc3NjkwLzI0NDcwMjg4Ny04N2QxOTQwMC00YWI1LTQ4ZGUtODYyYS03ZDE3NDdkYTIyNDMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDVUMTA0MDA4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MmQ1NWQ3N2Y5MWQxYTllZTk2MWQ4YmY2NDZiZTRiNjkxODcwNGQxZDQ4YWYyMmM5N2M4MDBkNjAxYmJlMzk3ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.M2BMlbfRngKCi-AaF3U08cYMmcR8lpBopuIg5aKbKj0)
Would really appreciate feature parity with setup-node and cache yarn/npm etc packages if possible.
cheers and thanks for the action so far!
from action.
Was wondering if this request includes caching of yarn packages.
That's something I was doing with the setup-node action but it seems to be missing here.
Not a huge problem but would be nice to see yarn/npm/pnpm package caching as well.
from action.
you can use the pinned volta version from package.json with setup-node action
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version-file: 'package.json'
cache: 'yarn'
Or you can role your own with volta action and the cache action
from action.
When using this action without manually specifying node-version or yarn-version. We should be able to cache based on the volta key in package.json, and avoid having to download node/volta/etc if nothing has changed.
Would be great to have this feature implemented
from action.
@just-Bri - Yes, I was thinking that would be included when we do this work...
from action.
@just-Bri - Yes, I was thinking that would be included when we do this work...
I figured as much but wanted to call it out directly to make sure. The issue doesn't specify caching of installed node packages, I was afraid it was referring to just Volta/node/npm/yarn/pnpm and not the packages installed installed via an npm i
from action.
Anyone mind mentoring me on implementing this feature? I use setup-node
everywhere, but I wish it would consume my volta config.. would be nice to enable similar caching setup in this action && get my node and npm versions synced perfectly 😁
from action.
Would really be nice if the action would just cache and restore the downloaded tools, since I ran into a situation multiple times now, where the Node Download timed out. It would not need to be downloaded again if it would be cached since the version does not change most of the time anyway.
from action.
Would really be nice if the action would just cache and restore the downloaded tools, since I ran into a situation multiple times now, where the Node Download timed out. It would not need to be downloaded again if it would be cached since the version does not change most of the time anyway.
you might just want a GH / NPM token to prevent timeouts @cgrabmann
- name: Setup node
uses: actions/setup-node@v3
with:
cache: 'yarn'
token: '${{ secrets.YOUR_GH_TOKEN }}'
node-version-file: 'package.json'
from action.
Related Issues (20)
- Using volta-cli/action on GitHub Enterprise Server causes frequent rate-limits with no fallback HOT 1
- Prepare for 1.1.0 Support
- Action fails to download `[email protected]` HOT 8
- Support pnpm cache
- Intermittent errors unpacking Node v18.18.2 HOT 1
- Installing executables with Volta HOT 2
- Failure in Github workflows on ec2-runners HOT 3
- Migrate to Node 20 HOT 1
- Node 20 HOT 1
- Support `actions/setup-node`'s `registry-url` input HOT 2
- Pre-Packaged Actions Unable to Locate Executables HOT 6
- Support `npm-version` HOT 1
- Enhance documentation/ explain how it works HOT 13
- Frequent failures HOT 13
- Object prototype may only be an Object or null: undefined HOT 4
- Please release HOT 3
- Unexpected input(s) 'registry-url' HOT 1
- package.json in a subdirectory HOT 1
- Should be released with major `v2` tag HOT 2
- Unexpected input(s) 'scope' HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action.