I'm using this action in my CI, but getting errors regarding my profile/bashrc. <d

Failure in Github workflows on ec2-runners about action HOT 3 OPEN

AndesKrrrrrrrrrrr commented on July 1, 2024

Failure in Github workflows on ec2-runners

from action.

Comments (3)

rwjblue commented on July 1, 2024

I'm not familiar with ec2-runners here, is that something you've setup in your organization?

from action.

rwjblue commented on July 1, 2024

This might ultimately be something we need to tweak in Volta itself. As long as someone makes sure that $PATH is updated we don't really care if we could edit your profile (bash/fish/zsh/etc).

We might be able to add a flag to volta setup for that, but we'd need to consider the pros/cons specifically.

from action.

rwjblue commented on July 1, 2024

Hmm. We might be able to avoid this error in the action itself if we setup VOLTA_HOME on $PATH first:

https://github.com/volta-cli/volta/blob/75581e5e8c36b58fa88557cfd4d01440fa1fd9ad/src/command/setup.rs#L46-L57

Basically, this would mean either changing setupVolta to always pass PATH as well as VOLTA_HOME:

action/src/installer.ts

Lines 297 to 310 in d253558

 async function setupVolta(version: string, voltaHome: string): Promise<void> { 

 if (voltaVersionHasSetup(version)) { 

 const executable = path.join(voltaHome, 'bin', 'volta'); 

 core.info(`executing \`${executable} setup\``); 

 await exec(executable, ['setup'], { 

 env: { 

 // VOLTA_HOME needs to be set before calling volta setup 

 VOLTA_HOME: voltaHome, 

 }, 

 }); 

 } else { 

 await buildLayout(voltaHome); 

 } 

 }

Or calling .addPath before calling voltaSetup (though it would take a bit of reworking to actually handle correctly):

action/src/installer.ts

Lines 386 to 409 in d253558

 if (voltaHome === '') { 

 // download, extract, cache 

 const toolRoot = await acquireVolta(version, options); 

 // Install into the local tool cache - node extracts with a root folder 

 // that matches the fileName downloaded 

 voltaHome = await tc.cacheDir(toolRoot, 'volta', version); 

 await setupVolta(version, voltaHome); 

 core.info(`caching volta@${version} into ${voltaHome}`); 

 } else { 

 core.info(`using cached volta@${version}`); 

 } 

 // prepend the tools path. instructs the agent to prepend for future tasks 

 if (voltaHome !== undefined) { 

 const binPath = path.join(voltaHome, 'bin'); 

 core.info(`adding ${binPath} to $PATH`); 

 core.addPath(binPath); 

 core.exportVariable('VOLTA_HOME', voltaHome); 

 }

🤔

from action.

Recommend Projects

Failure in Github workflows on ec2-runners about action HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	async function setupVolta(version: string, voltaHome: string): Promise<void> {
	if (voltaVersionHasSetup(version)) {
	const executable = path.join(voltaHome, 'bin', 'volta');
	core.info(`executing \`${executable} setup\``);
	await exec(executable, ['setup'], {
	env: {
	// VOLTA_HOME needs to be set before calling volta setup
	VOLTA_HOME: voltaHome,
	},
	});
	} else {
	await buildLayout(voltaHome);
	}
	}

	if (voltaHome === '') {
	// download, extract, cache
	const toolRoot = await acquireVolta(version, options);

	// Install into the local tool cache - node extracts with a root folder
	// that matches the fileName downloaded
	voltaHome = await tc.cacheDir(toolRoot, 'volta', version);

	await setupVolta(version, voltaHome);

	core.info(`caching volta@${version} into ${voltaHome}`);
	} else {
	core.info(`using cached volta@${version}`);
	}

	// prepend the tools path. instructs the agent to prepend for future tasks
	if (voltaHome !== undefined) {
	const binPath = path.join(voltaHome, 'bin');

	core.info(`adding ${binPath} to $PATH`);

	core.addPath(binPath);
	core.exportVariable('VOLTA_HOME', voltaHome);
	}