Git Product home page Git Product logo

Comments (6)

alexlafroscia avatar alexlafroscia commented on July 19, 2024

It seems like the issue is with a GitHub action that tries to run node or yarn that is itself not configured with Volta is not able to "look up" the correct node/yarn version.

For example, I am trying to use percy/storybook-action to invoke yarn, and the command is not found

Screen Shot 2020-11-19 at 3 25 37 PM

https://github.com/movableink/tailwind-config/pull/306/checks?check_run_id=1426621052

My guess is that the action finds the yarn shim (installed by Volta) and tries to look up the right version to use, finds the Percy action's own package.json without a Volta configuration, and then fails.

If that is a correct guess, the volta shim installed by the volta-cli/action would somehow need to know to fallback to the repository's package.json configuration (or use that exclusively, instead of the file provided by the action itself).

from action.

rwjblue avatar rwjblue commented on July 19, 2024

Hmm. npx definitely is something that works fine with volta (one of the earlier questions you had), but like you mentioned I don't think that is actually the real issue here.

One work around here is to use our configuration options to install a default node/yarn (but unfortunately that also pins your project due to the changes in #24). We could add a config option to allow specifying default node/yarn versions (which I think would be used in your case) and avoid pinning in the project. 🤔

from action.

alexlafroscia avatar alexlafroscia commented on July 19, 2024

Yeah, sorry for the false lead there at first -- I don't think npx here is actually the issue.

I think for this, I can just replace with the Node action or pin a specific node/yarn version for this Percy action to use.

I'm going to close this for now, since I think the problem is kind of out-of-scope. I wonder what kind of fix we would need here. Maybe a way for the action to hard-code a directory to resolve the Node version from? It sounds complex/tricky/out-of-scope so no need to worry about it!

from action.

alexlafroscia avatar alexlafroscia commented on July 19, 2024

I couldn't get the Volta action to work even with pinning the node-version so I ended up using setup-node instead ☚ī¸

movableink/tailwind-config#306

from action.

aidansteele avatar aidansteele commented on July 19, 2024

It's probably worth keeping this issue open, right? Because I stumbled across it and have the same issue. I'd like to keep using this volta action if possible, because otherwise I know that the version specified in setup-node will fall out of sync!

from action.

alexlafroscia avatar alexlafroscia commented on July 19, 2024

I might agree @aidansteele -- I think the real question is whether this action should infer the version numbers for situations like this, or if it's just out-of-scope.

from action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.