Comments (5)
Consider checking with Sidekiq - https://github.com/search?q=repo%3Asidekiq%2Fsidekiq%20redis_version&type=code
The maintainer of the framework may even agree to change the code to adapt to both standards but it will still be a problem for older versions of the library.
from valkey.
from valkey.
As far as I know, redis_mode
is used in many places:
-
StackExchange.Redis: Determine the startup mode through
redis_mode
as standalone, cluster or sentinel. https://github.com/StackExchange/StackExchange.Redis/blob/main/src/StackExchange.Redis/ResultProcessor.cs#L872 -
Prometheus Exporter, use
redis_mode
to display instance_info. https://github.com/oliver006/redis_exporter/blob/master/exporter/info.go#L168
I think we should start a separate thread to let sdk/tool developers report their commands or fields that depend on Redis. (If possible, the best approach is to not change these old fields)
from valkey.
@romange Thx. We'll keep the redis_version
field and it will indicate the last Redis version we're compatible with.
In addition to that, we'll add server_name:valkey
and server_version:x.y.z
for the Valkey version. I don't think any clients break because of adding more fields, but it's theoretically possible so we might even wait until our next major release before adding them.
from valkey.
I'm been thinking a bit about these new "server_version" and "server_name" fields in INFO. Ideally, services and forks based on valkey should be able to show their own names, e.g. "server_name:elastcache" or "server_name:foo" and then it may be useful to say which valkey version and which redis version it's compatible with.
One possibility is to follow redis style and just add "NAME_version" fields for each projects it's compatible with, like this:
server_name:quux
redis_version:7.2.4
valkey_version:8.2.0
quux_version:2025.B.29-rc23
It's not a clear idea, just a problem that we may want to solve before releasing these new fields.
Another possibility could be to use something like User-Agent string browser have, which the clients can parse if we introduce it and explain it from start, while keeping the legacy "redis_version" field, e.g.
redis_version:7.2.4
server:quux-2025.B.29-rc23/valkey-8.2.0/redis-7.2.4
A 3rd variant, something between the two above:
server_name:quux/valkey/redis
redis_version:7.2.4
valkey_version:8.2.0
quux_version:2025.B.29-rc23
from valkey.
Related Issues (20)
- [NEW] Dual stack (IPv4 & IPv6) HOT 12
- [NEW]module filter support CommandFilterKeyAtPos HOT 2
- Implement MODULE RELOAD command HOT 3
- [NEW] Consider support for mimalloc allocator HOT 3
- [NEW] Extended Help for Commands.
- [BUG] rebranding change needed in clocksource syscheck HOT 2
- Rename and change variable names in `utils/redis_init_script`
- [NEW] Implement stream PUBSUB
- Jemalloc defrag situation HOT 8
- A strategy for performance testing HOT 9
- Inconsistent command behavior for keyless read commands
- ACL behavior on keyless commands HOT 2
- [BUG] Install fails with BUILD_TLS=yes, USE_REDIS_SYMLINKS=no HOT 8
- [NEW] Cluster V2 Discussion HOT 9
- [NEW] Support for wasm besides LUA as a scripting engine
- naming conventions and links should be changed from redis to valkey HOT 2
- [BUG] Wrong version number HOT 9
- Key/Value Embedding in Main Dictionary HOT 5
- [NEW] Add subcommands for io-threads in DEBUG command.
- [NEW] Add tests for io-threads.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valkey.