Comments (3)
I have nothing against this, especially if it's done in a way that users can opt-in to. We do have some special code to allow for active defragmentation of Jemalloc arenas, so we might also want to figure out how to implement that in mimalloc. Ideally the next step would be for someone to put together a PoC and validate the performance is actually better.
from valkey.
Agreed. Contributions are welcome.
from valkey.
We do have some special code to allow for active defragmentation of Jemalloc arenas, so we might also want to figure out how to implement that in mimalloc.
defrag is enabled explicitly only when jemalloc is used so this should be fine. in other words, you get defrag with jemalloc only.
I am aligned with adding mimalloc as long as we don't vendor it. On a related note, I think we should move forward and remove the one-off je_get_defrag_hint
patch and instead use more generic heuristics for defrag so that other allocators could benefit from the defrag feature as well. jemalloc should be devendored too.
from valkey.
Related Issues (20)
- [NEW] Dual stack (IPv4 & IPv6) HOT 13
- [NEW]module filter support CommandFilterKeyAtPos HOT 2
- Implement MODULE RELOAD command HOT 3
- [NEW] Extended Help for Commands.
- [BUG] rebranding change needed in clocksource syscheck HOT 2
- Rename and change variable names in `utils/redis_init_script`
- [NEW] Implement stream PUBSUB
- Jemalloc defrag situation HOT 11
- A strategy for performance testing HOT 9
- Inconsistent command behavior for keyless read commands
- ACL behavior on keyless commands HOT 2
- [BUG] Install fails with BUILD_TLS=yes, USE_REDIS_SYMLINKS=no HOT 8
- [NEW] Cluster V2 Discussion HOT 10
- [NEW] Support for wasm besides LUA as a scripting engine
- naming conventions and links should be changed from redis to valkey HOT 2
- [BUG] Wrong version number HOT 9
- Key/Value Embedding in Main Dictionary HOT 12
- [NEW] Add subcommands for io-threads in DEBUG command.
- [NEW] Add tests for io-threads.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valkey.