Comments (8)
Do you get the same error without USE_REDIS_SYMLINKS=no
No that also solves the problem which does seem weird.
Interestingly when you include USE_REDIS_SYMLINKS=no
the second build does far more work. Basically a complete rebuild without respect to the previously built deps. Perhaps this is actually related to the .make-settings
cache.
from valkey.
Interestingly when you include
USE_REDIS_SYMLINKS=no
the second build does far more work. Basically a complete rebuild without respect to the previously built deps. Perhaps this is actually related to the.make-settings
cache.
Yeah, that's it! That USE_REDIS_SYMLINKS variable sets some macro in CFLAGS! We can remove that. We don't need to set that macro in CFLAGS.
from valkey.
@furai Workaround: Use USE_REDIS_SYMLINKS=no in make
and in make install
.
from valkey.
Workaround worked for me, thanks!
from valkey.
The problem is that the BUILD_TLS
env var being pulled from .make-settings
doesn't propagate to the dep build.
It's fixable by appending this after -include .make-settings
in src/Makefile
:
export BULD_TLS
I'm not sure if that's the right/clean way to fix it though.
from valkey.
@michael-grunder What does this has to do with USE_REDIS_SYMLINKS=no?
from valkey.
@zuiderkwast Nothing, I don't think anyway.
The build was failing because the second invocation of make rebuilt hiredis but without forwarding BUILD_TLS=yes
to the dep makefile so Valkiey builds expecting libhiredis_ssl.a but hiredis doesn't build it.
Making the above change fixes the linker error. Isn't USE_REDIS_SYMLINKS
just so we symlink redis-server
instead of valkey-server
, etc?
from valkey.
Isn't USE_REDIS_SYMLINKS just so we symlink redis-server instead of valkey-server, etc?
Yes, but it seemed to be part of the problem.
@furai Do you get the same error without USE_REDIS_SYMLINKS=no
?
from valkey.
Related Issues (20)
- [NEW] Dual stack (IPv4 & IPv6) HOT 13
- [NEW]module filter support CommandFilterKeyAtPos HOT 2
- Implement MODULE RELOAD command HOT 3
- [NEW] Consider support for mimalloc allocator HOT 3
- [NEW] Extended Help for Commands.
- [BUG] rebranding change needed in clocksource syscheck HOT 2
- Rename and change variable names in `utils/redis_init_script`
- [NEW] Implement stream PUBSUB
- Jemalloc defrag situation HOT 8
- A strategy for performance testing HOT 9
- Inconsistent command behavior for keyless read commands
- ACL behavior on keyless commands HOT 2
- [NEW] Cluster V2 Discussion HOT 10
- [NEW] Support for wasm besides LUA as a scripting engine
- naming conventions and links should be changed from redis to valkey HOT 2
- [BUG] Wrong version number HOT 9
- Key/Value Embedding in Main Dictionary HOT 12
- [NEW] Add subcommands for io-threads in DEBUG command.
- [NEW] Add tests for io-threads.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valkey.