Git Product home page Git Product logo

Comments (6)

arusso avatar arusso commented on July 20, 2024

Wow, I'm blown away. This is fabulous.

So you get credit in the commit history, copy the documentation text and paste it into your forked copy of the README, found here. Then submit a pull request and I'll merge this right in.

Here's the docs on how to do all of that as well.

Of course, I can always do this myself, but again, you should get the credit for the contribution :)

from puppet-stunnel.

ross-williams avatar ross-williams commented on July 20, 2024

Aaron,

On 28 Mar 2014, at 7:28 PM, Aaron Russo wrote:

Wow, I'm blown away. This is fabulous.

So you get credit in the commit history, copy the documentation text and paste it into your forked copy of the README, found here. Then submit a pull request and I'll merge this right in.

Here's the docs on how to do all of that as well.

Of course, I can always do this myself, but again, you should get the credit for the contribution :)

I found this very difficult. The problem was that after editing the README.markdown text, the
green "Commit changes" at the bottom right corner of the page was dimmed grey (and was unclickable)
and nothing that I tried would fix this.

After about half an hour of frustration, in desperation I tried switching from Chrome to Safari
and suddenly the button was ungreyed and it was all easy.

So I've submitted a pull request. This is my first ever pull request, so I hope it worked.

Ross

from puppet-stunnel.

arusso avatar arusso commented on July 20, 2024

Pull request worked and I've merged your updates in.

Thanks again!

from puppet-stunnel.

ross-williams avatar ross-williams commented on July 20, 2024

Aaron,

Thanks.

I notice that it's up at:

https://github.com/arusso/puppet-stunnel

but hasn't made it back to:

 https://forge.puppetlabs.com/arusso/stunnel

How can that be updated?

I presume that potential users of your module will
be mainly browsing the Forge, not the Git. :-)

Ross

On 31 Mar 2014, at 11:18 AM, Aaron Russo wrote:

Pull request worked and I've merged your updates in.

Thanks again!


Reply to this email directly or view it on GitHub.

from puppet-stunnel.

arusso avatar arusso commented on July 20, 2024

I need to cut a new version of the module. I usually don't do minor
releases for docs, but given that it's a substantial change, I'll cut a new
one today.

Aaron

On Monday, March 31, 2014, ross-williams [email protected] wrote:

Aaron,

Thanks.

I notice that it's up at:

https://github.com/arusso/puppet-stunnel

but hasn't made it back to:

https://forge.puppetlabs.com/arusso/stunnel

How can that be updated?

I presume that potential users of your module will
be mainly browsing the Forge, not the Git. :-)

Ross

On 31 Mar 2014, at 11:18 AM, Aaron Russo wrote:

Pull request worked and I've merged your updates in.

Thanks again!

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-39077886
.

from puppet-stunnel.

arusso avatar arusso commented on July 20, 2024

version 1.1.1 cut and uploaded to forge.

from puppet-stunnel.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.