trustly / trustly-client-php Goto Github PK

The readme reads:
This code is written for PHP 5.5

but the requirement in the composer.json is php 5.2
Which one should I trust?

With the resent fixes merged in to the repo it would be nice if the Packagist setup was also fixed so that the current development version becomes accessible to anyone that depends on it.

https://packagist.org/packages/trustly/trustly-client-php

Would be nice with PHPDoc on all methods for integration with IDEs.

It seems that there is currently no support for adding RecipientInformation in a deposit call, which is an additional compliance requirement for P2P payments. Please feel free to correct me if I am wrong :-)

So one would need something like the following in the deposit attributes:

"RecipientInformation": {
    "Address": "Main street 1, SE-11253, Stockholm, Sweden.",
    "CountryCode": "SE",
    "CustomerID": "12345",
    "DateOfBirth": "1990-01-01",
    "Firstname": "Adam",
    "Lastname": "Johnsson",
    "Partytype": "PERSON"
}

https://github.com/trustly/trustly-client-php/blob/master/Trustly/Api/signed.php#L854

The address parameter is twice there, on line 856 and 860.

Do you plan on including tests so this trivial mistake doesn't happen?

It would be good if you setup packagist hook, so it updates at packagist whenever something is committed to repository

Would be great with the ability to search the account ledger for a payment and get the current status of a specific payment and to verify that it exist.

What stability do you consider for the library? beta? alpha? stable?

There is a little typos in the Trustly_Api_Signed class

public function getWithdrawals($orderid) {

	$data = array(
		'OrderID' => $orderid,
	);

	$request = new Trustly_Data_JSONRPCRequest('getWithdrawals', $data);
        // should be
	$request = new Trustly_Data_JSONRPCRequest('GetWithdrawals', $data);
	return $this->call($request);
}