trustly / trustly-client-php Goto Github PK
View Code? Open in Web Editor NEWTrustly API PHP Client implementation
License: MIT License
Trustly API PHP Client implementation
License: MIT License
There is a little typos in the Trustly_Api_Signed class
public function getWithdrawals($orderid) {
$data = array(
'OrderID' => $orderid,
);
$request = new Trustly_Data_JSONRPCRequest('getWithdrawals', $data);
// should be
$request = new Trustly_Data_JSONRPCRequest('GetWithdrawals', $data);
return $this->call($request);
}
Would be nice with PHPDoc on all methods for integration with IDEs.
What stability do you consider for the library? beta? alpha? stable?
It seems that there is currently no support for adding RecipientInformation
in a deposit
call, which is an additional compliance requirement for P2P payments. Please feel free to correct me if I am wrong :-)
So one would need something like the following in the deposit attributes:
"RecipientInformation": {
"Address": "Main street 1, SE-11253, Stockholm, Sweden.",
"CountryCode": "SE",
"CustomerID": "12345",
"DateOfBirth": "1990-01-01",
"Firstname": "Adam",
"Lastname": "Johnsson",
"Partytype": "PERSON"
}
https://github.com/trustly/trustly-client-php/blob/master/Trustly/Api/signed.php#L854
The address parameter is twice there, on line 856 and 860.
Do you plan on including tests so this trivial mistake doesn't happen?
Would be great with the ability to search the account ledger for a payment and get the current status of a specific payment and to verify that it exist.
It would be good if you setup packagist hook, so it updates at packagist whenever something is committed to repository
The readme reads:
This code is written for PHP 5.5
but the requirement in the composer.json is php 5.2
Which one should I trust?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.