indentation and newlines in function calls about plsql-formatter-settings HOT 3 CLOSED

I see the point. However, defining the rules for this behaviour is not that simple since you do not want to split all functions this way. e.g.

select some_quite_long_function_name(
          a,
          b,
          c
       )
  from ...

In this case you would like to keep it this way:

select some_quite_long_function_name(a, b, c)
  from ...

I think this enhancement request is also related to the total line size like other issues #33 and #84.

Regarding the formatting of hints. This is doable based on a lexer logic only. The parse-tree given to the Arbori program does not contain comments nor hints. This means we have to find hints as I've described that in this blog post and then add a line break before the next token.

I agree this needs to be improved, but only in combination with a max-line-size-exceeded-logic.

from plsql-formatter-settings.

@jgebal: After closing #33 the result looks now like this:

declare
   l_value varchar2(4000);
begin
   select /*+ parallel(pd, 4) */ some_quite_long_function_name(
             another_long_function_name(
                first_Column_id
                || another_Column_id
                || third_Column_id
                || fourth_column_id
                || fifth_column
                || another_column
             )
          )
     into l_checksum
     from my_table_data pd;
end;
/

So, adding a line break after a hint would solve the issue, right?

from plsql-formatter-settings.

When you format this code

select /*+ parallel(t, 2) */
a from t;

the result is

select /*+ parallel(t, 2) */
       a
  from t;

But when you format this code:

select /*+ parallel(t, 2) */  a from t;

The result is

select /*+ parallel(t, 2) */  a
  from t;

The serializer component of the SQL Developer formatter preserves the whitespaces after the comment/hint up to a new line. But new lines are lost.

That's the best I can do.

from plsql-formatter-settings.