Git Product home page Git Product logo

Comments (5)

PhilippSalvisberg avatar PhilippSalvisberg commented on August 26, 2024 1

Post in SQL Developer forum: https://forums.oracle.com/ords/apexds/post/sqldev-23-1-sqlcl-23-3-bug-formatter-breaks-code-when-strin-2775

from plsql-formatter-settings.

PhilippSalvisberg avatar PhilippSalvisberg commented on August 26, 2024

I can reproduce it with

begin
   dbms_output.put_line('</');
end;
/

Formatter result is

begin
   dbms_output.put_line('<
/');
end;
/

This is a bug. Thank you for reporting it.

from plsql-formatter-settings.

PhilippSalvisberg avatar PhilippSalvisberg commented on August 26, 2024

The problem is not related to the Arbori program in this repo. In fact, the problem can be reproduced with the standard SQL Developer Arbori program.

The culprit code section at the end of the format method of the oracle.dbtools.app.Format class looks like this (decompiled with IntelliJ based on the JAR distributed with SQLcl 23.1):

                int index = -1;

                while(true) {
                    index = ret.indexOf(";/", index + 1);
                    if (index < 0) {
                        this.inputPos = -1;
                        return ret;
                    }

                    if (ret.indexOf("*", index + 1) != index + 2) {
                        String var10000 = ret.substring(0, index);
                        ret = var10000 + ";\n/" + ret.substring(index + 2);
                    }
                }
            }

The problem is also reproducible with the latest SQLcl 23.3:

image

from plsql-formatter-settings.

PhilippSalvisberg avatar PhilippSalvisberg commented on August 26, 2024

Issue is not fixed in SQLcl 23.4.0

from plsql-formatter-settings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.