Git Product home page Git Product logo

Comments (8)

kzahel avatar kzahel commented on June 20, 2024

Hi efess. I forked your fork, and used/re-enabeled audio context API because audioelement.clone() was causing crashes on chromebooks. https://bitbucket.org/kzahel/webquake

Great work with your fork, love your work with promises. I was able to extend it as necessary. I wasn't a fan of promises until now

Also added gamepad support
And fullscreen setting in options

Basically I am trying to get it working well in a chrome app: https://github.com/kzahel/WebQuake-Chrome

from webquake.

efess avatar efess commented on June 20, 2024

Cool, although I wonder how much the excessive use of promises affects the performance.. I was going to try testing with bluebird promises, but never got around to it. Some of my promise implementations were pretty hacky as well.

from webquake.

kzahel avatar kzahel commented on June 20, 2024

99% of those promises are initialization code, and arent used at all in the game loop. so not at all, really.

No idea what bluebird promises are :-) is that an ES6 thing?

from webquake.

kzahel avatar kzahel commented on June 20, 2024

I'm just right now trying to Promisify the Server initialization code. Using your work as a reference :-)

from webquake.

efess avatar efess commented on June 20, 2024

Oh yea the game loop definitely uses promises, the program code creates a promise even when one isn't necessary.

I was working in my local copy to optimize and cut down the creation of promises when not needed, but there's some loose ends I haven't been able to figure out (or had time)

Bluebird (http://bluebirdjs.com/) is a faster promise implementation, but it comes at the price of needing to import a library.

from webquake.

kzahel avatar kzahel commented on June 20, 2024

Cool. Well please let me know if you make any nice changes!

from webquake.

kzahel avatar kzahel commented on June 20, 2024

I had another approach that I tried which was to use "await"
I ended up having still some problems with the loading and would get funny exceptions when a new map loaded. But it mostly worked, and didn't require a lot of rewrite
kzahel@8bb479f

from webquake.

SpiritQuaddicted avatar SpiritQuaddicted commented on June 20, 2024

Awesome stuff!

This issue can be closed, #33 is there and a PR is in order I think.

from webquake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.