Hi! I recently switched from Emacs to VSCode and absolutely love this extension 💛 Thank you so much for developing this!

I found that I am missing one feature that I used to use a lot: resume search (often also called "repeat search"). That means: I search for a term with find_within_files, open one candidate in the editor to edit something (thus closing the search terminal), and then resume the search to visit other candidates. This exists as ivy-resume, vertico-repeat, selectrum-repeat in the Emacs world. At least one of my colleagues is also missing this functionality.

I looked around the extension a bit and it seems that this is not directly supported. Or am I missing something?

I thought about + searched for potential workarounds/alternatives:

1. I found this: #27 (using tab to select multiple files + open them together). However, this seems to not work for me, so I wasn't able to try this yet. But this wouldn't directly support my preferred workflow.
2. One could potentially keep the search window open while making edits in the editor. This does not work well for me because the keyboard shortctus that I use to move around vscode don't work in the terminal (i.e., I have no way to conveniently switch out of the terminal and back into it). But maybe with some good shortcuts this might be tenable.

How do you feel about a resume/repeat functionality? I.e., a separate key binding for resuming the last search. A nice to have would be to have it jump back to the candidate that was marked when the search was last exited, but even a resume functionality without that would be extremely helpful for me.

I am willing to implement this if you are generally interested. One approach would be to write the current query to a "last query" file when a search is exited, and restore this query when a newly introduced "repeat query" action is invoked. An alternative approach would be to record query history more generally in a history file and allow the user to cycle through the last queries. Other ideas?

Again, I absolutely love this extension, and would love to help make it a tiny bit better for me and maybe a few others :)

Like the title says having kill terminal set to true combined with command + shift + j does not open a file at all

I think it makes sense for fzf to take up the entire terminal window in this case, so I think it should just default --height='100%' or if that doesn't seem like a good default, could you please add a setting for it? Maybe a general setting where the user can override any fzf defaults.

Env:
1. the latest vscode is available /workable on the windows , running with WSL ,
2. window 11
3. vscode v1.76.2
4. rg (13)
5. fzf (0.29)
6. bat (0.19.0)
7. already install wsl extension as well .
Step:
1. already installed the fd ,rg and bat . And those command is available and worked well on the ubuntu under WSL .
8. run "code . " within ubuntu's terminal .
9. trigger the plugin with short-cut "ctrl+shift+j/u".
result :
,prompt the ",Failed to active the plugin , bat not found on your PATH"

(I hope this is the right place to ask questions, this extension is amazing).

I was wondering if there was any way to override my system FZF_DEFAULT_OPTS variable when used in VSCode. I noticed at adding things like this in my .zshrc file:

FZF_DEFAULT_OPTS="--height=50% --layout=reverse

Will take effect in VSCode (the 50% for example will make the take half the VSC terminal and look weird). My use case is using --layout=reverse in VSC and not using it in my terminal.

I took a quick look at the code and see that it seems to just default to the one set in your terminal.

I supposed one could write an if/then in the .zshrc to configure it, but not sure how to tell if the terminal sourcing the .zshrc file is inside VSC.

Thx.

Hi! I love this extension, use it every day. 🥇

Something I've noticed I do a lot is going through search results one by one, editing as I go.
It would be great if there's a way to open the search prompt using the same search query as I ended on the last time I ran the command.

Either that, or add a shortcut when searching that prefills the last searched result (or maybe history?). Maybe this option would be more part of FZF (maybe it already exists, I can't find it).

If you got a better way, please tell me!

Platform: MacOS Ventura 13.2.1 (Apple M1 Pro)
VSCode version: 1.78.1

find-it-faster configuration:

{
  "find-it-faster.general.additionalSearchLocations": ["some-ignored-dir"]
}

With the above configuration when I add an ignored directory in FiF's search locations the "search files" command is able to find the files just fine but hitting Enter when focused on a filename doesn't open that file in the editor if the file is in the ignored directory. The directory I am trying is ignored via .gitignore but I am assuming this is true for any file that's ignored by the VSCode search...?

I would be interested in fixing this bug if someone could point me in the right direction.

Also see #2. I think there are two options:

1. Invoke the bash scripts from Windows. I'm not sure how / whether this can be done. Will require WSL to be installed. Not sure if there are further issues with access permissions etc. Will require some investigation.
2. Create Windows versions of find_files.sh and find_within_files.sh (the scripts in the extension that invoke fzf). This may be the nicest solution as it's a native implementation, but requires Windows shell scripting, which I'm not familiar at all.

If you're a Windows user, please vote on this ticket using 🚀 for the first solution, 🎉 for the second, or 😕 for don't know / don't care as long as you do something. Votes will compel me to take action (and learn windows batch file scripting).

If you're interested in implementing solution 2 and supporting it, please shoot me a message! The extension is built in such a way that implementing this solution requires writing two scripts that invoke the terminal commands, and there are reference implementations in bash shell script.

Telescope (a Neovim finder / picker like this extension and fzf.vim) has a version of the ripgrep finder that can pass arguments from the user input to the underlying ripgrep command. It'd be great if this extension had a version of the findWithinFiles command that worked the same way.

Here's the readme with some examples of how this was implemented and why it's useful. A nice feature is that user inputs with no quotation marks are treated as a single argument; you have to "opt in" to passing arguments by wrapping the query phrase in quotes, otherwise the search works the same way that findWithinFiles does today.

Hi!
I'm on ubuntu 20.04, vscode is at 1.60.1 and finditfaster at 0.0.13.

I have all the dependencies installed, and search file works fine.

The problem is with search within files.
No matter what I type, the number of matches doesn't change. I can see the matches list change a little, but nothing related to my actual search comes up. It almost look like it's doing some random reordering of the list.

Thank you for writing the extension! I was about to write one myself because I really hate the sidebar :D

When I type comma in global search (Ctrl+Shift+U) powershell command fails:

How to reproduce:
1- Ctrl+Shift+U (global search) in vscode.
2- Type ','

I couldn't fix the powershell script. So, for people who are reading this issue, here is a quick band-aid which requires python as a dependency. It opens the file in code directly and ignores all of the extension settings.

New find_within_file.ps1:

 python D:\rep\dotfiles\.local\bin\live-grep-windows.py

live-grep-windows.py:

import subprocess

# Define the rg command as a list of arguments
rg_command = [
    "rg",
    "--color=always",
    "--line-number",
    "--no-heading",
    "--smart-case",
    ".*",
]

CATPPUCCIN_GREEN = "#a6da95"
CATPPUCCIN_MAUVE = "#c6a0f6"

# Define the fzf command as a list of arguments
fzf_command = [
    "fzf",
    "--ansi",
    "--border",
    f'--color "hl+:{CATPPUCCIN_GREEN}:reverse,hl:{CATPPUCCIN_MAUVE}:reverse"',
    '--delimiter ":"',
    '--height "100%"',
    "--multi",
    "--print-query --exit-0",
    '--preview "bat  {1} --highlight-line {2} --color=always --style=numbers "',
    '--preview-window "right,+{2}+3/3,~3"',
    '--scrollbar "▍"',
]

fzf_command = " ".join(fzf_command)
print(fzf_command)
print("")


try:
    # Run the rg command and pipe its output to fzf
    rg_process = subprocess.Popen(
        rg_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True
    )
    fzf_process = subprocess.Popen(
        fzf_command,
        stdin=rg_process.stdout,
        stdout=subprocess.PIPE,
        text=True,
    )

    # Close the standard output of rg process since it's being piped to fzf
    rg_process.stdout.close()

    # Wait for the user to interact with fzf and press Enter
    selected_string, stderr = fzf_process.communicate()

    # Check if there was any error
    if fzf_process.returncode != 0:
        print("An error occurred:", stderr)
    else:
        # Print the selected string
        selected_string = selected_string.strip()
        selected_string = (
            selected_string.split("\n")[1]
            if "\n" in selected_string
            else selected_string
        )
        print("Selected string:", selected_string)
        file_path, line_number, *_ = selected_string.split(":")
        # Split the selected string into file path and line number

        # Construct the code command to open the file in Visual Studio Code
        code_command = f'code -g "./{file_path}:{line_number}"'

        # Execute the code command
        code_process = subprocess.Popen(
            code_command,
            shell=True,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            text=True,
        )
        code_process.communicate()

except FileNotFoundError:
    print(
        "rg, fzf, or code command not found. Please install them and ensure they're in your PATH."
    )
except KeyboardInterrupt:
    print("\nOperation canceled by the user.")

Hi! Thanks for your work!

I have a question though: how do I do fuzzy search in files? Let's say there is var for partner param and in different languages it is written differently: partner-param and partner_param. I'd like to search for both of them.
If I try to use the command line rg . | fzf then it works as expected and I can type partnerparam and I will see both entries.
But this doesn't work in the extension. It looks like it always searches for exact matches. Adding ' at the beginning doesn't help.

Do I miss something?

After opening the search fucntion and selecting a result, when you open the terminal panel again in vscode it opens the finditfaster terminal. This is annoying because I want to go back to using an active terminal and need to open a new panel for this.

Is there anyway around this?

This plugin indeed is awesome. I am new to these terminal stuff, so I am still struggling here.

The problem I have is that I have some graphql schema files in my project, but this type is not available for searching with pre-filtering.

I want to add this type so that I can use the feature. How can I do that or maybe it is impossible right now?

Frist off, thanks for this extension! I found it while trying to convert my Vim setup to vscode.

Is there a way to modify the search within files rg command? I would like to modify the output to remove the portion of the path that leads up to the project folder.

This is in vscode

In vim, I have modified the results of rg to omit the path preceding the project directory

Hi! Started using this tool and it makes changing files and searching in vscode x10 better.

I was wondering if it is possible to expose a setting called "BAT_THEME" or something similar, either that or maybe it is possible to piggy back of the $BAT_THEME shell variable that bat uses itself

OS: macOS 13.2.1 22D68 arm64

When I press the keyboard,
following appears
//
bash
export PS1="::: Terminal allocated for FindItFaster. Do not use. ::: "; clear
/Users/keeyu/.vscode/extensions/tomrijndorp.find-it-faster-0.0.21/find_within_files.sh '/Users/keeyu/code/company/probation'
//
But I directly execute the following command. It works very well
//
/Users/keeyu/.vscode/extensions/tomrijndorp.find-it-faster-0.0.21/find_within_files.sh '/Users/keeyu/code/company/probation'
//

See #2. While Windows (outside of WSL) is not working, the user should receive a better error message, perhaps indicating that WSL based workflows do work. Should also update README to indicate WSL remote works, native doesn't.

Hi,

First I'd like to say that this is a great plugin!
Could you please add the switch --cycle on line 58 of find_files.sh ?

Thanks

I wondering if this was considered and not implemented for any reason? It would be a nice addition and make this have the same features as the FZF plugin available for Neovim, which has a buffer search mode.

(Again, this is a game changer for me and making me come back to VsCode from Nvim.)

Thanks for making this! Works nice locally, but I got into trouble making this work in a devcontainer because of bat

Using something like:

 "postCreateCommand": "sudo apt-get update && sudo apt-get install -y bat fzf ripgrep",

in the devcontainer.json will not work, although it does make bat usable as a cli tool.

Making the symbolic link also does not help here:

  "postCreateCommand": "sudo apt-get update && sudo apt-get install -y bat fzf ripgrep && mkdir -p ~/.local/bin && ln -s /usr/bin/batcat ~/.local/bin/bat"

This wsl fix also did not do it for me.

The error is always: Failed to active the plugin , bat not found on your PATH.

Any ideas?

I can't open any file in Windows, pressing Enter does nothing. Its maybe my problem?

I built this extension a couple years ago. We're now in a situation where this extension:

• has been stable for quite a while
• is running on multiple platforms
• has thousands of users
• is seeing increasingly many community contributions
• has been increasing in complexity to the point where it's infeasible to manually check all edges cases

As such, we'd greatly benefit from having automated testing in CI. I have a Circle CI instance set up that ensures that at least the extension can be installed and loaded, but that's it.

I'm no hero on VS Code extension testing, and my expectation is that due to its reliance on the terminal, there may not be enough features to effectively do this. That said, if anybody has experience / ideas and would like to give this a stab, I'd greatly appreciate it.

The selection is correctly populated, but the search doesn't correctly update. Clearing the prompt and subsequently typing the selection again does work...

Some times one may want to find some file not in this project, for example notes, it will be usefull when can support user can call command "find-it-faster.findFiles" with args and find other files.

When searching on a workspace with multiple root directories the search is run on each configured directory independently (that is my guess). Later when the results come there is no deduplication. Duplicates might happen with the following workspace config:

{
  "folders": [
    {
      "name": "ROOT",
      "path": "."
    },
    {
      "path": "./src"
    }
  ]
}

It would be nice to filter the duplicated based on absolute file path.

Sometimes I trigger the search command in terminal and want to search it later, then I hide the terminal, and second time I trigger the command it will make me jump to the first selected item from the hidden terminal, maybe type command twice without enter can just open panel(if it is invisible) and does nothing?

Great work on this extension! It let me throw my personal messy extension away. There is one small thing I would love to see: find file with type pre-filtering.

Hi,

I happen to be working in a directory starting with @dir, which seems to be causing an issue when trying to use FindItFaster:

::: Terminal allocated for FindItFaster. Do not use. ::: /home/marc/.vscode/extensions/tomrijndorp.find-it-faster-0.0.26/find_within_files.sh '/home/marc/Documents/%40WebDev/test' /home/marc/.vscode/extensions/tomrijndorp.find-it-faster-0.0.26/find_within_files.sh: line 12: cd: /home/marc/Documents/%40WebDev/test: No such file or directory

It works without issues in dirs not containing @

First of all big thanks for this wonderful plugin and I like fzf. I want to add custom keybindings to scroll up and down, page half up and bottom vice-versa. I set it up for my fzf terminal but i have no idea how to add those lines to this plugin in vscode. i could't see any related options in vscode keyboard shortcuts. The default shift + up/down arrow is not so comfortable for me because I need to give extra key strokes in my keyboard.
Can you help me of this.
** file up/down with ctrl+ j/k are working fine **

info

• os : Arch Linux

Great extension, thanks for making it!

I want to search in files at hidden and excluded folders. Is it possible to do this with the extension?

I'm not sure if related but if I set

"find-it-faster.general.useWorkspaceSearchExcludes": false,

I get a Command failed error, unfortunately I cannot see the full error to check the options.

Hi!
Super works, I would like to know if it is possible to be capable of searching the files present in the current Visual Studio windows (even if the files are not in the current directory explorer)
for example here:

However, while running the search within file this is looking for too many files that is really slow.
My option for now:

Hi,
I use Powershell 7.4 (pwsh) on Win11.
The fzf program flashed for a moment and soon disappeared.
Then it shows:

Text version:

PS C:\Users\vales\Workspace\dotfiles-and-scripts> c:\Users\vales\.vscode\extensions\tomrijndorp.find-it-faster-0.0.30\find_within_files.ps1  'c:\Users\vales\Workspace\dotfiles-and-scripts'
rg --column --hidden  --line-number --no-heading --color=always --smart-case --colors "match:fg:green" --colors "path:fg:white" --colors "path:style:nobold" --glob "!**/.git/"  --glob  "!**/node_modules"  --glob  "!**/bower_components"  --glob  "!**/*.code-search"  --glob  "!**/dist"  --glob  "!**/dist*"  --glob  "!**/.vscode"  --glob  "!**/.build"  --glob  "!**/.dll"  --glob  "!**/.cache-loader" "^"
unknown option:
canceled
PS C:\Users\vales\Workspace\dotfiles-and-scripts> c:\Users\vales\.vscode\extensions\tomrijndorp.find-it-faster-0.0.30\find_files.ps1  'c:\Users\vales\Workspace\dotfiles-and-scripts'       
unknown option: 
canceled

Relative content of my settings.json:

    "security.workspace.trust.untrustedFiles": "open",
    "terminal.external.windowsExec": "C:\\Program Files\\PowerShell\\7\\pwsh.exe",
    "terminal.explorerKind": "both",
    "find-it-faster.general.hideTerminalAfterFail": false,
    "find-it-faster.general.hideTerminalAfterSuccess": false,
    "find-it-faster.general.clearTerminalAfterUse": false,
    "find-it-faster.findFiles.showPreview": false,
    "find-it-faster.findWithinFiles.showPreview": false

Waiting for your reply.

Hey!

Some of the tools are using open-vsx to automatically install extensions in remote containers.

Can we publish find-it-faster there? Thanks!

Hi, thank you for this amazing plugin!

The current version only supports searching in the current working directory, but sometimes I want to search the files outside the project folder. Is it possible to implement an pop-up window (like the one when you press cmd+o) to confirm which directory I would like to search?

Describe the bug
Unable to open files from terminal window.

EXCEPTION: A parameter cannot be found that matches parameter name 'Path'.
at <ScriptBlock>, ...\.vscode\extensions\tomrijndorp.find-it-faster-0.0.21\find_within_files.ps1: line 115
at <ScriptBlock>, <No file>: line 1
Out-File : A parameter cannot be found that matches parameter name 'Path'.
At ...\.vscode\extensions\tomrijndorp.find-it-faster-0.0.21\find_within_files.ps1:115 char:75
+ ... Path "$SINGLE_DIR_ROOT" -ChildPath "$result" | Out-File -Path "$Env:C ...
+                                                             ~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Out-File], ParameterBindingException
    + FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.OutFileCommand

To Reproduce
Steps to reproduce the behavior:

1. ctrl+shift+j or ctrl+shift+u
2. Navigate the file tree using keyboard
3. Press enter on a file
4. See error

Expected behavior
File opens in VS Code when selected

Screenshots

Desktop:

• OS: MS Windows 10 Enterprise
• Version 10.0.19045
• Terminal: PowerShell
  • PSVersion 5.1.19041.2364
• rg, fzf, and bat all are confirmed to work independently.

As per title, when the extension updated to 0.0.27 the flight check now fails. It says it's unable to find rg on my PATH. Reverting back to 0.0.26 and the problem goes away.

When I have several folders in the workspace (File->Add folder to workspace), the extension still searches correctly in the terminal, but it can't open the selected file when pressing enter. Strangely enough, clicking on the path+line link in the terminal works as intended.

Type: Bug

Enable extension, attempt typescript auto complete in a large project, observe it fail completely or become extremely slow. Disable extension and problem disappears.

Extension version: 0.0.21
VS Code version: Code 1.79.2 (695af097c7bd098fbf017ce3ac85e09bbc5dda06, 2023-06-14T08:58:33.551Z)
OS version: Darwin arm64 22.5.0
Modes:

How to reproduce:
1- Open settings.json in an editor (vscode, neovim, notepad ...).
2- Open vscode (code) and start fuzzy search Ctrl+Shift+j. Don't press enter let it wait.
3- Edit settings.json:

    "editor.cursorStyle": "block", ->     "editor.cursorStyle": "line", 

4- Save settings.json

In vscode suddenly fuzzy search terminates and terminal closes.

Currently /bin/bash is used in all the bash scripts. This would break on systems like NixOS which doesn not have /bin/bash because of its non standard file system. Is it possible to change it to /usr/bin/env bash instead?

Hey Tom, I love this extension, thank you for the time and effort and for sharing this with us. When I open files using cmd+p I prefer for them to open in a preview editor and added this setting "workbench.editor.enablePreviewFromQuickOpen": true,. Is it possible to add this as a setting to your extension? Thank you!

First of all, thank you so much for this extension. I've been using it literally every day since I found it on the marketplace.

Proposal

Add a boolean option "find-it-faster.general.killTerminalAfterUse" It may be implemented the same way as "find-it-faster.general.clearTerminalAfterUse"

Behavior

If this option is set to true, then after each use allocated terminal will be killed. It probably adds some performance penalties, since it creates a new terminal instance per call to the extension, but I didn't find these penalties to be even remotely meaningful, when I've been doing the same manually all the time.

Why

I'm using integrated terminal for compilation/linting/testing/commiting and etc. So, I always have one active instance.
But after call to the extension, it's terminal becomes active, pushing previously active instance into the background. I'm forced to manually kill this new instance or switch back to previously active one. With this option, allocated for extension instance won't push previously active instance into the background.

Provide a way to specify custom rg/fzf/bat executable or additional directories to search them for.
I have all the executables in directories that are part of the PATH variable. For some reason, vscode does not start with running also the .bashrc.

I get this error when I try to use the extension on windows.. I do have fzf, ripgrep, and bat installed and added to the PATH

Failed to run checks before starting extension. Maybe this is helpful: Error: Command failed: C:\WINDOWS\system32\cmd.exe /d /s /c "c:\Users\####\.vscode\extensions\tomrijndorp.find-it-faster-0.0.6\flight_check.sh"

I managed to run the extension locally on Windows (through Powershell), but when I press a shortcut the terminal Windows appears, but immediately disappears. I tried splitting the terminal Window to let it persist, but it hides the window even with the other opened.

Running on Windows with VScode, and some of the workspaces have different default terminal setting rather than Powershell.
Finditfast open default terminal and the ps.1 file is not executed.

Can you force it to use powershell even if default terminal is other?
Thanks

When the option terminal.integrated.defaultProfile.linux: tmux is set, I cannot use the extension, so I need to set it to terminal.integrated.defaultProfile.linux": zsh and I get this msg:

/home/darianmorat/.vscode-server/extensions/tomrijndorp.find-it-faster-0.0.30/find_files.sh: line 4: EXTENSION_PATH: -it-faster-0.0.30/find_files.sh '/home/darianmorat/dev/js'unbound variable