Git Product home page Git Product logo

Comments (3)

philcampeau avatar philcampeau commented on September 21, 2024

https://18xx.games/game/132733?action=196

Confirmed that the price is not on a shelf, and does not drop after 5 shares are sold and corp is dumped on another player.

from 18xx.

benjaminxscott avatar benjaminxscott commented on September 21, 2024

I believe the issue is here:

18xx/lib/engine/game/g_1850/game.rb

Line 339 in 9e1f1ca

change_price(bundle, bundle.corporation.owner) if bundle.corporation.president?(bundle_owner)

Because sell_shares() changes the president, at the time of this check the former president is not the current president

It seems like the current codepath only drops the price if the president sells AND the president doesn't change

I removed that clause but it seems to have broken some price protection logic, so I don't feel comfortable PR'ing that until/unless I grok the price protection code more

from 18xx.

Rupre avatar Rupre commented on September 21, 2024

Are you still trying to resolve this issue?

from 18xx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.