[18VA] Tredegar Iron Works doesn't give discount about 18xx HOT 9 CLOSED

Strange. The code is in place, and when I create a new game in hotseat mode, the discount works on this train. I've also played many games of 18VA and never encountered this issue. But when I create a hotseat game using the game data from this game, I can confirm the issue occurs on my end too.

from 18xx.

from 18xx.

Stepping through it in a debugger I found the following:

1. The ability doesn't work because @selected_company is actually nil at the time of the purchase.
2. @selected_company is nil because render in app/view/game/round/operating.rb sets it to nil after determining it doesn't have any abilities.
3. It doesn't have any abilities because ability_right_time? looks for when = buy_train, but the ability has when = buying_train.

The check in 2) is relatively new, from early September: 7ea0f18
Based on the commit description, it seems entirely possible this is yet another case of clearing @selected_company when it shouldn't be, due to the mismatch in 3). E.g. the render time check might expect buy_train while the buy action processing check might require buying_train, so if we didn't clear the company it would Just Work.

The actual mismatch in 3) is weird. 18NY and variants use buy_train and everything else uses buying_train. I don't see any reason these should be different, but I am not at all familiar with train buying abilities.

from 18xx.

Any idea when this will be addressed?

from 18xx.

Same bug here: https://18xx.games/game/146806

from 18xx.

Same bug here: https://18xx.games/game/146806

I don't see the bug in that game. When VR acquired Tredegar Iron Works, it had ~450 and needed 800 to buy a train from the depot.

from 18xx.

The bug was present throughout the game. Anytime the owner of Tredegar tried buying it into any company, and applying the discount to any train, it did not work. We tried all sorts of combinations of owning company and train buying and it never worked.

from 18xx.

https://github.com/tobymao/18xx/blob/master/assets/app/view/game/round/operating.rb#L40

This is the code that wipes out @selected_company and prevents the ability from working.

The bug only triggers when there are zero purchasable companies. In the buggy game there are zero player owned companies. In the functional game there is one.

So it comes down to 7ea0f18 again. That's attempt #3 to get it right, and it turns out didn't work that time either.

Exactly why the train discount doesn't register as an available ability is still puzzling, but we should revert the change above to unbreak games first.

from 18xx.

I'm uploading a fix soon; changing the timing from buying_train to buy_train fixes Tredgar; looking at the ability_right_time? implementation it looks like buying_train isn't the name of a step or explicitly stated so it doesn't get past this

https://github.com/tobymao/18xx/blob/master/lib/engine/game/base.rb#L3082

from 18xx.