Git Product home page Git Product logo

18xx's People

Contributors

andrewzwicky avatar andypymont avatar benjaminxscott avatar crericha avatar daniel-sousa-me avatar dfannius avatar doubt72 avatar galatolol avatar jason-johnson avatar jenf avatar joeb989 avatar kelsin avatar magnusstjarnhild avatar michaeljb avatar ollybh avatar outsidepasser avatar perwestling avatar philcampeau avatar roseundy avatar ryandriskel avatar scottredracecar avatar thepackrat avatar tobymao avatar tysen avatar underhilllabs avatar vandamm avatar ventusignis avatar volker18xxdev avatar yzemaze avatar zwergenpunk avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

18xx's Issues

Route length validation

Tosa Kuroshio Railway runs a 3 train for $110 (C10, C8, B7, B5, B3, C4)

There seems to be no route length validation.

Station Token keep disappearing

Placed a token on a green tile, the station token seem to disappear on a new operating round

Uwajima Railway places a token on #Engine::Part::City:0x70c28 TODO hex name...
Uwajima Railway lays tile 205 with rotation 1 on C4

ID64 error with token

Corporation Kotohira and Takamatsu was laying track tile on I2 and a token for orange IYO railroad showed up. IYO already has two tokens on board. This should be sanuki I believe (based on home posiiton if I recall correctly).

Two times train running in one OR (game #78)

Hi Toby, another bug. In OR 3.1 Takamatsu & Kotohira Electric Railway had to play two runs with the trains. I solved it by doing my turn in another order. Order without bug:

  • Sell(or should I say buy) one of the two privates ($100)
  • Lay track
  • Run trains
  • Buy 1x 3 train

Order with bug

  • Lay track
  • Run trains
  • Buy 1x 3 train
  • Sell one of the two privates ($100)

We have seen the same bug in game #34 at a turn of Jones (I believe that was also the turn that he was buying trains and selling privates), but don't see here that we filed it. Back then, we didn't have a workaround, so it should still be visible for you.
Thanks

Typo in player field

In the page for starting a game, the player name fields are titled "Players 1" etc. instead of "Player 1".

Solo mode local storage

Right now solo mode has no storage, so a refresh will kill the game.

When playing solo mode, we should

  1. generate an ID to save the game
  2. save the game in local storage by the id, you can use Lib::Storage
  3. Add someway from the homepage to get access to these local games
  4. The API should simply route to the local action
  5. import and export these actions

Tile Rendering

required for a playable 1889:

  • private companies that block building
  • upgrade cost
  • icons (mountain, river)
  • definitions for 1889 preprinted tiles
  • offboard / red tiles
  • render reserved spaces (start with text, eventually corporation's logo)

required for playable 1830, 1846, and 1861:

  • add definitions for 1830
  • add definitions for 1846
  • add definitions for 1861
  • render multiple cities (e.g., OO, NY, Chi)
  • multiple revenue centers: render just one revenue circle, or render two separately (currently 2 rendered, right on top of each other)
  • more icons (e.g., meat packing, port)
  • E/W label and bonus
  • render 1830's preprinted tile for PRR's home

other (mainly aesthetic features):

  • three-digit revenues need to render without bleeding over the circle
  • elements should not render outside bounds of hex (e.g., Uwajima)
  • make location names part of the hexes instead of tiles
  • smart positioning for circles showing the revenue
  • "white background" / box for 4+ city slots (implemented for 2-3)
  • clearly show crossing track (white outline)
  • fix rendering gentle curve on top of other curves (see tile 16)
  • center tile name when rendering just the tile name due to error?
  • 1889 preprinted gray town names should be rendered (Yawatahama, Muroto)

Incorrect passing of priority in isr

When playing out the initial stock round when I pass in order not to raise a bid, the pass counts as a pass not for the auction but a pass on priority. (See log for Game id 34)

See attached image

1430B01D-4D2D-498D-AA50-335DFBD7A609

session report

dear Toby, i write you about my first long game session with your app.
First of all, thanks fro your great work! I've tried before playing online 18xx but it's the first time I'm looking forward doing it again and again after one session!

Here my feedback for the current state of the art (apologies for my poor english, I'm an italian after all :-) ) :
The game I'm writing about is the id74
There are minor presentation issues and I know you're dealing quickly with them (yesterday when i opened the game the new corporation look was a very pleasant surprise).
I would like to get some more information on the game maps (train phases, train limits).
Especially as soon as more 18xx game will be implemented with your system the need of this kind of minutiae will get more important.
The bank pool with the already sold stock would be also useful.
Maybe different color for the different player name (but I'm nitpicking now).

The bug or major issues I found are the following:
when a corporation bought the sumitomo company and tried to lay a mountain track without river
the power to ignore the building cost was not active, meaning the 80 $ was regularly charged on the company treasure (maybe we didn't find a way to make this work, in this better scenario my “complaint” would regard the usability, but I suspect the this rules was just not working).

Same thing with the train limit. The agenda showed us that as expected we were entering the phase 5 and the train limits of 2 but it was only when we entered phase six that we were forced to have just two trains in the corporation. In phase 5 a corporation was also able to buy a third train.
But even if we were careful to fair play, not being able to discard the trains in excess was a gamebreaker.

The other and possibly bigger issue we had was the ability to buy trains form other corporations at a proce different from 1$. We used the price tab and tried by clicking but also by writing the amountof money we wished to pay and it always decided we were going to pay 1$.
Obviously after that we just continued the game for test, not for “enjoying the game” (wich really was until then really enjoyabe, and we are very very grateful).

Probably a minor bug (but I think I wouldn't be an accurate tester if I wouldn't mention it) occured just once, when the Iyo railway was able to run the same route twice. The director of the company saw what was happening and used the undo button to avoid the mistake, but the app was allowing him to do it, while in an other occurrenc eof the same mistake from another corporation the app showed us the mistake.

Finally, I saw on the forum that someone perceived as useful the possibility to control form one computer the other online player's moves.
We thought the opposite, because sometimes inadvertently someone thinking to act for himself made adecision for another player (we manage to undo, but we were uncomfortable about it).

I hope that with this letter I'm “making my job” by offering you something in exchange of the wonderful gift you are providing us all.

Maybe one day would be nice to play with you (I'm sure you could teach me many things as you did when I watch you running a game of rolling stock)

thanks again and keep up the great work!

eugenio aka sharunasbresson

Auction don't prevent bidding on another private once the "Plug is pulled"

I had 2 players with bids on the second private, once the first was bought, one of the player with a bid a 2nd private did his bid on another private (which I don't think is allowed in the rules)

(The log is inverted when I copy paste it)

3 collects $5 from Mitsubishi Ferry
1 collects $5 from Takamatsu E-Railroad
-- Operating Round 1.1 --
3 passes
2 passes
3 buys Mitsubishi Ferry for $40
1 passes
1 bids $60 for Sumitomo Mines Railway
1 buys Takamatsu E-Railroad for $20
3 bids $70 for Dougo Railway
2 bids $65 for Dougo Railway
1 bids $85 for South Iyo Railway
3 bids $40 for Mitsubishi Ferry
2 bids $55 for Sumitomo Mines Railway
1 bids $35 for Mitsubishi Ferry

Error when placing a tile

Happened a few time to me, I'm not sure of the exact trigger.
I select a map tile to view the available tiles,
I select one, rotate a few times, cancel,
select another, rotate a few times, cancel
repeat
when selecting the tile after, nothing happens and there is an error in the console
Once this happens, I cannot cancel, or apply. every click on the map seems to register an error in the console. I can resolve the issue with the undo button

Console output
"owner: undefined method `owner' for #Engine::Train::Depot:0x4840
at constructor.$method_missing (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:3907:56)
at constructor.method_missing_stub (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:1310:35)
at $$2 (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:39807:17)
at Object.Opal.yield1 (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:1449:20)
at $$94 (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:10218:22)
at Object.Opal.yieldX (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:1472:20)
at self.$each.$$p (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:8748:26)
at Object.Opal.yield1 (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:1452:14)
at constructor.$each (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:14806:14)
at constructor.$collect (http://159.203.254.109:9292/assets/app.6120dd8da45b9ed7eff1564b0786d20abd9ec95fac096101105734ad1f982b8f.js:8753:12)"

Train limit enforcement doesn't work (Game ID 34)

Hi Toby, don't know how much info you need. But player Jones in our game (34) bought the first 4 train, while he already had 3x 3 train. But he didn't get the option to discard a train, so he kept 4 trains.
Thanks for your efforts!
Spobster

Use color codes for the companies

It would be interesting if the companies were also identified by color. I just floated the KU in the first SR thinking it was the TR because I got confused only looking at its full name :)

Game ID 48: SR ends after sale of a stock

EisVrouw81 floated UR and then sold a share of UR. The other two players both passed. The game moved to an OR, not giving EisVrouw81 the option to pass or buy a share of another company. EisVrouw81 had sufficient funds to purchase a share of a different company.

We backed it up, and tried again. EisVrouw floated UR. The other two players both passed. The game gave EisVrouw the option to sell a share or pass. EisVrouw sold a share of UR, and the game moved immediately to an OR without giving EisVrouw the option to purchase a share.

Lobby proposal

#enhancement Would be nice to have the active game(s) a player is in sort to the top of the list.

All Pass in Private Auction

When all players pass in the private auction, it should keep the bids.

If everyone passes before the privates are all sold, then a) if no privates has been sold, Private 1's price is decreased by 5; b) if some privates have been sold, they pay out. Then you continue the private auction.

Use Done instead of Pass in appropriate places

Currently, the button that you push to indicate that you (player or corporation) are done performing actions is labeled Pass, but this should be reserved for cases when you are really doing nothing at all; otherwise the button should be called "Done" (or maybe something even more specific like "Lay no track") so as not to imply that you're forfeiting your entire turn.

Auction phase - cannot bid on Duogo Railway

3 companies have been already bought, leaving two in a 2p game. I can place a bid on the first company but not being allowed by game to bid on the Duogo Railway at the moment. ID 59 game

Laying Track - Microsoft Edge

Currently experiencing difficulty laying track while using the site through Microsoft Edge on laptop. When selecting a legal hex in which to place track, none of the track tiles populate. However, when using Chrome on mobile, track options populate with no issues.

Exchange Dougo Railway (game id 75)

I can't (seem to find out how to) exchange the Dougo Railway private for a Iyo share during SR1.

Edit: I figured it out so it's not a bug. It isn't intuitive though. When I want to exchange I need to:

  • go to the companies tab,
  • select Dougo
  • go to the game tab
  • press the then appeared button to exchange share.

Perhaps this can be made in a more transparent way.

Operating round : Placed a second tile instead of buying train

First Operating Round : Awa is floated in Stock round 1
I placed a yellow tile on home tile, then placed a second tile next to it.
Train buying step was passed by doing this

(Log is inverted)
-- Stock Round 2 --
Awa Railroadspends $80 and lays tile 7 with rotation 0 on K6
Awa Railroad's share price changes from $65 to $60
Awa Railroad does not run
Awa Railroad lays tile 5 with rotation 3 on K8

No train roster visible

Train roster only appears to be viewable during train buying step. Would be useful information to have on hand.

Stock Round : Bid validation

No validation is performed to check if the player has the money required for the bid.

  • A player can place a single bid greater than his total money

  • A player can have multiple bids totaling an amount greater than his money.

according to the rules : If a player has a bid on a company, he must set the bid amount aside until that company is sold

maybe the total of money set aside could be shown next to the players money
cash: 420 (120)
a bid like in rolling stock when money is in transit

Sharp curve missing from available tile

Sharp curve existing on Matsuyama (E2) between Imabari (F1) and Saijou (F3).
I select Saijou (F3)
Can only select a straight or a gentle curve. I believe a legit sharp curve could be build to link Matsuyama (E2) and E4

Suggestion : Priority deal

Add a visual cue to show which player has priority deal for next Stock round.
Add an event in the log at the end of the stock round to say "priority deal awarded to player X"

Condense player info boxes

Current player info box:

Players
name: RJ_E                                  name: Vorrt                                 name: EisVrouw81
cash: 295                                   cash: 174                                   cash: 170
companies:                                  companies:                                  companies: South Iyo Railway
Iyo Railway *50%                            Awa Railroad 0%                             Awa Railroad 0%
Awa Railroad 0%                             Tosa Electric Railway *50%                  Uwajima Railway *50%
Sanuki Railway 0%                           Iyo Railway 0%                              Iyo Railway 0%
Takamatsu & Kotohira Electric Railway 0%    Sanuki Railway 0%                           Sanuki Railway 0%
Tosa Electric Railway 10%                   Takamatsu & Kotohira Electric Railway 0%    Takamatsu & Kotohira Electric Railway 0%
Tosa Kuroshio Railway 0%                    Tosa Kuroshio Railway 0%                    Tosa Electric Railway 10%
Uwajima Railway 0%                          Uwajima Railway 10%                         Tosa Kuroshio Railway 0%

Proposed layout:

Players
name        RJ_E       Vorrt  EisVrouw81
cash         295         174         170
companies                               
AR            0%          0%          0%
IR          *50%          0%          0%
SR            0%          0%          0%
TER          10%        *50%         10%
TKER          0%          0%          0%
TKR           0%          0%          0%
UR            0%         10%        *50%

Changes:

  1. Switch to a table with just one label per row. This makes the info denser and also ensures the companies are in the same order for each player, alphabetical here but any consistent order is better than random.
  2. Company names condensed to acronyms / abbreviations. Not visible above is a tooltip on each one that would expand to the full name. The color(s) of the company could also appear around or alongside the abbreviation and/or full name.
  3. Holding amounts right aligned for quicker visual scanning

Suggestion : Shares in the Bank vs Shares in IPO

Add a way to know how many share of a company are in the bank pool vs the quantity in the IPO

When there is share both in the IPO and the bank pool, have a way to select from where to buy the share

Issues with Iyo/Dougo in SR 2 and OR 2.1

Game ID# 56
In SR 2 Groganite purchased president's share of Iyo parring at $65 then converted Dougo Railway. During this SR the converted share vanished and the private came back. We were able to undo this and get the shares to work out, but Dougo stilled payed out in OR2.1:

Groganite buys a 10% share of Iyo Railway for $65
Groganite exchanges Dougo Railway for a share of Iyo Railway
Groganite passes
tesh84 passes
Groganite passes
tesh84 collects $5 from Takamatsu E-Railroad
Groganite collects $5 from Mitsubishi Ferry
Groganite collects $10 from Ehime Railway
Groganite collects $15 from Sumitomo Mines Railway
Groganite collects $15 from Dougo Railway

Also had to pass an extra time in the SR.

In OR 2.1, Iyo's treasury disappeared. It generated $100 revenue with no train. Groganite withheld the phantom $100, bought one 2-train, then was able to buy another 2-train with $60 personal contribution:

Iyo Railway withholds $100
Iyo Railway's share price changes from $65 to $60
Iyo Railway buys a 2 train for $80 from The Depot
Groganite contributes $60
Iyo Railway buys a 2 train for $80 from The Depot

We probably made the issues worse with too many undo actions.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.