Git Product home page Git Product logo

ldlinkr's People

Contributors

machiela avatar timyers avatar yfarjoun avatar

Watchers

 avatar  avatar

Forkers

s-rashmi

ldlinkr's Issues

Release LDlinkR 1.4.0

Prepare for release:

  • git pull
  • Check current CRAN check results
  • Polish NEWS
  • usethis::use_github_links()
  • urlchecker::url_check()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • revdepcheck::revdep_check()
  • Update cran-comments.md
  • git push

Submit to CRAN:

  • increment Version field in DESCRIPTION
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted ๐ŸŽ‰
  • usethis::use_github_release()
  • usethis::use_version("minor")
  • usethis::use_dev_version()
  • git push all master

Invalid query format for variant

Hello,

Recently I was pointed to your package, which I greatly appreciate. Unfortunately I've run into an issue:

I have SNP data in the format "chr"CHROM:POS, with positions ranging from 7 to 9 digits.
My data is from an imputation server that uses Genome Build 37.

However, LDlinkR only accepts positions of exactly 8 digits. What is the reason for that?

Furthermore, when appending the 7-digit positions with a 0 in front, I get no results either (example: "error: chr10:09062856 is not in dbSNP build 151.")

Thank you in advance.

LDproxy_batch()

When using LDproxy_batch(), if append = TRUE option, there's a warning message that the column headings are appended. In the output file, though, there is only on heading at the top, which is perfect.

LDpair - issue with output="table" when SNPs are in linkage equilibrium

Hello,

I am really happy to see that this package exists, I have been using LDlink once in a while in the past years, and having some functions to do it easily with R without struggling with the request format and how to parse the output every time is very nice: thank you! :)

I can run your example LDpair(var1 = "rs3", var2 = "rs4", pop = "YRI", token = Sys.getenv("LDLINK_TOKEN")) without any problem, but I have been having some issue when using pairs of SNPs that are not in LD.

library(LDlinkR)      
my_var1 <- "rs2860773"       
my_var2 <- "rs2631669"      

Using output = text, everything works:

LDpair(my_var1, 
            my_var2, 
            pop="EUR", 
            token=Sys.getenv("LDLINK_TOKEN"),  output = "text")
# Query SNPs:
# rs2860773 (chr2:65665641)
# rs2631669 (chr2:66104881)
#
# EUR Haplotypes:
#                rs2631669
#                C       T
#              -----------------
#            G | 326   | 273   | 599   (0.595)
# rs2860773    -----------------
#            T | 210   | 197   | 407   (0.405)
#              -----------------
#                536     470     1006
#               (0.533) (0.467)
# 
#           G_C: 326 (0.324)
#           G_T: 273 (0.271)
#           T_C: 210 (0.209)
#           T_T: 197 (0.196)
#
#           D': 0.0316
#           R2: 0.0008
#       Chi-sq: 0.778
#      p-value: 0.3777
#
#  rs2860773 and rs2631669 are in linkage equilibrium

But using output = table (default), I get this error message:

LDpair(my_var1, 
            my_var2, 
            pop="EUR", 
            token=Sys.getenv("LDLINK_TOKEN")
# Error in z[[22]] : subscript out of bounds

From what I understand, it comes from your function table_out() that expects 22 lines as it is when variants are in LD (in your example):
21 : "rs3(C) allele is correlated with rs4(A) allele"
22 : "rs3(T) allele is correlated with rs4(G) allele"
But when variants are actually in linkage equilibrium, these two lines are replaced by a single one (my example):
21 : "rs2860773 and rs2631669 are in linkage equilibrium"

This should be quite easy to fix! ;)
Thanks again for this very useful package!

Release LDlinkR 1.3.0

Prepare for release:

  • git pull
  • Check current CRAN check results
  • Check if any deprecation processes should be advanced, as described in Gradual deprecation
  • Polish NEWS
  • urlchecker::url_check()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • rhub::check_for_cran()
  • revdepcheck::revdep_check(num_workers = 4)
  • Update cran-comments.md
  • git push
  • Draft blog post

Submit to CRAN:

  • usethis::use_version('minor')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted ๐ŸŽ‰
  • git push
  • usethis::use_github_release()
  • usethis::use_dev_version()
  • git push
  • Finish blog post
  • Tweet
  • Add link to blog post in pkgdown news menu

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.