Comments (5)
Alright, so I've pretty much concluded my work on this issue. Here's the results:
-
I've added in a fallback for all "unnatural" spawns, so that they can be champions too. This should round out various issues for fringe cases and also definitely includes the Wither and the Ender Dragon now. This also re-enables spawn eggs being able to spawn champions, so you can use that for further testing if necessary. These changes will appear in the next update.
-
Mowzie's Mobs: The reason that their mobs don't work with the config is because their mobs can't spawn as champions at all and that is because they don't actually label them as mobs (read: they do not implement the IMob interface that all vanilla mobs and many modded mobs do).
from champions.
I'll do some testing momentarily on the config list.
Note that it's intended behavior that only mobs spawned naturally or from a mob spawner will become champions. Spawn eggs will never spawn champions. This is because these use different spawning methods.
I just tested the "/championegg" command and it executed correctly. What specifically are you entering in to get the egg?
from champions.
There's a spawn egg in JEI called "spawn champion" from your mod when you @champions. I just added it to hand via cheat mode and tried to use it.
Ah I didn't test the /championegg command. I just realised what that champion egg is for and why it doesn't work.
So testing using the command,
- vanilla mobs work fine using /championegg skeleton 1 (for example)
- the majoirty of primitive mobs I tested seem to work using the command /championegg primitive:mobs "insert mobsname" "tier"
- it looks like mobs from primitive mobs do get affected by the config (part of the original issue), I just assumed they didn't because I was using spawn eggs to test if it worked.
- using /championegg mowziesmobs:naga (tried most mobs from mowzies) gives me the egg (so it is definitely the right formatting) but doesn't spawn a mob for me, and natural spawns from mowzies don't get affected by the config. Maybe it's the way they are coded?
- side note, I assume it's either intended (or not possible) for the wither and ender dragon to be champions (due to the way they spawn maybe?)
from champions.
Ah yeah, that explains it. You need to obtain it via command in order to give the egg the correct information, otherwise it's useless.
I'll have to test Mowzie's Mobs to see what's going on there.
You know, I never thought about the Wither and the Ender Dragon. Originally the code used a different hook so they could definitely become champions, but now I'm not sure. Probably not? I'll definitely have to look into this. It's intended that it's possible for them to become champions.
from champions.
Understood, thanks for looking at the issue for me. I appreciate how quickly you clean up bugs/issues with all your mods.
from champions.
Related Issues (20)
- Dropping the loot of the monster itself HOT 1
- [1.18.2] Champions HUD stops updating after the player dies HOT 6
- [1.18.2] Champion mobs spawn near beacons
- [1.18.2] Crash with the latest Scaling Health
- [Feature Request] Affix combo blacklist
- [1.16.5] Reflective's DamageSource is the Player attacking HOT 3
- Please change getOrigianalExperience to getDroppedExperience in LivingExperienceDropEvent
- [1.18.2] Feature Request: Gamestage support HOT 3
- Champions Critique - Clarity, Balance, and Addition Requests HOT 8
- Information Request HOT 3
- [1.16.5] /summon entities dont get all stats from ranks config HOT 4
- [1.18] Champions completely ignoring predefined affixes HOT 3
- [1.18.2-2.1.6.0] Generating chunks lags the server / causes tps loss compared to v2.1.5.6 HOT 7
- Forge does not support multiple server configs for updating packs HOT 3
- Concurrent Modification Crash HOT 1
- champions keep crashing whenever i try loading a world HOT 1
- Champions, Beacon, Megatorch Server crash HOT 1
- [1.16.5] Nightconfig can encounter file already opened exception HOT 5
- Champions' 'Boss Bar' renders multiple times (causing compatibility issues) HOT 1
- entities config question
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from champions.