During initial setup I select import and then, after several books have been processed

Should be fixed with merge <a class="issue-link js-issue-link" data-error-text="Failed

Value too long for type character results in failure during import books about pyshelf HOT 6 CLOSED

th3r00t commented on May 30, 2024

Value too long for type character results in failure during import books

from pyshelf.

Comments (6)

th3r00t commented on May 30, 2024 1

The type should be adjusted here. This will likely squash this issue. I've just gotta get to it. or get a pr ;)
https://github.com/th3r00t/pyShelf/blob/8adcb0e1723597578ea34d2e60a276ad57e29384/src/interface/models.py

from pyshelf.

th3r00t commented on May 30, 2024

Thanks for this report!

from pyshelf.

simcop2387 commented on May 30, 2024

I've run into this and It looks like it's probably on the book.rights value.

the epub has this in the contents.opf

    <dc:rights>Text copyright © 2019 by Dragonsteel Entertainment, LLC; Cover art copyright © 2019 by Charlie Bowater; Starsight map by Bryan Mark Taylor copyright © 2019 by Dragonsteel Entertainment, LLC; Additional illustrations by Isaac Stewart and Ben McSweeney copyright © 2018 by Dragonsteel&amp;#x00A0;Entertainment, LLC</dc:rights>

Which contains a string longer than 255 characters. And truncating this fixes the import. My specific book is Starsight by Brandon Sanderson

from pyshelf.

simcop2387 commented on May 30, 2024

The best way to fix it is to likely stop using varchar() and instead just use the text type.

https://www.postgresql.org/docs/13/datatype-character.html has the details about how they differ

from pyshelf.

simcop2387 commented on May 30, 2024

I may make a PR later then for it. Another good link for anyone coming back to this later

https://wiki.postgresql.org/wiki/Don%27t_Do_This#Don.27t_use_varchar.28n.29_by_default

from pyshelf.

th3r00t commented on May 30, 2024

Should be fixed with merge #73