Git Product home page Git Product logo

Comments (7)

th3r00t avatar th3r00t commented on May 30, 2024

SECRET_KEY = "@(9b9jslgg41u1u=mr)-2*-n2x0vef0zsy39*z@sz18&tvow18"
The secret key should be randomly generated for each install of pyshelf, This is probably something we will have to handle during the setup phase, probably by generating one into the config.json, and referencing it

DEBUG = TEMPLATE_DEBUG = True
if DEBUG is True:
    from pudb.remote import set_trace
ALLOWED_HOSTS = CONFIG.allowed_hosts

The django test server requires the debug setting to be true in order to correctly reference static files.https://docs.djangoproject.com/en/3.0/howto/static-files/, in an attempt to make the project more accessible to new users I have chosen to leave the debug setting to true that they may easily host the frontend. The README should be updated to reflect this to users so they may toggle it off during their install.

My thoughts are that if they dont know how to setup a web server, and have been warned against using the testserver and still choose to then security isnt a concern for them.

from pyshelf.

MartenBE avatar MartenBE commented on May 30, 2024
DEBUG = TEMPLATE_DEBUG = True
if DEBUG is True:
    from pudb.remote import set_trace
ALLOWED_HOSTS = CONFIG.allowed_hosts

The django test server requires the debug setting to be true in order to correctly reference static files.https://docs.djangoproject.com/en/3.0/howto/static-files/, in an attempt to make the project more accessible to new users I have chosen to leave the debug setting to true that they may easily host the frontend. The README should be updated to reflect this to users so they may toggle it off during their install.

My thoughts are that if they dont know how to setup a web server, and have been warned against using the testserver and still choose to then security isnt a concern for them.

I see, I stumbled on this, because we git pull the repository into the docker image and therefor the docker runs in debug mode instead of production mode. In order to circumvent this, we should have a way to pull or download a release version.

from pyshelf.

th3r00t avatar th3r00t commented on May 30, 2024

Sounds like were gonna need to set that in config sooner then later

from pyshelf.

jonafato avatar jonafato commented on May 30, 2024

As an alternative to using debug settings, Whitenoise supports serving static files for Django in production.

from pyshelf.

th3r00t avatar th3r00t commented on May 30, 2024

As an alternative to using debug settings, Whitenoise supports serving static files for Django in production.

This looks promising.

from pyshelf.

th3r00t avatar th3r00t commented on May 30, 2024

Django secret keys now generate on a per-install basis 0fc3d44

from pyshelf.

th3r00t avatar th3r00t commented on May 30, 2024

As of version 0.6.0 this is no longer an issue.

from pyshelf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.