Git Product home page Git Product logo

Comments (2)

mrlika avatar mrlika commented on May 28, 2024

Reverting #6693 fixes the issue

from query.

TkDodo avatar TkDodo commented on May 28, 2024

thanks for reporting. I narrowed it down to this minimal test case for replaceEqualDeep:

it('should be able to share values that contain undefined', () => {
  const current = [
    {
      data: undefined,
      foo: true,
    },
  ]

  const next = replaceEqualDeep(current, [
    {
      data: undefined,
      foo: true,
    },
  ])

  expect(current).toBe(next)
})

fails with:

AssertionError: expected [ { data: undefined, foo: true } ] to be [ { data: undefined, foo: true } ] // Object.is equality

If it should pass with deep equality, replace "toBe" with "toStrictEqual"

Expected: [ { data: undefined, foo: true } ]
Received: serializes to the same string

@schiller-manuel FYI

since this traces back to TanStack/router#903, I'm also pulling in the original author of that PR, @kahosan

Any help is appreciated; if we can't find a quick way to fix this, I'll revert #6693

from query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.