Comments (3)
TkDodo
commented on May 30, 2024
it seems to be this condition specifically because zero is falsy in js 🙄
query/packages/query-core/src/query.ts
Line 253 in b32ad24
It works if you set it to -1 for example.
I would consider this a bug rather than a missing documentation. There a couple of those checks that we likely should change towards > 0 instead.
from query.
TkDodo
commented on May 30, 2024
okay, it's late. I think we shouldn't check for dataUpdatedAt here at all. This check likely means: we're always stale if there is no data yet. !dataUpatedAt kind of reflects that, but not really. The check should likely be made against this.state.data !== undefined like we do here:
query/packages/query-core/src/query.ts
Line 624 in b32ad24
from query.
Jokero
commented on May 30, 2024
@TkDodo Ok, makes sense, thank you
from query.
Related Issues (20)
- Type 'void' is not assignable to type '{ user: Partial<User>; }' HOT 2
- exhaustive-deps doesn't understand function call for query key HOT 4
- Solid Query error triggers ErrorBoundary in Astro but not in SolidJS
- Can't test Query mutations using Angular's HttpTestingController HOT 2
- Solid Query: Query errors are not caught by ErrorBoundary in the same component
- "placeholderData: keepPreviousData" results in double fetch HOT 1
- Unable to Display Previously Fetched Data in Offline Mode HOT 2
- v3 and v4 docs are unavailable HOT 2
- minimizing devtools loses offline toggle state HOT 2
- react-query-devtools: restore loading infinite wait HOT 4
- queryOptions typing errors when calling queryClient methods with ref in query key HOT 4
- Typescript incorrectly narrows `error` based on `isLoading` HOT 2
- solid-query Hydration Mismatch on SSR from version 5.24.2+ HOT 1
- Depracted warnings when installing @tanstack/react-query@latest HOT 1
- Devtools Picture-in-Picture not Working With `shadowDOMTarget` HOT 4
- getQueryData suddenly returns undefined for a query even though no update to query data has occurred HOT 8
- useSuspenseQueries inference differ from useQueries inference HOT 2
- Redundant queries invalidation when combining `useQuery` with `fetchQuery` in v5 HOT 10
- Error is reset to null during invalidation HOT 2
- UI reflection using firebase in react-query is it possible in offline mode ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from query.