swen-222-assignment-2's Issues
Duplicate constructors
Vector2D has two constructors which do the same thing,
Vector2D(Vector2D) (copy constructor) should call Vector(int, int)
Diamond reach instead of circle
as of 338a684 the withinReach() method uses Manhattan distance rather than euclidian distance to see if an object is within reach. See https://github.com/synap5e/swen-222-assignment-2/blob/master/src/space/world/Player.java#L95-L99 . As a result the reach is a diamond around the player instead of a circle.
Euclidean distance is supported in Vector2D.java so an alternative would be
return getPosition().sub(pos).len() <= reach
Or a slightly more optimized (as it avoids the square root calculation):
return getPosition().sub(pos).sqlen() <= squared_reach
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.