Git Product home page Git Product logo

swen-222-assignment-2's People

Contributors

designedbymatt avatar libunamari avatar synap5e avatar whitesweta avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

swen-222-assignment-2's Issues

Diamond reach instead of circle

as of 338a684 the withinReach() method uses Manhattan distance rather than euclidian distance to see if an object is within reach. See https://github.com/synap5e/swen-222-assignment-2/blob/master/src/space/world/Player.java#L95-L99 . As a result the reach is a diamond around the player instead of a circle.

Euclidean distance is supported in Vector2D.java so an alternative would be

return getPosition().sub(pos).len() <= reach

Or a slightly more optimized (as it avoids the square root calculation):

return getPosition().sub(pos).sqlen() <= squared_reach

Duplicate constructors

Vector2D has two constructors which do the same thing,
Vector2D(Vector2D) (copy constructor) should call Vector(int, int)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.