superhero-com / superhero-utils Goto Github PK

Move rebranded superhero-ui button to this repo, after merging this branch. It will allow to reuse it in any Vue projects that has Vuex and at the superhero-ui as well. maybe it can be used also without Vuex

If there is no extension detected - clicking on the Donate button URL redirect should be leading to the corresponding browser extension store page for the Superhero wallet.

https://github.com/postcss/autoprefixer#webpack

Make that repo a part of this one. To make it easier to integrate button in any kind of projects that use sdk.
Not only our jitsi or forks

I was able to add the button on Wix (add, Embed, paste code). But when clicked, it seems the button tries to open the wallet but only shows the top header of it. Attached a screencast (in zip because video files aren't supported otherwise).

SH Button issues.mp4.zip

Maybe later versions can allow users to use the Paywall as entrance ticketing for video conferences.

I'm not sure how to reproduce this, but sometimes npm run build generates only one of superhero-button.js, superhero-button.styles.js. Once I have spoiled a published package because of this. Also, it happened on Travis once: 3dc0128

Maybe @petbaik can help to resolve this?

@davidyuk trying to connect with you. Would like to write up a more user-friendly guide for this for general users.

Currently, the package waits for DOMContentLoaded event to put an iframe in place after that. It won't work for SPAs in cases when the a.superhero-tip-button appears dynamically, to fix this I propose to expose an interface that accepts a DOM node and makes a button instance out of it. It is a well-known practice of reusing common UI parts that were actual before the adoption of frameworks based on components.

Some content creators allow viewers to see the first one or two paragraphs of their blog before a paywall pops up. This might be a good feature for later.

It will be nice to have a react component wrapper. I can help with that.

This should be helpful in cases if somebody wants to add such button in GitHub md file/comment or in forum post, where custom JS is not allowed.

https://github.com/aeternity/superhero-button/blob/4ca4b221c26518233e3b9517173c6b434d9d2100/src/superhero-button.js#L33

Because the web wallet will redirect the user back after tipping and the user doesn't want to have the same page opened twice after that.

It may be useful to have all about API or other Utils at the separate repo. So in this way we can update some in one place and next easily in at least two others superhero-ui, superhero-button(in future also at it's parts like superhero-button/react and superhero-button/vue)

Add data-account property where owners can put their address as well.

This can be useful for non-tech users

What was the reasoning behind using iframes in this package? The only thing that I guess is to make easier the updation of buttons, but we can get the same results depending on unpkg.com like SDk does: https://github.com/aeternity/aepp-sdk-js/blob/develop/docs/guides/import-script-tag.md#latest-sdk-version

So, I propose to make it more durable and flexible (user can override styles) by generation buttons in place (using innerHTML or manually generation DOM nodes) instead of creating an iframe to superhero.com.

https://github.com/aeternity/superhero-button/blob/4ca4b221c26518233e3b9517173c6b434d9d2100/src/superhero-button.js#L14-L16

If we are collecting tips on a separate URL, shouldn't web version of wallet redirect user to the current page instead of one that collects tips? Or maybe should be a separate option to specify the callback url?

https://github.com/aeternity/superhero-utils/blob/c8bdbae420587c9f74c1596202270077b1273e9e/src/button/index.js#L18

is 404 now. Switch to https://raendom-backend.z52da5wt.xyz/stats (899kb now) or find an endpoint that returns stats for specific URL.