Replace rebranded superhero tip button to this repo about superhero-utils HOT 8 OPEN

I didn't get the idea of this. What interface the rebranded button will have? I can't get how it is connected to Vuex. Do you know that the button in the current master is already rebranded?

from superhero-utils.

The idea is to have reusable component for any Vue project. As the interface It can use the same state and mapState helpers. Also maybe it can be separated from the Vuex and reused without it. In any case the main idea is to separate some parts and make superhero-utils used by the superhero-ui as a dependency.

from superhero-utils.

Can't saw the rebranding you mentioned - tips list is not available. Also that's why I suggest Storybook.
I talked with Tsvetan and he told me that https://github.com/aeternity/superhero-ui/tree/feature/new-branding is not merged and I commited there he ask to change the the button. Maybe other style is ready at the master, I will recheck.
I also found right now - https://github.com/aeternity/superhero-ui/tree/feature/new-branding and it looks more alive.

from superhero-utils.

The idea is to have reusable component for any Vue project.

There is already one, we did it in #38

As the interface It can use the same state and mapState helpers.

The current version of tip button just opens a deeplink to the wallet, don't see reasons to connect it to the store somehow.

the main idea is to separate some parts and make superhero-utils used by the superhero-ui as a dependency

• superhero-utils and superhero-ui may have some common code, but I don't think that it is enough big amount to refactor this
• superhero-utils is made for third-party integrations, it has some limitations (like it can't reference sdk explicitly) that we don't have in superhero-ui, so we can't reuse it in superhero-ui easily

talked with Tsvetan and he told me that https://github.com/aeternity/superhero-ui/tree/feature/new-branding is not merged

This is a branch in another repository.

from superhero-utils.

There is already one, we did it in #38

I know, but it's rebranded one and the idea is to use the same for the superhero-ui and any other project.

The current version of tip button just opens a deeplink to the wallet, don't see reasons to connect it to the store somehow.

Why? It can be useful for others. Helps make a nice tip button with the extension or iframe wallet. The current tip button version is works only with "deeplink".

superhero-utils is made for third-party integrations, it has some limitations (like it can't reference sdk explicitly) that we don't have in superhero-ui, so we can't reuse it in superhero-ui easily

Right, that's what I plan to solve – make it works with sdk also. the same sdk that uses the project that want to integrate the tip button.

This is a branch in another repository.

Yes, but you asked why this idea comes to me. That's why – I start to rebranding the button for the superhero-ui and thought that it may be useful to make it a part of the superhero-utils.

from superhero-utils.

to use the same for the superhero-ui and any other project

They look different. Making buttons in superhero-utils to look like in superhero-ui is a breaking change.

make it works with sdk also

SDK is too heavy (about 500kb) for a such use case. Making it optional will make documentation more complicated.

I'm against to work on this.

from superhero-utils.

@davidyuk but it's rebranding now in any case.

SDK is too heavy (about 500kb) ....

I mean make an instruction how to use the component with own SDK instance but not to have the SDK itself at this repo as a dependency.

from superhero-utils.

but it's rebranding now in any case

Can you post a link to the actual designs of the tip button in superhero-utils?

I mean make an instruction how to use the component with own SDK instance ...

I don't think the package users need it.

from superhero-utils.