elastix_napari plugin is incompatible with magicgui=0.4.0 about elastix-napari HOT 5 CLOSED

Yes, that's fixed it!

from elastix-napari.

Oh hang on, yes, the deprecation mentioned is the source of the incompatibility. There's even quite a nice warning message when you run the plugin with magicgui 0.3.7

magicgui 0.4.0 will change the way that callbacks are called
Instead of a single `Event` instance, with an `event.value` attribute,
callabacks will recieve the value(s) directly:

@advanced.changed.connect
def my_callback(*args):
    # *args are the value(s) themselves!

I think if the callback function signature is type annotated, eg: def callback(x: bool): ... then that might make the problem go away. It's worth a try.

from elastix-napari.

...scratch that idea, it is already type-annotated:
https://github.com/SuperElastix/elastix_napari/blob/5180be2ccd3ca5294a4bab149d7a95fc9e9e022e/elastix_napari/elastix_registration.py#L102

Perhaps it's this line that is the problem. That could fit with the warning message about no longer having a .value attribute.
https://github.com/SuperElastix/elastix_napari/blob/5180be2ccd3ca5294a4bab149d7a95fc9e9e022e/elastix_napari/elastix_registration.py#L46

from elastix-napari.

See https://pyapp-kit.github.io/magicgui/api/migration/#v030-migration-guide

from elastix-napari.

Together with @ViktorvdValk and @N-Dekker, we just released a new version 0.1.8 that fixes the current issues.

@GenevieveBuckley Do you mind taking a look if it also works for you now?

from elastix-napari.