This is more of a 'data entry' related task but going through and creating a list of acceptable fuel types.

We'll keep it very simple.

• Petrol
• Diesel
• Electric
• Kerosin - Planes / Helicopters

Relevant Files:
https://github.com/Stuyk/altv-athena/blob/master/src/core/shared/information/vehicles.ts

https://github.com/Stuyk/altv-athena/blob/master/src/core/shared/interfaces/vehicleInfo.ts

try npm ci - this will try install packages with respect of lock file and it will fail saying

can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in syn

to fix this issue just use npm i and commit latest package-lock.json file

Everything is in the title

After restarting the server failure on vehicle check for already spawned faction vehicles

branch 3.0.4

[21:36:57][Error] [V8] Exception at core:file:///C:/Users/Server/altv-athena-private/altv-private/resources/core/server-plugins/core-factions/src/funcs.js:68
[21:36:57][Error] const index = faction.vehicles.findIndex((fv)=>fv.id === vehicle.data._i...
[21:36:57][Error] TypeError: Cannot read property 'findIndex' of undefined
at handleFactionVehicleChecks (file:///C:/Users/Server/altv-athena-private/altv-private/resources/core/server-plugins/core-factions/src/funcs.js:68:40)
at Function.check (file:///C:/Users/Server/altv-athena-private/altv-private/resources/core/server/systems/rules.js:22:28)
at toggleLock (file:///C:/Users/Server/altv-athena-private/altv-private/resources/core/server/systems/vehicle.js:355:26)

Is it correct that this project is "fully" opensource but i cant use it without the codesnipped from the chargeable Api?

Hello,

I did a lot of research to install the framework on my pterodactyl (server manager) but I can't do it..
Can you help me please ?

Thanks in advance,
Sincerely,
F. Miller

In current branch it is not possible to change appearance to native-like skins, for example zombie skin or animal skins. the game just simply crashes.
Attached the crashdumpfiles.
altv_release_14.44_rgl_0x71c653_23-06-30_07-42-23.zip

If updateFuel called for any vehicle not created with athena will get error:

[V8] Exception at server:resources/server/server/0.main.js:2500
[22:18:05][Error]       if (!isNaN(vehicle.data.fuel)) {
[22:18:05][Error]   TypeError: Cannot read property 'fuel' of undefined
at Object.updateFuel (resources/server/server/0.main.js:2500:29)
at handlePing (resources/server/server/0.main.js:3738:85)

Fix is simple:

server/extensions/vehicleFunctions/setter.ts:

function updateFuel(vehicle: alt.Vehicle) {
    // If vehicle is not created by athena skip it.
    if (!vehicle.data.uid) {
      return;
    }
    ....

Just wanted to try out Athena again and got this Error i tried multiple things but nothing worked.

(Yes i tried npm fix)

1. Equip mask
2. Unequip mask
   if i use "Athena.systems.inventory.clothing.update(player)", the mask remains

Game crashes when trying to enter a car and there's some more vehicles around.
tested with 13 vehicles around me at the garage.
on latest 3.9.0 branch.

Anything that uses classes, should use consts instead.

Old Code

export class Something {
    static init() {
        console.log('hello world');
    }
}

Something.init();

New Code

const Something2 = {
    init() {
        console.log('hello world');
    }
}

Something2.init();

export Something2;

Why?

Because of how many things use the class version above; we can create incremental performance increases by migrating to just using consts entirely.

Making the Commit

If you decide to make a PR for these refactor changes. Please make sure to tag your commit with #299

This bug is really difficult to reproduce; but also fix. We've tried dozens of solutions with no fix in sight.

The simplest way to reproduce the bug is to give yourself a full inventory of single items.

Drop all of the items in one place.

Then pick them all back up.

If reproduced correctly you will see 1 object with no text label above it.

At this moment, i found a solution for that, but it can not be last forever.

Try this until Stuyk found other options for that.

src/core/plugins/core-death/client/index.ts

Make it comment for this line:

    /*if (!alt.Player.local.isDead) {   <---THIS
            return;
        }

        if (isAnyMenuOpen(false)) {
            return;
        }*/     <--- to here! CAUTION! Until this line

   Only this IF part. 



For the, atm it is working.

Hi About RmlUi ,I found that all input boxes do not support Chinese language input.
Can anyone help optimize it.

I think it would be nice to have a "duration-option for the MarkerController which will remove the Marker after the specified duration.

Which can be usefull for i.e. Temporary Editors, and something else.

Dear author, I would like to ask how to add a sound wave to the ALTV platform, so that I can share how to put the file? Also, how should the module clothes be added?

Press the chat open button while leaving the vehicle and you will not be able to do anything except open the F8 console.

I can't confirm if this is my own problem,so please test yourselves.

I noticed that when you park a car out of the garage and it spawns the GameControls are reactivated but the webview does not close.

@Stuyk confirmed this. Here is the desired issue :)

clean 3.9.0

===> Starting Server Process
./altv-server: 1: Syntax error: "(" unexpected
Server process exited with code 2
===> Starting Server Process
./altv-server: 1: Syntax error: "(" unexpected
Server process exited with code 2
===> Starting Server Process
./altv-server: 1: Syntax error: "(" unexpected
Server process exited with code 2
===> Starting Server Process
./altv-server: 1: Syntax error: "(" unexpected
Server process exited with code 2
===> Starting Server Process
./altv-server: 1: Syntax error: "(" unexpected
Server process exited with code 2
(repating forever ...)

is something wrong when going throu the current installer or why is it broke?

particles got

delay
dict
duration
name
pos
scale

there is color missing :(

(not every particle supports color)

Reproduces on: v5.1.0, 6.0.0

If an item hascanTrade=falseor canDrop=false, it should not render the Give and Drop options on the page

How to repair it?

Console

[12:42:21] alt:V Server 2.23 (release)
[12:42:21] Starting alt:V Athena Roleplay Framework on 0.0.0.0:7788
[12:42:21] Loading resource altv-ares
[12:42:21][Error] Could not open resource.cfg
[12:42:21][Error] Failed to load resource altv-ares
[12:42:21] Loading resource core
[12:42:21][Error] Could not open resource.cfg
[12:42:21][Error] Failed to load resource core
[12:42:21] Required server permissions:
[12:42:21] Optional server permissions:
[12:42:21] Starting HTTP server on 0.0.0.0:7788
[12:42:21] Main thread started (ThreadId: 2144)
[12:42:21] VoicePacketProcess thread started (ThreadId: 16280)
[12:42:21] VoiceStreamer thread started (ThreadId: 7544)
[12:42:21] Colshape thread started (ThreadId: 18156)
[12:42:21] EntityStreamer thread started (ThreadId: 17860)
[12:42:21] Network thread started (ThreadId: 18392)
[12:42:21] Console thread started (ThreadId: 9668)
[12:42:21] Server started

Athena currently requires all plugins to be placed inside of src/core/plugins.

It would make more sense to create a new folder just called plugins and that's where all plugins go.

What would this require and change?

• Pathing helpers in tsconfig for @server or @client or @shared
• Moving all plugins to individual repositories and keeping them out of the core framework.
• • This would be an effort to slim Athena down to what is actually core; and remove anything extra.
• This would require users to download additional plugins when they get Athena.
• • Allows for more customization, and they are not forced to use core plugins outright.
• Lots of unknowns from a file resolve perspective.

Why?

• This removes unnecessary plugins that come with Athena.
• Instead it focuses on just a few core plugins needed for starting the server.
• Allows for other game modes to be quickly built out from a slim Athena.

Hello author, could you please explain how to build it in detail? I'd like to study it. Thank you

Missing start.sh script for linux

Hello -

When using Athena.vehicle.spawn.persistent(), the underlying code doesn't actually check if the vehicle is already spawned. It uses Athena.document.vehicle.exists(), which checks if a vehicle exists, but not if it is spawned.

Thus, I suggest that line 74 of src/core/server/vehicle/spawn.ts gets changed to:
Athena.vehicle.get.spawnedVehicleByDocumentID()

This way, the spawn system actually checks if the vehicle is spawned, rather than if a document exists for it.

Currently rewriting the inventory. This is just an issue to track what's being done for it.

If you want a full breakdown of the work necessary for this rework you can see it here:

https://discord.com/channels/790039623648542760/1002195465460265000/1002205650073423923

The interface is already mostly complete for the rework.

Some ideas to improve jobs.

Let me know if those features are already implemented.

Job events

• OnJobCompleted
• OnJobCanceled

Objective Counter

• A counter that show the total objective completed vs total objectives.
• A setting per objective to exclude it from the count.

Simultaneous objectives

• Possibly having multiple objectives active at the same time.

Hiding other Jobs while a job is active.

• Preventing activating other jobs too.

Hiding starting blip/marker

• Once the job is accepted we shouldn't see the starting marker and maybe even the blip.

Maximum Time to complete

• With a visible timer.

Static pedestrian

• Having a static ped at the location where the job start
  (Pretending that he give you the job)
• Having non-moving ped at an objective destination.
  (Pretending that we deliver him something)

Make the fuel station plugin allow you to specify how much fuel you want to actually purchase.

Taken from Discord from KeRR.

The icons in the inventory didnt load and the item sound are disable?

First, thank you for the awesome project.
Many of the import statements throughout the project are relative imports like here:

With the following lines in tsconfig.json

"baseUrl": ".",
"paths": {
    "@src/*": ["src/*"]
},

the import from above could look like this:

import { SHARED_CONFIG } from '@src/core/shared/configurations/shared'; 

Did you consider this option for the project? It can also be incrementally adopted if you want to try it out.

There will need to be some additional changes to the plugin to support the file structure changes that were enabled in August. You can read about them here: https://discord.com/channels/790039623648542760/963569191951147008/1004503655250145371

Ideally we get the images in their own folder inside of the plugin, and then reference them accordingly.

Acceptance Criteria

• Images moved out of src-webviews for hairstyle previews
• Vue BarberShop file now references those images in the local plugin
• A screenshot to show changes worked

After setting the player uniform, even if the player uniform is removed before offline, the character information cannot be read after the next login.

error message
[Error] Uncaught exception: TypeError: Cannot read properties of null (reading 'length') at Module.update (file:///D:/altProject/alt-V-Project/resources/core/server/systems/inventory/clothing.js:252:37) at showCharacter (file:///D:/altProject/alt-V-Project/resources/core/plugins/character-select/server/index.js:54:39) at Object.show [as callback] (file:///D:/altProject/alt-V-Project/resources/core/plugins/character-select/server/index.js:35:5) at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

As this may seem like a personal preference, the TypeScript handbook does not suggest prefixing interfaces with 'I'.
This convention is borrowed from the past and I believe this project shouldn't use it since:

• it is against encapsulation principles.
• Hungarian notation times are long gone.
• it is a bad naming convention.
• major TypeScript based frameworks and libraries discourage from this (Angular, lib.d.ts etc)

A more detailed discussion and reasons can be found here and here

Why does the project have a fivem tag?

Remove husky from the build pipeline.

Explore options for forcing code styling through prettier cli or something else.

Currently the /getitem command only gets items based on their actual name.

Needs to support fetching items by dbName which can be done with this function:

• Make the /getitem check through ItemFactory.get first.
• If the result is undefined or null
• Try fetching by name
• if still undefined or null; tell the player it was not found

Seems like the vehicles database id of fresh added vehicles cant be recognized, bug persits a bit longer already, might be related to the /ft command?

Replication:

/addvehicle italirsx

use /ft command will return =>

for driving player and npc misions with taximeter npc spawn and enter in you car

Also add mechanic job for fixing player cars and add tuning shop for upgrade cars bumper engine and other

Maybe you have in plan to create this

Hope this framework will be like esx and qbcore with all jobs scripts jail and other

When you open an inventory with i you should be able to close it with i.

Taken from Discord from KeRR.

Currently it uses an internal custom solution with alt.emitClient. This is no longer necessary and we can use player.setLocalMeta.

Requires refactoring in multiple parts of the code base.

Currently command permissions are using a bitwise flag.

Bitwise flags are generally user-unfriendly for a lot of developers.

Why?

It takes some understanding to understand how a bitwise flag works.

A lot of users assume that permissions work as follows:

if (PERMISSION.MODERATOR > PERMISSION.NONE) {
// do this
}

When in reality; this is not valid.

Proposal

Remove all numerical permissions. Replace with string based assignments for permissions.

Make the permissions all the account level. Throw out character permissions.

Example:

ADMIN = 'account-admin'
MODERATOR = 'account-moderator'
MODERATOR_CHARACTER = 'character-moderator'

This will allow very specific permissions to be assigned at two levels

• Account
• Character

With them being assigned in this way; the permission system can add other permissions to characters that are not moderator or administrative specific.

function addPermission(player: alt.Player, 'some-permission-string') {
    if (player.accountData.permission.includes('some-permission-string') {
      return;
    }
    
    player.accountData.permission += // append here + '|'
}

function oppositeOfAdd

When stored in database should be stored like...

"character-moderator|character-admin|character-police"

Then we can verify a permission exists or permission information by just doing

if (player.accountData.permission.includes('some-permission-string'));

Please add vehicle rotation option. Ty

playerFuncs.inventory.isInInventory is currently returning { index: number; tab: number } and not { slot: number; tab: number }
So you can't get the Item with playerFuncs.inventory.getInventoryItem like in the example below.
playerFuncs.inventory.isInInventory can't be changed because it's index value is used in other functions.
I guess we need a new function where it returns the slot. Like this:

function isInInventory(p: alt.Player, item: Partial<Item>): { tab: number; slot: number } | null {
    for (let t = 0; t < p.data.inventory.length; t++) {
        const tab = p.data.inventory[t];

        if (tab.length <= 0) {
            continue;
        }

        for (let i = 0; i < tab.length; i++) {
            const inventoryItem = tab[i];
            if (!item) {
                continue;
            }

            const objectKeys = Object.keys(item);
            const keyIndex = objectKeys.findIndex((key) => item[key] === inventoryItem[key]);

            if (keyIndex <= -1) {
                continue;
            }

            return { tab: t, slot: inventoryItem.slot };
        }
    }

    return null;
}

I don't know if this is intended or not thats why I didn't make a Pull Request. And I don't know how I should name the function.

The Example I referred to found at Docs

const slotInfo: { slot: number; tab: number } | null = playerFuncs.inventory.isInInventory({ name: 'Micro SMG' });
if (!slotInfo) {
    playerFuncs.emit.message(player, `Item was not found!`);
    return;
}

const item: Item = playerFuncs.inventory.getInventoryItem(player, slotInfo.slot, slotInfo.tab);
if (!item) {
    playerFuncs.emit.message(player, `Item was not found!`);
    return;
}

Applied destroyOnDrop: true as behavior on an item, but as soon as i drop it, the item stays in the inventory. a message shows up (destroyed item), but item is still accessible and saved in the db.

alt.Vehicle IDs starting at 1 and not at 0. The OwnedVehicle IDs for lookups are starting with 0.