Git Product home page Git Product logo

Comments (6)

gotgameio avatar gotgameio commented on May 24, 2024 1

Hi, nice idea that would slim framework it self, one thing i would change is aliases which can be @athena/core, @athena/server, @athena/plugins as they are more explicit.

from altv-athena.

Stuyk avatar Stuyk commented on May 24, 2024

Realistically this can be done in steps; and not all at once. Which would be adding the path aliases first. Moving all plugins to use path aliases and so on and so forth.

from altv-athena.

Stuyk avatar Stuyk commented on May 24, 2024

@gotgameio Only catch with this is that the aliases require a custom build process inside of the SWC script so I don't know how it affects your esbuild thing. I've already got a 'test' branch that made the aliases work but it would definitely force us to use one build process in general.

from altv-athena.

gotgameio avatar gotgameio commented on May 24, 2024

@Stuyk The path aliasing itself is not a problem, i already use it with esbuild/webpack in my project. I argue about @athena/ prefix because personally i use it as a library and i include athena/startup in my main resource with path alias @athena/core/server, @athena/core/client, i dont use @server/@client etc prefixes so i think as they will be used only in athena itself my build will not break, i will test 3.9.0-path-aliasing branch to check if it will break anything.

from altv-athena.

Stuyk avatar Stuyk commented on May 24, 2024

@gotgameio Okay; lemme know. Also get in Discord if you are not already in Discord.

from altv-athena.

Stuyk avatar Stuyk commented on May 24, 2024

I'm not sure if the plugin folder will be moved because of the build issues it will likely introduce. I'm still considering it but I'm not sure at this time. If anything in 4.0.0 we get the path aliasing which makes it a bit cleaner.

from altv-athena.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.