Currently, if I use spr diff to update an existing PR, that PR must either correspond to the commit at HEAD, or I must pass --all, which treats all of the commits on my branch as a stack of dependent PRs and updates all of them.

It would be nice to be able to specify a specific commit in the branch and update just that commit's PR. To work around this, I can reorder the commits and move the one whose PR I'd like to update to HEAD, but it'd be nice not to have to do that.

I looked around a bit and there a bunch of projects that patch alternate non-branch workflows into git. The problem is that most of them don't have anything to make working with Github easy.

See for instance:

• arxanas/git-branchless#45
• martinvonz/jj#485

spr covers the GitHub workflow part (in a much more straightforward way than any other project really) but doesn't go much further than that. Most of these tools also seem to be written in Rust. Could these two things be combined?

Not sure how much of an effort it would be but could spr be turned into a library for sending sequences of commits to Github and keeping them in sync?

I'm trying to have Test Plan appear as a markdown heading in the PR description.
When my commit message contains

 # summary
 using SPR make my life easier
 
 # Test Plan:
 1. do not use spr: sad face
 2. use spr: happy face

Doing spr diff or spr diff --update-message will says:
💔 Commit message does not have a Test Plan!

My current work around is to duplicate Test Plan, one as heading, and one as normal text

I opened pull request using spr diff, spr list / land detects the status of the PR as pending even though it's already approved. The repo is an organization repo

I cloned the repo and try to put some dbg! statements

Request

[spr/src/commands/list.rs:28] format!("repo:{}/{} is:open is:pr author:@me archived:false", config.owner,
    config.repo) = "repo:clockwisehq/services is:open is:pr author:@me archived:false"
query SearchQuery($query: String!) {
  search(query: $query, type: ISSUE, first: 100) {
    nodes {
      __typename
      ... on PullRequest {
        number
        title
        url
        reviewDecision
      }
    }
  }
}

Response

&response_body = Response {
    data: Some(
        ResponseData {
            search: SearchQuerySearch {
                nodes: Some(
                    [
                        Some(
                            PullRequest(
                                SearchQuerySearchNodesOnPullRequest {
                                    number: 5511,
                                    title: "[AI-1016] Send OOO information to Rust defrag",
                                    url: "https://github.com/<REMOVED>/services/pull/5511",
                                    review_decision: None,
                                },
                            ),
                        ),
                        Some(
                            PullRequest(
                                SearchQuerySearchNodesOnPullRequest {
                                    number: 5508,
                                    title: "[AI-910] sync rust defrag schema",
                                    url: "https://github.com/<REMOVED>/services/pull/5508",
                                    review_decision: None,
                                },
                            ),
                        ),
                        Some(
                            PullRequest(
                                SearchQuerySearchNodesOnPullRequest {
                                    number: 5410,
                                    title: "Add ooo for scheduler input",
                                    url: "https://github.com/<REMOVED>/services/pull/5410",
                                    review_decision: None,
                                },
                            ),
                        ),
                        Some(
                            PullRequest(
                                SearchQuerySearchNodesOnPullRequest {
                                    number: 5319,
                                    title: "first pass, create subclasses of movable events",
                                    url: "https://github.com/<REMOVED>/services/pull/5319",
                                    review_decision: None,
                                },
                            ),
                        ),
                    ],
                ),
            },
        },
    ),
    errors: None,
    extensions: None,
}

Token Settings

Pending From SPR list

Browsing PR status

gh pr view 5508

Hi.

A really killer feature here would be a VSCode extension which manages all of the spr features in UI. Two most desired UI features would be:

1. Show a tree of stacked commits and allow the developer to double-click on some commit to “jump into it” - i.e. rebase -i after it. So the workflow would be: “I want to apply a code review comment, I jump into the commit of the PR, make the changes, amend the commit (which automatically rebases all the further commits) and resubmit the diff. After that, I still remain “sitting” in that commit (it doesn’t bring me on top of the stack!), and of course, it’s all reflected in the tree (in which particular commit I am currently sitting).
2. Have a button for spr diff which automatically resubmits my current “jumped in” commit and all other commits on top of it in the stack. I don’t want to think about some other commits while I modified some commit in the middle of the stack.

Hi.

What's the story behind having the tool with the similar purpose and same name, but written in Go?
https://github.com/ejoffe/spr/

That repo doesn't mention you, and also you don't mention them anywhere.

P.S.
BTW a super-nice feature you have in comparison to them is that Pull Request: https://github.com/xyz/abc/... block which is added to every single commit in the local repo (like in old FB times). It helps the reader of commit history to instantly find the PR and discussions in it.

As the branchPrefix will be part of the refname, it should be validated against the criteria found in the git check-ref-format manpage. Otherwise spr diff can fail like this:

fatal: invalid refspec '40cf956ffd653ba646b24d0fef9cb1696300babb:refs/heads/spr/someUser/[bad branchPrefix]/some-commit-summary'
  �  git push failed

I just noticed this: when creating a PR for a commit whose parent is on master, no base branch is created. That's correct. When the commit is rebased on a newer commit on master and spr diff updates the PR, we still don't need to create a base branch, but spr does.

Is it currently possible to use spr diff from a fork and have it create a PR in the upstream repo? I didn't see any options that seemed to imply it was possible, but I might be missing something in the way it works. If it's not possible, are there any thoughts on how it would work? I imagine this doesn't line up with anything in arcanist, since as far as I know Phabricator is meant to be used with a single repo rather than with a bunch of forks.

From what I can understand, it looks like spr uses octocrab for interactions with the GitHub API, and it seems that PullRequestHandler.create wants you to pass in a stringified representation of the fork in the head if creating a pull request from a fork. For instance, if I had a fork of this repo at joneshf/spr, was working on a branch named some-branch-name, and I wanted to submit a PR from a fork of this repo, head seems like it would be "joneshf:some-branch-name" (assuming I understand the documentation of octocrab correctly).

One idea could be to take an option on spr diff specifying which repo to open the PR against. Maybe a better idea is to have a repo-wide configuration to specify if it's a fork or not? I guess it would depend on what else needs to know if it's a fork or not. But I get the feeling that the 80/20 here is: 80% of the time people are either always working directly against the origin repo (so not a fork) or they're always opening PRs against the upstream repo (so always a fork of the same repo), and 20% of the time you're doing something different (like opening a PR against a different repo that is neither upstream nor origin). So maybe most of the ask can be implemented with a repo-wide configuration? Maybe there's another idea?

In any case, I don't have any strong requirements here. I was just thinking about this because I was considering offering to implement something in this repo, and was going to try using spr to do it, but then realized that I couldn't figure out how to create a PR from a fork. I figured Id just ask to see if it was already being thought about.

First off, thank you for building spr! This is already proven to be a really helpful tool.

One workflow I wish could be improved is landing a whole approved stack. I'll often send out a few diffs in a stack (hurray for diff --all) and come back to find them all approved. Right now I'm landing them each with interactive rebase, but this feels cumbersome. I find myself wishing I could land --all to do this programmatically.

Better yet, it would be amazing if this could land those in a landable state (merge-ready and approved) and skip over and report the ones still open. So if I stack A, B and C onto main, find A and B approved, but not yet C and land --all then result in A and B successfully landed and C rebased on the result

i get the following error when trying to run spr diff on an existing pr

🔁 Commit was changed - updating Pull Request #378
🛑 GitHub: Validation Failed
Documentation URL: https://docs.github.com/rest/pulls/pulls#update-a-pull-request
Errors:
- {"code":"invalid","field":"base","message":"Proposed base branch 'refs/heads/spr/dukeofcool199/
is
invalid","resource":"PullRequest"}

I would like to try out spr, but giving an option for other people in my organization to keep using GitHub UI to merge also my pull requests (we use squash merge by default already).

Is there a way to support squash merging the PR in GitHub UI instead of running spr land?
And then run a command locally to update all the other PRs and local/remote branches?

Is it described how landing works ? For example I did a simple repo with some amend, resulting in the following PR log:

1. Why is the base changed? Nvm, this was because it was actually stacked on something else.
2. From an auditing perspective, where does commit 21e5427 come from?
3. How is this PR considered merged to master? - yet the those 'temporary' review commits are not in master.

If I have a stack of changes A -> B -> C and I create PRs, there is nothing to indicate that C is part of a stack and is built on top of A and B. Would it be possible to have SPR amend the PR description with this information as well?

I'm guessing the below failure is due to lack of support for self-hosted gh instances; it would be great to get support here but if there's a workaround please lmk!

❯ spr init
  👋  Welcome to spr!

  🔑  Okay, lets get started. First we need a 'Personal Access Token' from GitHub. This will authorise
      spr to open/update/merge Pull Requests etc. on behalf of your GitHub user.
      You can get one by going to https://github.com/settings/tokens and clicking on 'Generate new
      token'. The token needs the 'repo', 'user' and 'read:org' permissions, so please tick those two
      boxes in the 'Select scopes' section.
      You might want to set the 'Expiration' to 'No expiration', as otherwise you will have to repeat
      this procedure soon. Even if the token does not expire, you can always revoke it in case you fear
      someone got hold of it.
      Please paste in your PAT and press enter. (The input will not be displayed.)
GitHub Personal Access Token: [hidden]
  🛑  GitHub: Bad credentials
      Documentation URL: https://docs.github.com/rest

Git has a way to store repo credentials, which includes GitHub tokens; spr should have a way to use that, instead of needing spr.githubAuthToken. This would avoid having copies of tokens all over the place in .git/config files.

In my global .gitconfig:

[credential]
helper = store

The store helper by default stores credentials in ~/.git-credentials, which looks like:

https://oyamauchi:ghp_*******@github.com

Then this code retrieves credentials for the repo at the URL you pass to CredentialHelper::new:

use git2::Config;
use git2::CredentialHelper;

fn main() {
  let config = Config::open_default().unwrap();
  let mut cred_helper = CredentialHelper::new("https://github.com/getcord/spr.git");
  cred_helper.config(&config);
  println!("{:?}", cred_helper.execute());
}

Which outputs:

Some(("oyamauchi", "ghp_*******"))

Curious if this is still being maintained and if there's any intent to address some of the current gaps the current user base has raised?

For some examples that I'd personally find valuable myself:
#64
#134
#83
#137

Maybe I'm missing something in the documentation, but is there a way to have two different active stacks of work in SPR?

e.g.

main -> A -> B -> C
main -> D -> E

Our repo uses a merge queue to squash and merge all PRs into main and release branches. The way that it is implemented is that after a PR passes all checks and gets code reviewed, a PR author can apply a label to their PR that instructs a github action to merge it into main. This github action will maintain a queue of PRs that want to be merged, and they all need to re-run CI against tip of main before the merge happens. This is to prevent two PRs that don't play nice together from landing and breaking main.

The problem with this approach is that we do not have a way to cleanup the branches that spr creates. I'm not sure if this is something spr land automatically does or not, but we can't run spr land since only the merge queue (and those with special privileges) can merge directly to main.

This would probably be similar to spr close, except the PR is already going to be squashed and merged at this point. I haven't tested using spr close on an already merged PR because I don't know what it will do.

Ran into some confusing behavior just a bit ago. I opened a PR with spr diff --cherry-pick. I wanted to reword the commit message and update the PR with that new message, so I did git commit --amend followed by spr diff. Since I didn't use the --cherry-pick option the second time, it changed the base and pushed a synthetic branch like it normally does for a stacked PR. I understand why it did that, but it's just not what I expected. I'm not sure what the suggestion is from me.

Maybe the documentation should mention that once you use --cherry-pick for spr diff, you have to use --cherry-pick for every command on that commit? That's how spr land works, so it kind of makes sense.

I think it would be nice if you didn't have to remember to always pass the --cherry-pick option after the initial spr diff. If the motivation behind that is to be explicit with the commands, I can understand that. But I can imagine I wouldn't be the only person to either not know, or forget to pass the --cherry-pick option.

Any thoughts on this situation?

We have a github workflow like this, which runs fine on my 1st diff, but when i have stacked diffs, the 2nd and 3rd ones don't run

I'm not entirely sure why, any thoughts on best way for them to run on all diffs?

Is it because I have branches: ["main"]?

.github/workflows/project.yml file

name: Project

on:
  pull_request:
    branches: ["main"]
    paths:
      - "src/project/**"
      - ".github/workflows/project.yml"
  push:
    branches: ["main"]
    paths:
      - "src/project/**"
      - ".github/workflows/project.yml"

jobs:
  verify-frontend:

Hi everyone,

I've been using spr for the last year or so and really love it so far. As an ex-Meta source control person I've always preferred the stacked diff workflow and spr is the best tool of the lot.

I've been trying out Jujutsu version control with a colocated Git repository, and that works pretty well in conjunction with spr (since jj and spr are both about amend/rebase-based workflows). But there's a little nit I ran into, which is that spr diff, spr amend etc use git commit --amend to amend commit messages. This is okay, but essentially creates a separate commit with its own identity in jj -- jj cannot link the identities of the old and new commits.

Ideally spr would be able to run jj describe @- --stdin and feed in the message over stdin, which would avoid this problem. Would it be okay to extend spr's amending logic to use jj describe if a jujutsu repository is found?

$ spr --version
spr 1.3.4
$ spr diff
  🛑  an unknown git error occurred

Anything I can do to get more information?

When I run spr diff with Reviewers: sven-of-cord I get an error saying that that's not an eligible reviewer.

Getting the list of eligible reviewers is done by the API repos/OWNER/REPO/collaborators. When I run this API on this repo, I get a list that doesn't include sven-of-cord. I only get:

[
  {
    "login": "oyamauchi",
    "id": 107014,
    "node_id": "MDQ6VXNlcjEwNzAxNA==",
    ...urls...
    "type": "User",
    "site_admin": false,
    "permissions": {
      "admin": false,
      "maintain": false,
      "push": true,
      "triage": true,
      "pull": true
    },
    "role_name": "write"
  },
  {
    "login": "flooey",
    "id": 215991,
    "node_id": "MDQ6VXNlcjIxNTk5MQ==",
    ...urls...
    "type": "User",
    "site_admin": false,
    "permissions": {
      "admin": true,
      "maintain": true,
      "push": true,
      "triage": true,
      "pull": true
    },
    "role_name": "admin"
  },
  {
    "login": "jacksongabbard",
    "id": 544550,
    "node_id": "MDQ6VXNlcjU0NDU1MA==",
    ...urls...
    "type": "User",
    "site_admin": false,
    "permissions": {
      "admin": true,
      "maintain": true,
      "push": true,
      "triage": true,
      "pull": true
    },
    "role_name": "admin"
  }
]

I'm not sure why this is happening, but I suspect it's a permissions issue, because I'm an outside collaborator, not a member of the organization?

@joneshf reported this in #61

• Not entirely sure what this maps to in arc, maybe arc close-revision?

After Github's recent security update, changing the base branch will dismiss the approval of reviewers. Is there any way to avoid this?

https://github.blog/changelog/2023-06-06-security-enhancements-to-required-approvals-on-pull-requests/

Trying spr in a project with a protected main branch that requires PRs results in spr land failing.

Any thoughts on how to circumvent this restriction?

👋 Hello!

A couple of times this week we have had issues where we run spr diff to update an existing PR (opened with spr), and although in the command line it seems like everything was ok, no changes occur on Github.

In both cases the PR in question was in draft state, so maybe that is relevant.

This is the output on the terminal on each occasion, in case that helps:

  monorepo git:(master) spr diff -m "update"
11a3da0 Deleted message state
  #️⃣   Pull Request #4423: https://github.com/getcord/monorepo/pull/4423
  ⚠️  The Pull Request's title/message differ from the local commit's message.
     Use `spr diff --update-message` to overwrite the title and message on GitHub with the local message, or `spr amend` to go the other way
     (rewrite the local commit message with what is on GitHub).
  🔁  Commit was changed - updating Pull Request #4423

f91ba54 Implementation on test bed
  #️⃣   Pull Request #4422: https://github.com/getcord/monorepo/pull/4422
  ⚾  Commit was rebased - updating Pull Request #4422

The guide in https://getcord.github.io/spr/user/patch.html describes what happens if you want to edit someone else's PR, but it doesn't say how the other person should get the new changes. Have I missed that somewhere in the docs?

Thanks!

Every time I add Reviewers: section to my commit message I get an error like
🛑 Reviewers field contains unknown user/team 'topolskib'
where github.com/topolskib is a valid username.

This is on a repository within an organization, so maybe some permission is missing on the token?

Teammates told me they can't check out my unapproved stacked diffs. Say I have stacked diffs: diff1 -> diff2 -> diff3 -> diff4, and none of them are approved yet. What's the best way someone can check out all these changes so they can play with HEAD pointing to diff4, and having all changes including diff1, diff2, diff3?

Hi 👋 😄

I found myself with a large PR and wanted to give spr a try to see if I could make it easier to manage it and give my colleagues a better experience in review.

I followed the getting started guide and added a simple commit on the main branch of my pre-existing project (with lots of pre-existing commits). When I then ran spr diff a GitHub PR was created 👍 but the commit looks like this:

If I run git log locally I can see the actual commit message I was expecting.

I feel this is a problem for me, as I don't want to force the spr workflow onto anyone in my team and in case they would merge this PR it would get merged with the wrong commit message.

Is this expected behavior?

Hello maintainers,

I wanted to bring to your attention that there's a naming conflict for the formula between these two projects:

• getcord/spr
• ejoffe/spr

I use both of these projects and have experienced conflicts when attempting to install them together. I understand that naming can be tricky, but it would be greatly appreciated if one of the projects could consider renaming their formula to avoid this issue. This would greatly enhance the user experience for those of us utilizing both tools.

Thank you for your understanding and consideration. I really appreciate the hard work you've put into developing these tools.

Best regards,

Related: ejoffe/spr#352

Not having look at the source code yet, but how feasible is it in the maintainers' opinions to extend SPR to include support for Gitlab?

i tried rebasing and now spr diff doesnt work, it keeps creating a brand new PR,

could you help check where i did wrong following steps in https://getcord.github.io/spr/user/simple.html#conflicts-on-landing?

• git checkout origin/main
• touch code.py
• add and stage code.py, then git commit -m "changes"
• spr diff, PR is created, branch origin/spr/opqpop/dracuieasy-split-solid-liquid-investments is created (0501d416)
• wait 2 days
• PR is accepted, now i have to land but master has moved too much and i need to rebase

1. git checkout origin/spr/opqpop/dracuieasy-split-solid-liquid-investments
2. git rebase origin/main
3. now the rebase replays it with new commit hashes and the branch name is no longer there, believe this is expected (see a5435a3e)
4. normally if i wasnt using spr, i'd force push my PR, but instructions say to run spr diff again after rebasing to update the PR
5. i do that and it ends up creating a new PR w/ the name origin/spr/opqpop/-initial-version instead

am i missing something in step 4? Do I need to do something after rebasing before calling spr diff again, or did I mess up the rebase command in step 2?

instructions say to rebase but doesnt say how so I wasnt sure

Rebase your PR onto latest upstream main, resolving conflicts in the process.
Run spr diff to update the PR

I think it would be pretty useful to have a --dry-run option for most of the commands. I dunno that init or list need one, since they don't affect GitHub. There's two reasons why I think this option would be useful:

1. As a person using spr, it's not always clear what it's going to do before it does it. It'd be nice to know what the game plan is before it executes it.
2. As a person developing spr, it's not easy to test the behavior of commands. Most everything sends off actual requests to GitHub or updates the local repo, so writing a test for some changes is next to impossible. If each command wasn't always going to affect the real world, it would be easier to get some amount of confidence (not complete confidence) that the behavior of a command is what is expected.

The first reason is probably more easily understandable than the second. But, I think being able to have a suite of tests that validate a game plan could be really beneficial. Any thoughts on the idea?

Hi, I've noticed one edge case (or at least behavior that I think should be different):

1. spr diff
2. convert PR to draft from GitHub UI
3. git amend
4. spr diff

In this case, I've got a new PR created. Should the already existing draft PR be re-used?

@joneshf reported this in #61

• In fact, it will remove the GPG signature when it does whatever changes it does to update the commit.

Heya! Just found out about spr, and I'm very intrigued! I've never used arc so I have no experience there. I've been interested in it for a while, but too lazy to set up Phabricator to actually try it out. So spr being arc inspired is great! It's way easier to get started with and see if this workflow makes sense. I'm really excited to see where spr ends up.

Gave it a try and ran into some issues. I'm going to dump them all in this issue just for the sake of not opening a bunch of different issues as my first interaction. Let me know if you'd prefer a different place to track these issues or separate issues. In any case, these are the things I ran into:

• There are lots of requirements to build
  • Needs libiconv, libgit2, openssl, Apple's Security framework (probably comes from xcode tools or something).
  • Doesn't seem to matter if it's with cargo install spr or building from source.
• Prebuilt macOS binary requires openssl.
  • Again, might come from xcode tools or something.
• spr diff requires a Test Plan: section
  • This isn't really explained.
  • Have to guess one what the format is.
  • It'd be nice to specify what is actually required and allow different sections.
  • Some projects don't have a "Test Plan" section, but might have a "QA" section or a "Testing steps" or whatever else. Some might have multiple sections that are required.
  • Might be nice to somehow interact with PR templates (since this is a GitHub-specific tool).
• spr land requires an approved review.
  • Not all repos require this.
  • Doesn't work for a single person working in a repo.
  • Admirable goal, but reality is that it needs to be a bit more flexible.
• #117
  • Uses the --no-write-fetch-head option which was only introduced in 2.29.0.
• spr diff requires additional scopes to update PRs.
  • It says it only needs repo and user scopes in the README.
  • If you only have the repo and user scopes, it'll error with:

      🛑  <query>:30:15: Your token has not been granted the required scopes to execute this query. The 'slug' field
    requires one of the following scopes: ['read:org', 'read:discussion'], but your token has only been granted
    the: ['repo', 'user'] scopes. Please modify your token's scopes at: https://github.com/settings/tokens.
    

• spr diff says "Message (leave empty to abort):" and that doesn't work.
• #64
  • In fact, it will remove the GPG signature when it does whatever changes it does to update the commit.
• Sections don't work as git trailers.
  • Might be intentional that they're not supposed to be trailers, but they basically look/feel like trailers.
  • Maybe this is some ad-hoc format that spr is introducing? If so, it would be nice to call out that they're explicitly not git trailers.
  • First reason is because they have spaces in them.
  • Second reason is because they aren't all at the end.
• #63
  • Not entirely sure what this maps to in arc, maybe arc close-revision?

This has just started happening 2-3 days ago and I'm not sure why. Is it possible it has to do with the recent commits that happened since 3 days ago? Pinging the authors too in case it might be related (#159 cc @andrewhamon, #153 cc @cadolphs, #162 cc @spacedentist)

Repro:

1. git checkout -b branch
2. make change, git commit (hash: 123)
3. spr diff, PR is created
4. have someone stamp it
5. go to main and get latest changes to prepare for rebase: git checkout origin/main; git pull origin main --rebase
6. cherry-pick the commit to land git cherry-pick 123
7. spr diff -m "rebase"
8. spr land, get below error

> spr land                                          
847b2ea [drac] fix up add wallet (1/n)
  #️⃣   Pull Request #1789
  🛫  Getting started...
  ❌  GitHub Pull Request merge failed
  🛑  GitHub: At least 1 approving review is required by reviewers with write access.
      Documentation URL: https://docs.github.com/articles/about-protected-branches

Let me know if there's anything else I can help with

"The Pull Request's title/message differ from the local commit's message."

I'm not sure why I'm getting this and the interface how to resolve this is also not very clear. I'm passing the --update-message flag but that still asks me to provide a message (why?).

It would be wonderful for SPR to by default record in PR descriptions, which PR does the current PR depend upon.

As a concrete example, if I create multiple PRs of A then B, it would be great if the pull request description for B mentioned that the changes in that PR where dependent upon the changes in the other PR.

Hopefully this is clear. Thank you for building this amazing tool, it's super great!

when a PR that is higher up on the stack is accepted, and then re-ordered so that it can be landed, complains about not being accepted. (this only happens for people who do not have permission to override the peer review requirements)

steps to reproduce:

1. create commit A
2. create commit B -- NOTE: these are independent commits
3. spr diff --all
4. accept Commit/PR B
5. re-order local main so that B is below A
6. spr land commit B
7. get error stating that PR has not been accepted

seems to be similar if not the same issue as #163 (comment), but I thought I should put up my own issue in case they were different.

From #61

• Uses the --no-write-fetch-head option which was only introduced in 2.29.0.

And later in the issue from @sven-of-cord:

• we could query what version of git is installed, and not include the --no-write-fetch-head if it's not available. That means spr might overwrite your FETCH_HEAD file if you're on an older version of git, but that's probably better than not working at all.

Hi,

For some reason when I run spr land on an accepted and CI passed PR, it would re-trigger the CI and would tell me that

  ❌  GitHub Pull Request merge failed
  🛑  GitHub: 11 of 11 required status checks have not succeeded: 10 expected and 1 pending.

And after I wait for that 11 checks finish and run spr land again, it would happen again ... as a result i wouldn't be able to merge the PR with the tool. Is this a known issue?

One possibility is I did re-arrange (via rebase) the stack after run spr diff on some PRs. Is that what messing up with spr?

Thanks

I was able to spr init just fine for my repo. However, when I run spr diff from a git worktree, I get this error:

  🛑  object not found - no match for id (aa1d3cfa12a67a60408240eecdb08d4a3a64460a); class=Odb (9); code=NotFound (-3)

Do worktrees confuse spr? Thanks!

spr looks really cool and I really want to use it!

Hello! First of all thanks for the wonderful tool.

I frequently have the workflow where I make an initial commit and then want to update the set of reviewers later. I'd love to be able to do this via the commit message just like I can do on the initial commit. I prefer using the commit message as the source of the truth rather than the GitHub UI

However after the initial commit it appears that the Reviewers: field is ignored. Another indication of this is that if you edit the Reviewers field only and run spr diff --update-message it says there is no update necessary.

If this is deliberate decision, no worries and feel free to close.

See a test PR: dagster-io/dagster#10751

I'm just giving spr a try, and don't want to use test plans in my commit messages. I've tried to change the configuration settings but it seems to be blocking my commit anyway:

❯ spr --version
spr 1.3.3

❯ tail .git/config 
[spr]
        githubAuthToken = .....
        githubRemoteName = origin
        githubRepository = powerxai/application-v3
        githubMasterBranch = main
        branchPrefix = spr/cjols/
        requireTestPlan = false
        requireApproval = true

❯ git config --get spr.requireTestPlan  
false

❯ spr diff --all                        
3f5c1c5 fix(alarms): Use all dimensions for Cloudwatch queue metrics
  💔  Commit message does not have a Test Plan!

Am I missing something?

I wanted to try this tool, but it seems it doesn't work in my work repo (it works in other repos I've tried). How can I debug this?

spr init 
  👋  Welcome to spr!
  🛑  Could not open a Git repository in "xxx". Please run 'spr' from within a Git
      repository.

macOS 13.3.1
spr 1.3.4

My team is looking at spr as an arcanist replacement. My teammates have gotten used to arc lint to run linters locally and the fact that arc diff automatically runs arc lint before sending out the diff.

I was wondering if:

• There are any plans to add a similar behaving spr lint command?
• Would you be willing to accept PRs that add spr lint and hook it to spr diff?