Comments (3)
OK. Reading the source code, I figured it out.
I had to pass a command like: spr diff --message Rebase --update-message --all
If you pass --update-message
, you also need to pass a --message
which will then show up in the PR as an intermediate 'change' to show what you did.
Could we document this? Also if after a rebase I want to just update my PRs, could it be possible to do this doing just spreading diff --all
?
from spr.
You should only get prompted for a message if there are actual changes in your local commit. (That could also be that you rebased your commit in the meantime.)
If the commit contents didn't change at all and you didn't rebase, then spr diff --update-message
shouldn't prompt for a message.
I am aware of a problem that even after using --update-message
, the next run of spr diff
will show the "messages differ" warning again. I think it's just a whitespace difference (maybe GitHub adds or removes a newline at the end or something). I'll have to fix that...
from spr.
Any update w/ this? Currently been trying SPR out this week and this has been one of my two major pain points. Seems that even if I run the following I'll still get a title/message diff warning.
$ spr diff --all (gives warning for all current outstanding diffs)
$ spr amend --all (force local to match what GitHub has)
$ spr diff --all (gives warning still for all current outstanding diffs)
from spr.
Related Issues (20)
- Multiple stacks of work? HOT 1
- [question] Any way to support squash merging PR in GitHub UI and then update locally?
- [feature request] Show stack in PR
- [Critical Bug] Error when updating an existing PR HOT 4
- spr list (and land) PR statuses are always PENDING HOT 1
- Formula Name Conflict Between Two Projects
- Maintenance status HOT 1
- spr diff uses jujutsu to amend? HOT 4
- Changing Base Branche Dismisses the Reviewers' Approval
- `an unknown git error occurred; code=NotFound (-3)` HOT 1
- Please update the ring crate to 17.x
- Support specification of branch name in `spr diff` HOT 1
- Remove "Reviewers:" for `spr land` HOT 2
- Support for Bitbucket and others?
- invalid data in index - calculated checksum does not match expected; class=Index (10) HOT 1
- Use spr and bors together HOT 2
- Spr doesn't recognize existing commits/PRs
- feat(cli): support `githubMasterBranch` from CLI
- [docs] Need clarification on how to insert a commit into the middle of an ongoing stacked PR review
- Documentation Webpage returning 404 from Github Pages HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spr.