[CIT] Support for 1.20.5 Item Components about optifine HOT 11 OPEN

Leave it to mojang to release major breaking changes in a minor release, lol

from optifine.

Json is definitely a very harsh transition but it does fit with vanilla resourcepacks formats pretty well.

Another approach to that issue is using what's being done in the language file format conventions, where the namespace and path are separated by a dot, for example

component.minecraft.custom_name=Example
# or, alternatively, since minecraft is the defaulted namespace, whenever a namespace is not present
component.custom_name=Example

from optifine.

having : in a key value may not be good for property reading code

from optifine.

having : in a key value may not be good for property reading code

how would you work around that? split it into multiple properties?

namespace=minecraft
component.custom_name=Example

from optifine.

Use JSON? Not the easiest solution to move to, but would work...

from optifine.

Something else to be considered while making major/breaking changes is that components can be of any type and only then are serialized into nbt. There have been reports of item components slowing down the game(specifically talking about MC-270668). Might be the time to handle components directly instead of their nbt representation.

It'd be a shame to serialize a Text object to nbt just to check it against the old cit matching.

from optifine.

note that the .properties spec officially supports key escapes like the following:

component.minecraft\:custom_name=Example

also, we should probably be using components instead of component to fit with the NBT-ified data format.

from optifine.

any progress?

from optifine.

the first preview version of OptiFine for 1.20.6 just came out, so it may be a little while before this gets added

from optifine.

Some news? What solution is there to this right now to be able to continue using CIT in 1.20.6?

from optifine.

I have also noticed that when using component.custom_name=Example all the items related to it change texture, regardless of the name

from optifine.