Git Product home page Git Product logo

Comments (16)

sp614x avatar sp614x commented on September 15, 2024 1

Fixed, coming in next 1.21 preview

from optifine.

SeaOfPixels avatar SeaOfPixels commented on September 15, 2024

Can confirm, colormaps are currently incorrect.
2024-06-08_14 39 31

from optifine.

SnobbyBlobby avatar SnobbyBlobby commented on September 15, 2024

Can also confirm :
t1
t2

Also randomizes everytime I close the game.

from optifine.

Pineapple71717 avatar Pineapple71717 commented on September 15, 2024

While it does randomize the colormaps, atleast on my end they dont seem to change every time I re-launch the game
2024-06-15_18 44 53
2024-06-15_18 40 55
2024-06-15_18 37 44
2024-06-15_18 33 23
2024-06-15_18 32 05
2024-06-15_18 31 20
jlkhjghsdgb

from optifine.

SeaOfPixels avatar SeaOfPixels commented on September 15, 2024

It's not that the colormaps are randomizing, it's that the gridmap IDs are incorrect. This happens all the time during OptiFine development when updating to new whole number versions.

from optifine.

Emfire12345 avatar Emfire12345 commented on September 15, 2024

It's not that the colormaps are randomizing, it's that the gridmap IDs are incorrect. This happens all the time during OptiFine development when updating to new whole number versions.

In the last few version that happend because they added new biomes which offset the IDs, 1.21 didnt add a single new biome and the IDs are not shifted, they are shuffled all over the place, if the plains biome gets the wrong color you know something is messed up badly.

from optifine.

SeaOfPixels avatar SeaOfPixels commented on September 15, 2024

It's not that the colormaps are randomizing, it's that the gridmap IDs are incorrect. This happens all the time during OptiFine development when updating to new whole number versions.

In the last few version that happend because they added new biomes which offset the IDs, 1.21 didnt add a single new biome and the IDs are not shifted, they are shuffled all over the place, if the plains biome gets the wrong color you know something is messed up badly.

No, this has happened multiple times before in update transitions that had no new biomes or changes to the IDs.

from optifine.

SyndiShanX avatar SyndiShanX commented on September 15, 2024

It would be nice if we could specify the columns using the Biome Namespace ID in the .properties file

from optifine.

Emfire12345 avatar Emfire12345 commented on September 15, 2024

It would be nice if we could specify the columns using the Biome Namespace ID in the .properties file

I wish we could have 256x256 colormaps for each biome, were 1 pixel = 1 block, similar to how colormaps were applied pre beta 1.8, then you could literally paint the landscape

from optifine.

SeaOfPixels avatar SeaOfPixels commented on September 15, 2024

I think the current method would be fine if gridmaps didn't keep extending past the farthest vanilla ID (End Barrens) into the unused IDs. This currently breaks grid colormap compatibility with mods that use unused biome IDs for their modded biomes. The gridmaps should only apply the columns that are actually used by vanilla (currently that's ID 0 to 63, so ID 64 onward would ignore gridmaps).

from optifine.

SyndiShanX avatar SyndiShanX commented on September 15, 2024

But mod compatibility is something we want

from optifine.

SeaOfPixels avatar SeaOfPixels commented on September 15, 2024

The current method breaks when multiple sources (datapacks/mods) use the same biome IDs anyways, which is very likely to happen.

from optifine.

SyndiShanX avatar SyndiShanX commented on September 15, 2024

Namespace IDs would fix that

from optifine.

SeaOfPixels avatar SeaOfPixels commented on September 15, 2024

Ye just doing everything in a file would be best, however I think that's way less likely to happen since it'd be way more work for SP, so I tried suggesting something that I thought would be less taxing.

from optifine.

Baby-FarkMcGeezax avatar Baby-FarkMcGeezax commented on September 15, 2024

Besides the randomising (which is weird), grass colormaps don't seem to work AT ALL for me. Only displaying the vanilla colours, while water and fog and all is still recoloured (randomly).
Could be related to #7259 and/or #7699 ?

from optifine.

SeaOfPixels avatar SeaOfPixels commented on September 15, 2024

Can confirm in OptiFine 1.21_HD_U_J1_pre6.

from optifine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.