smp4903 / fivesecondrule Goto Github PK

Using mp5 food or mana spring totem keeps resetting the regen ticks making it way harder to tell when your main spirit ticks are coming. mp5 on gear doesn't seem to have the same problem

Just documenting this real quick while I'm here

Hi, great addon but mine dont work as expected. No matter if i check or uncheck "Always show mana ticks" it keeps showing the ticks until my mana bar is full.

Not many settings to try in the Interface options, is there any other way to fix this?

Restarting game, or /reload dont help.

Just noticed that if you download using ZIP, you will get a folder called FiveSecondRule-master, which if you simply drag into your addons folder will not be recognized. Perhaps it would be useful to add a note in the readme telling people to remove the branch name, -master, if they get the addon in this way.

I figured a video would be the easiest way to show replication.

Problem:
if you use anything that restores mana (e.g. water, mana gems, evocation, etc) somewhere in the middle of mana ticks, FSR will keep counting down into the negatives.
The only workaround i've found is to either reach full mana or stop and drink properly.

This is an issue if you attempt drink running and time the drink too early.
(drinking just before a tick will restore mana as if drinking)
I'm not exactly sure what the threshold is to cause this bug, but it's somewhere between the middle to end.

https://www.youtube.com/watch?v=DAwJOgxtkkA

  if msg == "reset" then
        print("Five Second Rule - RESET SIZE AND POSITION.");
        lock()     
 end

you should call reset() there

Whenever I press "unlock" in the settings menu, the bar disappears.
I wont let me move the tick bar. Any idea about this?
Version 1.4

You might want to update the readme to include information about renaming the file from wow-classic-five-second-rule to FiveSecondRule

I download to use in Hardcore servers, but with the new retail interface in classic wow the FSR is not list as addon, then you cant move the bar or set it.

when i enabled any addon, the addon list show up but FSR still dont list it.

Even typing /fsr just options tab pop up

In the latest update you added a white spark to mana ticks and the five second rule. I use the addon at 117 width and 1 height so that it fits perfectly underneath my mana bar without being too much of an eye sore. My problem is that the spark doesn't scale to the height and it is quite unsightly to look at. I love the addon and really want to continue using it, so if you could add an option to disable the spark that would be amazing <3

Hi,

I have a lua error on version 1.15.3
addon version 1.15.3

here is the message:

Message: ...ace/AddOns/FiveSecondRule/Dependencies/UIFactory.lua:22: bad argument #1 to 'SetJustifyV' (Usage: self:SetJustifyV(justifyV))
Time: Fri Jul 19 14:20:20 2024
Count: 1
Stack: ...ace/AddOns/FiveSecondRule/Dependencies/UIFactory.lua:22: bad argument #1 to 'SetJustifyV' (Usage: self:SetJustifyV(justifyV))
[string "@Interface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua"]:196: in function `CreateGUI'
[string "@Interface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua"]:20: in function <...rface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua:17>

Locals: self = FiveSecondRuleOptionsPanelFrame {
UpdateOptionValues = defined @Interface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua:29
0 =
CreateGUI = defined @Interface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua:64
}
name = "FiveSecondRule"
parent = nil
frame = Frame {
0 =
content = CADOptionsContent {
}
name = "FiveSecondRule"
title = FiveSecondRuleTitle {
}
}
ADDON_NAME = "FiveSecondRule"
OptionsPanelFrame = FiveSecondRuleOptionsPanelFrame {
UpdateOptionValues = defined @Interface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua:29
0 =
CreateGUI = defined @Interface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua:64
}
colorPickerStateSet = false

Im constantly wondering if if get off the drink tick, and how much more mana it gives me.

It would be awesome if this addon had a scrolling text on the left side of the bar that scrolled up showing your last mana gain from your previous tick....

Love the addon but not a fan of this feature... it looks like deleting line 198 might fix this but can anyone confirm that's okay to do

addon added but not working.

Would it be possible to add an option to disable the 5 second rule and only show mana ticks?

It would also be a nice feature if the mana ticks would keep ticking even when full mana. I understand that over time the ticker might go out of sync, but in some circumstances seeing the tick would be useful information even when full mana.

Hey man~ Love ur addon

'return FiveSecondRule' in line 177 of FiveSecondRule.lua causes a fetal error

change it to 'do return end'
I know it's ur code below, LOL

I believe the wrong event or condition is being used to show the start text. If I zone in (e.g. zeppelin) it shows the start text again.

Loving this addon so far with the addition of the mana ticks. The current way of viewing the mana ticks is however not very nice, as the countdown bar appears directly below the players mana bar and is quite small and easily missed.

Could a separate bar be created in the same location as the 5 second timer, so that it appears once the 5 second timer finishes and disappears. So when the 5 second timer disappears a new bar should appear with the countdown of the next mana tick, and maybe it would be best to change the bar flow from left to right (filling up) to differentiate it easily from the 5 second timer.
The new bar should then also disappear once the player reaches 100% mana or the 5 second rule timer is activated again.

I know it might be a lot more work than adding a small countdown line below the mana bar, but it would make it so much better usability wise.

I'm getting this lua error on the classic era client. I'm not sure if it's because of the recent client update or addon update. I've tried deleted the addon and reinstalling, but the same error still pops.

Message: ...ace/AddOns/FiveSecondRule/Dependencies/UIFactory.lua:22: bad argument #1 to 'SetJustifyV' (Usage: self:SetJustifyV(justifyV))
Time: Sat Jul 13 11:40:05 2024
Count: 1
Stack: ...ace/AddOns/FiveSecondRule/Dependencies/UIFactory.lua:22: bad argument #1 to 'SetJustifyV' (Usage: self:SetJustifyV(justifyV))
[string "=[C]"]: in function SetJustifyV' [string "@Interface/AddOns/FiveSecondRule/Dependencies/UIFactory.lua"]:22: in function MakeText'
[string "@Interface/AddOns/FiveSecondRule/Dependencies/UIFactory.lua"]:30: in function MakeEditBox' [string "@Interface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua"]:196: in function CreateGUI'
[string "@Interface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua"]:20: in function <...rface/AddOns/FiveSecondRule/Modules/OptionsPanel.lua:17>

Locals: (*temporary) = FontString {
0 =
}
(*temporary) = "CENTER"

When trying to access the options from /fsr, this lua error pops up:

Message: ...face/AddOns/FiveSecondRule/Modules/SlashCommands.lua:35: attempt to call method 'PrintHelp' (a nil value)
Time: Sat Jul 13 11:41:50 2024
Count: 1
Stack: ...face/AddOns/FiveSecondRule/Modules/SlashCommands.lua:35: attempt to call method 'PrintHelp' (a nil value)
[string "@Interface/AddOns/FiveSecondRule/Modules/SlashCommands.lua"]:35: in function ?' [string "@Interface/AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua"]:5016: in function ChatEdit_ParseText'
[string "@Interface/AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua"]:4674: in function ChatEdit_SendText' [string "@Interface/AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua"]:4710: in function ChatEdit_OnEnterPressed'
[string "*ChatFrame.xml:120_OnEnterPressed"]:1: in function <[string "*ChatFrame.xml:120_OnEnterPressed"]:1>

Locals: msg = ""
editbox = ChatFrame1EditBox {
0 =
headerSuffix = ChatFrame1EditBoxHeaderSuffix {
}
tabCompleteTableIndex = 1
chatLanguage = "Common"
text = "/"
setText = 0
customAutoCompleteFunction = defined @Interface/AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua:4199
autoCompleteParams =

I am playing SoD.

My FSR addon keeps getting disabled. Every time I login, I have to go to my addon list and re-enable it. All of my other addons remain enabled. Not sure if this is an issue with the addon or something else with my WoW., but I figured that I would post here.

... and output it in the logs at the end of the combat.

I get 100 error every second since the last update.

rolling back to release 1-8 then everything works but with changes made on the 11th October i get the above error.

I was drowning and regenerating mana, then I realized the bar is still going..

Would it be possible to allow us to change the default bar texture to something else to match our current UI setups?