Git Product home page Git Product logo

Comments (2)

TheBlueMatt avatar TheBlueMatt commented on May 23, 2024

Cant reproduce on master, can you double-check and/or fix?

from signal-desktop.

liliakai avatar liliakai commented on May 23, 2024

definitely an issue with jsonifying undefined registration ids. i can only send messages if i delete them. will dig in a little more later tonight.

diff --git a/js/helpers.js b/js/helpers.js
index 18c4aca..ce98442 100644
--- a/js/helpers.js
+++ b/js/helpers.js
@@ -480,8 +480,7 @@ function getKeysForNumber(number) {
                 encodedNumber: number + "." + response[i].deviceId,
                 identityKey: response[i].identityKey,
                 publicKey: response[i].publicKey,
-                preKeyId: response[i].keyId,
-                registrationId: response[i].registrationId
+                preKeyId: response[i].keyId
             });
         }
         return response[0].identityKey;
@@ -500,7 +499,6 @@ function sendMessageToDevices(number, deviceObjectList, message, success_callbac
             jsonData[i] = {
                 type: encryptedMsg.type,
                 destination: deviceObjectList[i].encodedNumber,
-                destinationRegistrationId: deviceObjectList[i].registrationId,
                 body: encryptedMsg.body,
                 timestamp: new Date().getTime()
             };

from signal-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.