Git Product home page Git Product logo

Comments (4)

indutny-signal avatar indutny-signal commented on July 19, 2024

Sorry about this. Could you provide full build logs? The top part looks successful, but there are quite a lot of important bits after that. Thanks!

from signal-desktop.

ting-yun-career avatar ting-yun-career commented on July 19, 2024
[build:release     ] Copying en.lproj to af_ZA.lproj
[build:release     ] Copying en.lproj to az_AZ.lproj
[build:release     ] Copying en.lproj to bg_BG.lproj
[build:release     ] Copying en.lproj to bn_BD.lproj
[build:release     ] Copying en.lproj to bs_BA.lproj
[build:release     ] Copying en.lproj to et_EE.lproj
[build:release     ] Copying en.lproj to eu.lproj
[build:release     ] Copying en.lproj to fa_IR.lproj
[build:release     ] Copying en.lproj to ga_IE.lproj
[build:release     ] Copying en.lproj to gl_ES.lproj
[build:release     ] Copying en.lproj to gu_IN.lproj
[build:release     ] Copying en.lproj to hi_IN.lproj
[build:release     ] Copying en.lproj to hr_HR.lproj
[build:release     ] Copying en.lproj to ka_GE.lproj
[build:release     ] Copying en.lproj to kk_KZ.lproj
[build:release     ] Copying en.lproj to km_KH.lproj
[build:release     ] Copying en.lproj to kn_IN.lproj
[build:release     ] Copying en.lproj to ky_KG.lproj
[build:release     ] Copying en.lproj to lt_LT.lproj
[build:release     ] Copying en.lproj to lv_LV.lproj
[build:release     ] Copying en.lproj to mk_MK.lproj
[build:release     ] Copying en.lproj to ml_IN.lproj
[build:release     ] Copying en.lproj to mr_IN.lproj
[build:release     ] Copying en.lproj to my.lproj
[build:release     ] Copying en.lproj to pa_IN.lproj
[build:release     ] Copying en.lproj to ro_RO.lproj
[build:release     ] Copying en.lproj to sk_SK.lproj
[build:release     ] Copying en.lproj to sl_SI.lproj
[build:release     ] Copying en.lproj to sq_AL.lproj
[build:release     ] Copying en.lproj to ta_IN.lproj
[build:release     ] Copying en.lproj to te_IN.lproj
[build:release     ] Copying en.lproj to tl_PH.lproj
[build:release     ] Copying en.lproj to ug.lproj
[build:release     ] Copying en.lproj to uk_UA.lproj
[build:release     ] Copying en.lproj to yue.lproj
[build:release     ] Copying en.lproj to zh_HK.lproj
[build:release     ] Copying en.lproj to zh_Hant.lproj
[build:release     ]   • skipped macOS application code signing  reason=, see https://electron.build/code-signing CSC_IDENTITY_AUTO_DISCOVERY=false
[build:release     ] Notarizing with...
[build:release     ]   primaryBundleId: org.whispersystems.signal-desktop
[build:release     ]   username: [email protected]
[build:release     ]   file: /Users/admin/Desktop/SignalStuff/Signal-Desktop/release/mac/Signal.app
[build:release     ]   ⨯ Failed to staple your application with code: 66
[build:release     ] 
[build:release     ] Processing: /Users/admin/Desktop/SignalStuff/Signal-Desktop/release/mac/Signal.app
[build:release     ] Properties are {
[build:release     ]     NSURLIsDirectoryKey = 1;
[build:release     ]     NSURLIsPackageKey = 1;
[build:release     ]     NSURLIsSymbolicLinkKey = 0;
[build:release     ]     NSURLLocalizedTypeDescriptionKey = Application;
[build:release     ]     NSURLTypeIdentifierKey = "com.apple.application-bundle";
[build:release     ]     "_NSURLIsApplicationKey" = 1;
[build:release     ] }
[build:release     ] Props are {
[build:release     ] }
[build:release     ] Cannot download ticket. CDHash must be set.
[build:release     ]   failedTask=build stackTrace=Error: Failed to staple your application with code: 66
[build:release     ]                                                                                                                                                                                                                                                                                                                                                                                                                                                                     Processing: /Users/admin/Desktop/SignalStuff/Signal-Desktop/release/mac/Signal.app
[build:release     ] Properties are {
[build:release     ]     NSURLIsDirectoryKey = 1;
[build:release     ]     NSURLIsPackageKey = 1;
[build:release     ]     NSURLIsSymbolicLinkKey = 0;
[build:release     ]     NSURLLocalizedTypeDescriptionKey = Application;
[build:release     ]     NSURLTypeIdentifierKey = "com.apple.application-bundle";
[build:release     ]     "_NSURLIsApplicationKey" = 1;
[build:release     ] }
[build:release     ] Props are {
[build:release     ] }
[build:release     ] Cannot download ticket. CDHash must be set.
[build:release     ]                                                                                                                                                                                                                                                                                                                                                                                                                                                                         at /Users/admin/Desktop/SignalStuff/Signal-Desktop/node_modules/@electron/notarize/lib/staple.js:50:19
[build:release     ]     at Generator.next (<anonymous>)
[build:release     ]     at fulfilled (/Users/admin/Desktop/SignalStuff/Signal-Desktop/node_modules/@electron/notarize/lib/staple.js:28:58)
[build:release     ]     at processTicksAndRejections (node:internal/process/task_queues:95:5)
[build:release     ] error Command failed with exit code 1.
[build:release     ] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:release     ] error Command failed with exit code 1.
[build:release     ] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "build:release" exited with 1.
error Command failed with exit code 1.

Here you go ^

from signal-desktop.

ting-yun-career avatar ting-yun-career commented on July 19, 2024

I have another hello world electron app with electron-builder included. In that project, I can see built artifacts after calling electron-builder. That project is using the same electron and electron-builder version as ^. There is something specific about Signal-Desktop that is blocking the electron-builder from generating artifacts.

This works:

{
  "name": "my-app",
  "appName": "My First App",
  "version": "1.0.6",
  "description": "",
  "main": "main.js",
  "scripts": {
    "start": "electron .",
    "build": "electron-builder"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "electron": "29.1.5",
    "electron-builder": "24.6.3"
  },
  "build": {
    "appId": "electron-builder-test",
    "mac": {
      "target": [
        {
          "target": "zip",
          "arch": [
            "x64",
            "arm64"
          ]
        },
        {
          "target": "dmg",
          "arch": [
            "x64",
            "arm64",
            "universal"
          ]
        }
      ]
    }
  },
  "dependencies": {}
}

This is the output:

helloword output

from signal-desktop.

scottnonnenberg-signal avatar scottnonnenberg-signal commented on July 19, 2024

This line means that you will not be able to notarize:

[build:release     ]   • skipped macOS application code signing  reason=, see https://electron.build/code-signing CSC_IDENTITY_AUTO_DISCOVERY=false

To make a packaged version of the app, either you disable all signing and notarization, or you get a Developer ID Application certificate from Apple and fully sign and notarize.

I'm going to close this.

from signal-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.