Git Product home page Git Product logo

Comments (18)

palant avatar palant commented on July 2, 2024 3

For what it’s worth, this is unrelated to flatpak. If I run the signal-desktop binary directly, it runs outside of the flatpak sandbox but is still unable to save files – dialog opens but clicking “Save” doesn’t actually save the file. Signal 7.13.0 on Fedora 40 (KDE, Wayland).

Thanks for the reports. 7.11 introduced a new Electron version (v30), which is possibly related. I've created an Electron Fiddle gist here: https://gist.github.com/trevor-signal/95c543c5e7cd398c6957c78b5cc9fe94. I'd love to know if the save dialog opens on:

* Electron 30.0.9 (current)

* Electron 29.1.5 (used by Signal 7.10)

* Electron 31.0.1

Thanks for your help!

@trevor-signal I’ve slightly modified your fiddle to actually display the file path returned by showSaveDialog(). The affected Electron versions always return an empty path, that’s the issue here. Versions I tested:

  • Electron 29.1.5: not affected
  • Electron 30.0.2: not affected
  • Electron 30.0.3: not affected
  • Electron 30.0.4: affected
  • Electron 30.0.5: affected
  • Electron 30.0.9: affected
  • Electron 30.1.2: affected
  • Electron 31.0.1: affected
  • Electron 31.0.2: affected

In affected versions, the dialog looks considerably different. Given that and the regression range, it’s a safe bet that this regression was caused by electron#42110.

from signal-desktop.

palant avatar palant commented on July 2, 2024 3

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

from signal-desktop.

HITMAnsOFT avatar HITMAnsOFT commented on July 2, 2024 2

Same issue on Kubuntu 22.04.4 LTS, Signal 7.12.0, both Snap and official deb packages.

from signal-desktop.

arcivanov avatar arcivanov commented on July 2, 2024 2

There is no problem with the opening of the save dialog. It's just after the save dialog is closed with "Save", nothing happens.

from signal-desktop.

mrvanes avatar mrvanes commented on July 2, 2024 1

Another debug log: https://debuglogs.org/desktop/7.12.0/3c05aa67fa8f85922db87ba1cf7e02a474325806f232b17c8c3595c2da1cc9fd.gz

Maybe mentioning that I'm running Signal Desktop in a Wayland session helps?

from signal-desktop.

akutuzov avatar akutuzov commented on July 2, 2024

Same here, also Kubuntu 22.04.4 and Signal 7.12.0

from signal-desktop.

v8d avatar v8d commented on July 2, 2024

Same issue on Arch with version 7.12.0. The only way I've found to save images is to open it and drag the actual image to my file manager (which doesn't give any indication of dragging anything, but still works). This doesn't work with videos or other file types, though, because they can't be dragged.

Also when clicking the download button, this gets written to the journal, as well as to stderr if Signal is started from a terminal:

[122855:0615/153714.144870:ERROR:select_file_dialog_linux_portal.cc(760)] Portal returned error: org.freedesktop.DBus.Error.AccessDenied: Portal operation not allowed: Unable to open /proc/122855/root

from signal-desktop.

rafasaurus avatar rafasaurus commented on July 2, 2024

Same issue on Arch linux wtih version 7.12.0.

from signal-desktop.

trevor-signal avatar trevor-signal commented on July 2, 2024

Thanks for the reports. 7.11 introduced a new Electron version (v30), which is possibly related. I've created an Electron Fiddle gist here: https://gist.github.com/trevor-signal/95c543c5e7cd398c6957c78b5cc9fe94. I'd love to know if the save dialog opens on:

  • Electron 30.0.9 (current)
  • Electron 29.1.5 (used by Signal 7.10)
  • Electron 31.0.1

Thanks for your help!

from signal-desktop.

trevor-signal avatar trevor-signal commented on July 2, 2024

Others, can you share debug logs? We're having difficulty reproducing.

from signal-desktop.

arcivanov avatar arcivanov commented on July 2, 2024

Yes, I'm also on Wayland.

from signal-desktop.

rafasaurus avatar rafasaurus commented on July 2, 2024
  • 29.1.5

I have tested as you say, only in 29.1.5 opens file dialog, with 30 and 31 file dialog does not even open, I'm using xorg on Arch.

from signal-desktop.

HITMAnsOFT avatar HITMAnsOFT commented on July 2, 2024

I am running on Xorg. Fiddle opens dialog fine on all versions, but as @arcivanov said both in the description and in the comment, nothing is actually saved.

from signal-desktop.

HITMAnsOFT avatar HITMAnsOFT commented on July 2, 2024

https://debuglogs.org/desktop/7.12.0/25f7eb0913a7754d2d5d5fd6fb110a4ccdd25920a4d26c3a31d223d724507f09.gz

from signal-desktop.

would1920 avatar would1920 commented on July 2, 2024

\

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.在对此进行试验时,我找到了一种解决方法。最初,“保存文件”对话框在文件列表上方错误地显示“/”。首先单击“Home”,这将使其显示“Home”(列出的文件不会更改,但某些图标会更改)。然后您可以选择目录/文件名并保存即可。目录路径似乎存在一些问题。

It worked for me!!!

from signal-desktop.

cheazycrust avatar cheazycrust commented on July 2, 2024

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

can confirm this worked for me too!!

from signal-desktop.

arcivanov avatar arcivanov commented on July 2, 2024

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

Confirm this works for me too! Great job!

from signal-desktop.

mrvanes avatar mrvanes commented on July 2, 2024

Yes, it works. Thx!
Tiny correction to the observation: the dialog initially points to ./ (for me). Not /.

from signal-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.