Git Product home page Git Product logo

blockball's Introduction

Shynixn's github stats

blockball's People

Contributors

archeri2000 avatar dependabot-preview[bot] avatar giancarmine avatar katorly avatar lazoyoung avatar mattyway avatar rbrick avatar shynixn avatar tildearrow avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

blockball's Issues

Shooting the ball

A ball gets kicked when a player touches it, but it does not go far.
It's quite boring for this player to dribble the ball through the huge playground, isn't it?
So here's my suggestion:

  • If a ball collided with a player = the player is dribbling the ball.
    • Meantime the ball is hit by the player = he is shooting the ball.

PlaceholderApi Hook failed

New [21:25:26] [Server thread/INFO]: [0;34;1m[BlockBall] [0;37;22mfound dependency [Vault].[m
[21:25:26] [Server thread/INFO]: [0;34;1m[BlockBall] [0;32;22mhooked successfully into [Vault].[m
[21:25:26] [Server thread/INFO]: [0;34;1m[BlockBall] [0;37;22mfound dependency [PlaceholderAPI].[m
[21:25:26] [Server thread/INFO]: [0;34;1m[BlockBall] [0;32;22mhooked successfully into [PlaceholderAPI].[m
[21:25:26] [Server thread/INFO]: [0;34;1m[BlockBall] [0;31;22mFailed to register the last dependency.[m
[21:25:26] [Server thread/INFO]: [0;34;1m[BlockBall] [0;32;1mEnabled BlockBall 4.1.0 by Shynixn[m

what is the "last dependency"?

Scoreboards are not being reverted on arena exit.

BlockBall v3.8.0

When players join a game and get kicked out on end, their former scoreboard is wiped. In my case, I colorize displaynames based on permission groups so players end up with a white nametag above their head after they play a game of BlockBall. Is there any way to preserve and load the old player's scoreboard when they leave the arena?

    scoreboard:
      enabled: true
      title: §a§lBlockBall
      items:
        red: §cTeam Red
        blue: §9Team Blue
        time: §eTime

In addition, is it possible to colorize the player's nametag above their head based on the team they are a part of if the scoreboard is disabled (due to wanting to use bossbar instead)?

Commands don't work?

Commands don't work?

Spigot says these are commands:
/bbjoin - Join any game from anywhere (new v2.8.0)
/bbc - Optional command to navigate through the chat menu (servers with buggy chat) (new v1.3)
/bb - Optional command to join teams (servers with buggy chat) (new v1.3)

None of them works though, I noticed in your plugin.yml (on here) it doesn't have them listed as well

Teleport to the centre of arena after someone scores.

What I suggest is that players should be teleported to the centre after one of them scores.
Spawnpoints for red/blue team would be suitable for the centre location.
(With a configurable delay would be also good.)
Sorry if I made too many tickets in short term

No option to set a spectate location.

I can't seem to find an option to set a spectate location, only a spectate radius. Would it be possible to allow setting a spectate location so when the sign is hit while the game is in-progress, they are brought to the spectate location, then back to the leave location when the game ends?

DoubleJump error

ncurrentModificationException: null
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1437) ~[?:1.8.0_131]
at java.util.HashMap$KeyIterator.next(HashMap.java:1461) ~[?:1.8.0_131]
at com.github.shynixn.blockball.bukkit.logic.business.entity.game.LowLevelGame.close(LowLevelGame.kt:390) ~[BlockBall.jar:?]
at com.github.shynixn.blockball.bukkit.logic.business.controller.GameRepository.reload(GameRepository.kt:175) [BlockBall.jar:?]
at com.github.shynixn.blockball.bukkit.logic.business.commandexecutor.menu.MainConfigurationPage.execute(MainConfigurationPage.kt:132) [BlockBall.jar:?]
at com.github.shynixn.blockball.bukkit.logic.business.commandexecutor.NewArenaCommandExecutor.onPlayerExecuteCommand(NewArenaCommandExecutor.kt:171) [BlockBall.jar:?]
at com.github.shynixn.blockball.bukkit.logic.business.commandexecutor.SimpleCommandExecutor$Registered.onCommand(SimpleCommandExecutor.java:125) [BlockBall.jar:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) [spigot-1.12.2.jar:git-Spigot-4bd94dc-3a482bd]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) [spigot-1.12.2.jar:git-Spigot-4bd94dc-3a482bd]
at org.bukkit.craftbukkit.v1_12_R1.CraftServer.dispatchCommand(CraftServer.java:648) [spigot-1.12.2.jar:git-Spigot-4bd94dc-3a482bd]
at net.minecraft.server.v1_12_R1.PlayerConnection.handleCommand(PlayerConnection.java:1397) [spigot-1.12.2.jar:git-Spigot-4bd94dc-3a482bd]
at net.minecraft.server.v1_12_R1.PlayerConnection.a(PlayerConnection.java:1232) [spigot-1.12.2.jar:git-Spigot-4bd94dc-3a482bd]
at net.minecraft.server.v1_12_R1.PacketPlayInChat.a(PacketPlayInChat.java:45) [spigot-1.12.2.jar:git-Spigot-4bd94dc-3a482bd]
at net.minecraft.server.v1_12_R1.PacketPlayInChat.a(PacketPlayInChat.java:1) [spigot-1.12.2.jar:git-Spigot-4bd94dc-3a482bd]

Possible to allow changing settings in-game without broadcasting in chat?

When you type numbers and letters to adjust the settings / save the arena / go back, it is being broadcasted in chat to all players on the server. This can get quite spammy, especially if you have one synced up network global chat.

Would it be possible to allow for settings to be changed via command instead?

Minor(?) issues on various aspects

Although there are few minor problems remaining, I'm convinced that this update is the best one, which significantly improved this plugin in ball physics and UI changes.
Nice work, shynixn! 👍

Game system, UI

  • Should force to change gamemode on join
  • /bbleave won't teleport you to the specified leave spawnpoint.
  • As soon as the game starts, notice players which team they're in

Game physics

  • EDIT: It is hard to make goals. There are 2 cases that make goal harder:
    • If goal area is thin, it won't count any goals. (This is trivial)
    • Goal area sometimes act as a WALL, blocking shots on target (especially higher shots).
  • Skeleton skull is occasionally placed when throwing off the ball with right click

Save spectator settings leads into setting title settings.

When I hit 3 to save spectator settings, it loads the chat output to set arena title/subtitle and bossbar/scoreboard settings instead of saving.

Oddly saving vault settings lead into setting max score / max players screen as well. Perhaps it is parsing the number for a specific page instead of the active one instead?

Missing dependencies after setting up workspace

I've cloned this repo and set up my local workspace for this project.
I definitely followed the instructions on document, however I can't build the project due to missing dependencies.
And what kind of spigot lib do I need? Please explain exactly.

Missing dependencies for root pom.xml:

  • org.apache.maven.plugins:maven-gpg-plugin:1.5

Missing ones for blockball-api:

  • com.github.shynixn.ball:ball-api:1.0-SNAPSHOT

for blockball-bukkit-api:

  • com.github.shynixn.blockball:blockball-api:5.0.1
  • com.github.shynixn.ball:ball-bukkit-api:1.0-SNAPSHOT
  • net:minecraft18R1:1.0 (... up to) net:minecraft112R1:1.0

for blockball-bukkit-plugin:

  • com.github.shynixn.blockball:blockball-bukkit-api:5.0.1
  • com.github.shynixn.ball:ball-bukkit-core:1.0-SNAPSHOT
  • com.google.inject:guice:4.1.0
  • org.bstats:bstats-bukkit:RELEASE
  • me.clip:placeholderapi:RELEASE
  • net.milkbowl.vault:VaultAPI:RELEASE
  • com.sk89q:worldguard:RELEASE
  • com.zaxxer:HikariCP:RELEASE
  • org.jetbrains.kotlin:kotlin-test:1.2.21
  • org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.2.21
  • org.slf4j:slf4j-jdk14:1.7.25
  • org.xerial:sqlite-jdbc:RELEASE
  • ch.vorburger.mariaDB4j:mariaDB4j:RELEASE
  • org.mockito:mockito-core:RELEASE
  • org.junit.jupiter:junit-jupiter-api:5.0.0-M4

Failed to hook into [WorldGuard]

Does BlockBall spam dependency hook requests until it is able to connect?

[22:25:56] [Server thread/INFO]: [BlockBall] Enabling BlockBall v3.8.0
[22:25:56] [Server thread/INFO]: [BlockBall] Loading BlockBall ...
[22:25:56] [Server thread/INFO]: [BlockBall] found dependency [WorldGuard] 5.
[22:25:56] [Server thread/INFO]: [BlockBall] failed to hook into [WorldGuard] 5.
[22:25:56] [Server thread/INFO]: [BlockBall] found dependency [WorldGuard] 6.
[22:25:56] [Server thread/INFO]: [BlockBall] hooked successfully into [WorldGuard] 6.
[22:25:56] [Server thread/INFO]: [BlockBall] found dependency [Vault].
[22:25:56] [Server thread/INFO]: [BlockBall] hooked successfully into [Vault].
[22:25:56] [Server thread/INFO]: [BlockBall] Enabled BlockBall 3.8.0 by Shynixn

Title & bossbar messages don't working

I'm using BlockBall v4.1, WorldEdit v6.1.7.3 in Spigot 1.12.1 server.
As I set up an arena and tested it, I realized some important in-game messages that didn't show up.
These are the broken strings

  • red/blue-score-title(subtitle)
  • red/blue-win-title(subtitle)
  • bossbar that shows the current score (I enabled the vanilla one in arena settings, not BossBarPlugin)

Here's the config of my arena
Please correct me if I'm missing something like no dependencies or wrong configs..

Registered deprecated event. [Needs to patched in 1.12_R2 or 1.13_R1]

Paper dev 1167 (Spigot 1.12)

[22:04:56] [Server thread/WARN]: [BlockBall] "BlockBall v4.0.1" has registered a listener for org.bukkit.event.player.PlayerPickupItemEvent on method "public void com.github.shynixn.blockball.business.logic.game.GameListener.onItemPickUpEvent(org.bukkit.event.player.PlayerPickupItemEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [Shynixn].

Being able to fly after the end of a game

Great plugin! However, when people play BlockBall and leave, they have flying abilities.
How do I fix this?

No, does this issue still appear? I thought, I have fixed this 3 times now. :( Can you send me one of your arena files via pastbin, so that I'm able to recreate it?

Received arena file. Testing it in the future.

#5

CommandException: Unhandled exception executing 'bbc'

blockball-3.8.1-20170303.142405-2.jar

[01:39:08 INFO]: player issued server command: /bbc
[01:39:08 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing 'bbc' in com.github.shynixn.blockball.business.logic.arena.ArenaCommandExecutor$1(bbc)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:160) ~[patched_1.11.2.jar:git-Paper-1063]
        at org.bukkit.craftbukkit.v1_11_R1.CraftServer.dispatchCommand(CraftServer.java:675) ~[patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.PlayerConnection.handleCommand(PlayerConnection.java:1384) ~[patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.PlayerConnection.a(PlayerConnection.java:1189) ~[patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.PacketPlayInChat.a(PacketPlayInChat.java:45) ~[patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:14) ~[patched_1.11.2.jar:git-Paper-1063]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_121]
        at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_121]
        at net.minecraft.server.v1_11_R1.SystemUtils.a(SourceFile:46) [patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.MinecraftServer.D(MinecraftServer.java:830) [patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.DedicatedServer.D(DedicatedServer.java:403) [patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.MinecraftServer.C(MinecraftServer.java:754) [patched_1.11.2.jar:git-Paper-1063]
        at net.minecraft.server.v1_11_R1.MinecraftServer.run(MinecraftServer.java:652) [patched_1.11.2.jar:git-Paper-1063]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_121]
Caused by: java.lang.NullPointerException
        at com.github.shynixn.blockball.lib.SChatMenuManager.handleChatMessage(SChatMenuManager.java:37) ~[?:?]
        at com.github.shynixn.blockball.business.logic.arena.ArenaCommandExecutor$1.onCommandSend(ArenaCommandExecutor.java:37) ~[?:?]
        at com.github.shynixn.blockball.lib.DynamicCommandHelper.execute(DynamicCommandHelper.java:32) ~[?:?]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:151) ~[patched_1.11.2.jar:git-Paper-1063]
        ... 14 more
navigate-chatmenu:
  enabled: true
  command: bbc
  useage: /<command>
  description: Helps navigating through the chamenu.
  permission: blockball.admin
  permission-message: You don't have permission

Inventory is carried over across worlds into the lounge when right clicking a join sign with an item and when the item opens a GUI.

blockball-3.8.1-20170303.142405-2.jar

I have it configured so players have a separate inventory in the Hub world and in the world where the BlockBall lounge / arena is located. So players who join a BlockBall game shouldn't carry over their inventory, gamemode, xp, health, etc. from the former world. However, if you right click the BlockBall join sign with an item from the other world, it will carry over that item / inventory into the lounge.

Would it be possible for items to not carry over into the lounge / separate world when hitting the join sign with it? To have an empty inventory when in the lounge.

Video example.
https://www.dropbox.com/s/ov2n0n8h39zqotd/2017-03-15%2002-09-31.mkv?dl=0

Max and min players

Is it possible to set the max and min players?
Becase now players can play alone

Delay (cooldown) for double-jumps

Overuse of double jumps could annoy the players if there are many players in one arena.
We need an option this cooldown length for our arena.

Below this is just my idea note for the future which may be off-topic:

  • Players are separated into their own position (Forward, Defend, GK)
  • Forward & defenders have long delay for double-jumps but short delay for ball kick delay.
  • GK has short delay for double jump as he/she wants to make goal saves

Adds global player stats

Could you add a ranking and stats for
How many goals it take
Win/loose rate
How many win and loose
I'm happy when you can adding this

Failed to load class "org.slf4j.impl.StaticLoggerBinder".

blockball-4.1.0-20170804.104410-2-jar-with-dependencies.jar
Paper dev 1178 (Spigot 1.12.1)

[23:39:28] [Server thread/INFO]: [BlockBall] Enabling BlockBall v4.1.0-SNAPSHOT
[23:39:28] [Server thread/INFO]: [BlockBall] Loading BlockBall ...
[23:39:28] [Server thread/WARN]: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[23:39:28] [Server thread/WARN]: SLF4J: Defaulting to no-operation (NOP) logger implementation
[23:39:28] [Server thread/WARN]: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[23:39:28] [Server thread/INFO]: Connected to jdbc:sqlite:/server3/plugins/BlockBall/BlockBall.db
[23:39:28] [Server thread/INFO]: [BlockBall] found dependency [WorldGuard] 5.
[23:39:28] [Server thread/INFO]: [BlockBall] failed to hook into [WorldGuard] 5.
[23:39:28] [Server thread/INFO]: [BlockBall] found dependency [WorldGuard] 6.
[23:39:28] [Server thread/INFO]: [BlockBall] hooked successfully into [WorldGuard] 6.
[23:39:28] [Server thread/INFO]: [BlockBall] found dependency [Vault].
[23:39:28] [Server thread/INFO]: [BlockBall] hooked successfully into [Vault].
[23:39:28] [Server thread/INFO]: [BlockBall] found dependency [PlaceholderAPI].
[23:39:28] [Server thread/INFO]: [BlockBall] hooked successfully into [PlaceholderAPI].
[23:39:28] [Server thread/INFO]: [BlockBall] Failed to register the last dependency.
[23:39:28] [Server thread/INFO]: [BlockBall] Enabled BlockBall 4.1.0-SNAPSHOT by Shynixn

Is it possible to adjust the double-jump distance?

My map isn't that large so the double-jump catch-up mechanic is quite overpowered. Is there any way to adjust the distance / thrust power you go when you double jump? As I can't seem to find a setting for it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.